Prepare 0.65.1 release

[tigrannajaryan]

• Update versions.yaml to 0.65.1
• Retract v0.65.0
• Add 0.65.1 to CHANGELOG.md and note that v0.65.0 is broken

[tigrannajaryan]

@codeboten please ping me when you have a fix for deb/rpm so that I can rebase this.

[dmitryax]

@tigrannajaryan #16436 was failing due to the 0.65.0 release not the GH actions. So this PR's build should pass once rebased

[tigrannajaryan]

Rebased.

[TylerHelmuth]

@dmitryax no luck

[tigrannajaryan]

It is a different problem this time:

# test install
echo
$docker_run
7f87e2e1d370039b51a3c7b48f94ef086d834c06f9ab6f348145c634f964edc0
install_pkg $container_name "$PKG_PATH"
Installing otel-contrib-collector_0.65.0-post_amd64.deb ...
Copying dist/otel-contrib-collector_0.65.0-post_amd64.deb to otelcontribcol-deb-test:/tmp/otel-contrib-collector_0.65.0-post_amd64.deb ...
Selecting previously unselected package otel-contrib-collector.
(Reading database ... 8283 files and directories currently installed.)
Preparing to unpack .../otel-contrib-collector_0.65.0-post_amd64.deb ...
Unpacking otel-contrib-collector (0.65.0-post) ...
Setting up otel-contrib-collector (0.65.0-post) ...
Failed to connect to bus: No such file or directory
Failed to connect to bus: No such file or directory
dpkg: error processing package otel-contrib-collector (--install):
 subprocess installed post-installation script returned error exit status 1
Errors were encountered while processing:
 otel-contrib-collector
docker rm -fv otelcontribcol-deb-test >/dev/null 2>&1 || true
Error: Process completed with exit code 1.

What does Failed to connect to bus mean??

And why do we have 0.65.0 version in the file name? Supposed to be 0.65.1.

[TylerHelmuth]

@tigrannajaryan @dmitryax @codeboten I think the issue is that the set_release_tag.sh script is no longer working correctly after #16389.

The result of that script isn't in the output

but the next step in the workflow shows that the version isn't getting properly set for the next script.

The workflow calls the script with ./internal/buildscripts/packaging/fpm/${{ matrix.package_type }}/build.sh "${{ steps.github_tag.outputs.tag }}" "amd64" "./dist/"

If steps.github_tag.outputs.tag isn't set, then the script does:

if [[ -z "$VERSION" ]]; then
    latest_tag="$( git describe --abbrev=0 --match v[0-9]* )"
    VERSION="${latest_tag}-post"
fi

Those line match the screenshot above, so I think that means that $VERSION isn't getting set, which implies steps.github_tag.outputs.tag is not set.

[TylerHelmuth]

Nevermind, the last release does the same thing: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3428200998/jobs/5712744869. 🤷

[TylerHelmuth]

It looks like the script always ends up using git describe --abbrev=0 --match v[0-9]* to get the latest tag so maybe the issue is that since 0.65.0 is the latest tag and since 0.65.0 is broken the build doesn't work ?

[tigrannajaryan]

@open-telemetry/collector-contrib-maintainer I haven't work on the contrib for a while, I don't know how the release works and don't have the expertise to solve this myself. I will need your help to figure it out.

[dmitryax]

I'm looking into this

@TylerHelmuth I see that at least this commit after 0.65.0 partially succeeded, so not sure it's related to 0.65.0.

[bogdandrutu]

This commit correctly should be done against the release branch

[dmitryax]

@bogdandrutu I can make another PR against release/0.65.x. The problem is that we don't have such branch, only release/0.65.0. Do you think we should proceed on main or create an additional release/0.65.x branch from 0.65.0 release commit?

[bogdandrutu]

we have now, https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/release/v0.65.x, I renamed that branch

[tigrannajaryan]

Closed in favour of #16457