Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka exporter] Allow for additional marshalers to be added. #16514

Merged

Conversation

MovieStoreGuy
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy commented Nov 29, 2022

Description:
This change allows anyone wanting to extend the kafka exporter to add in their own marshalers.

Link to tracking Issue:
#14514

Testing:
Additional tests that matches existing pattern.

Documentation:
No direct user impact for this.

@MovieStoreGuy
Copy link
Contributor Author

This is a clone of #16100 but the PR has gone stale.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MovieStoreGuy MovieStoreGuy added the ready to merge Code review completed; ready to merge by maintainers label Nov 30, 2022
@codeboten codeboten merged commit 4a496a4 into open-telemetry:main Nov 30, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…elemetry#16514)

Adding in work for allowing custom metrics and logs marshalers
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/kafka ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants