Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testbed OTLP receiver should use compression=none for no-gzip test #16558

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Testbed OTLP receiver should use compression=none for no-gzip test #16558

merged 1 commit into from
Dec 1, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Nov 30, 2022

Description:

The OTLP Exporter testbed receiver has no-gzip tests that are actually configuring gzip, so two identical test scenarios for gRPC and HTTP each. This fixes it.

Link to tracking Issue:

Related feature request: open-telemetry/opentelemetry-collector#6638.

Testing:

before

Trace10kSPS/OTLP-gRPC                   |PASS  |     15s|    16.7|    18.6|         52|         75|    150000|        150000|
Trace10kSPS/OTLP-gRPC-gzip              |PASS  |     15s|    16.7|    34.1|         54|         76|    149900|        149900|
Trace10kSPS/OTLP-HTTP                   |PASS  |     15s|    16.4|    17.1|         47|         68|    150000|        150000|
Trace10kSPS/OTLP-HTTP-gzip              |PASS  |     15s|    16.9|    18.8|         47|         67|    149800|        149800|

after

Trace10kSPS/OTLP-gRPC                   |PASS  |     15s|    11.0|    12.8|         54|         77|    149300|        149300|
Trace10kSPS/OTLP-gRPC-gzip              |PASS  |     15s|    14.7|    16.5|         54|         78|    149500|        149500|
Trace10kSPS/OTLP-HTTP                   |PASS  |     15s|     9.6|    11.8|         45|         65|    149000|        149000|
Trace10kSPS/OTLP-HTTP-gzip              |PASS  |     15s|    13.2|    14.4|         47|         68|    148300|        148300|

@jmacd jmacd requested review from a team and bogdandrutu November 30, 2022 21:51
@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 30, 2022
@bogdandrutu bogdandrutu merged commit bb3bf6e into open-telemetry:main Dec 1, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@jmacd @shalper2
Testbed OTLP receiver should use compression=none for no-gzip test (o…
a97b207 
…pen-telemetry#16558)
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@mx-psi mx-psi

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmacd @bogdandrutu @mx-psi