[chore] remove calls to validate the configuration, now done in the config builder #17534

atoulme · 2023-01-12T04:46:50Z

Description:
As exposed in this comment, there is no longer a need to explicitly call Validate() on configuration when creating a component.
This PR removes occurrences of such calls.

runforesight · 2023-01-12T04:48:58Z

Foresight Summary

Major Impacts

build-and-test-windows duration(28 minutes 55 seconds) has decreased 12 minutes 56 seconds compared to main branch avg(41 minutes 51 seconds).

View More Details

✅ check-links workflow has finished in 6 minutes 56 seconds (⚠️ 4 minutes 53 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
changed files	- 🔗	N/A	See Details
check-links	- 🔗	N/A	See Details

✅ tracegen workflow has finished in 7 minutes 9 seconds (⚠️ 4 minutes 36 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
publish-latest	- 🔗	N/A	See Details
build-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details

✅ telemetrygen workflow has finished in 7 minutes 10 seconds (⚠️ 4 minutes 32 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
build-dev	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-latest	- 🔗	N/A	See Details

✅ prometheus-compliance-tests workflow has finished in 9 minutes 28 seconds and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
prometheus-compliance-tests	- 🔗	✅ 21 ❌ 0 ⏭ 0 🔗	See Details

✅ load-tests workflow has finished in 13 minutes 46 seconds and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	- 🔗	✅ 3 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestIdleMode)	- 🔗	✅ 1 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceNoBackend10kSPS\|TestTrace1kSPSWithAttrs)	- 🔗	✅ 8 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetric10kDPS\|TestMetricsFromFile)	- 🔗	✅ 6 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs\|TestTraceBallast1kSPSAddAttrs)	- 🔗	✅ 10 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestMetricResourceProcessor\|TestTrace10kSPS)	- 🔗	✅ 12 ❌ 0 ⏭ 0 🔗	See Details
loadtest (TestBallastMemory\|TestLog10kDPS)	- 🔗	✅ 19 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details

✅ build-and-test workflow has finished in 44 minutes 47 seconds and finished at 12th Jan, 2023.

Job	Failed Steps	Tests
unittest-matrix (1.18, internal)	- 🔗	✅ 640 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, internal)	- 🔗	✅ 640 ❌ 0 ⏭ 0 🔗	See Details
correctness-metrics	- 🔗	✅ 2 ❌ 0 ⏭ 0 🔗	See Details
correctness-traces	- 🔗	✅ 17 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, processor)	- 🔗	✅ 1481 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, extension)	- 🔗	✅ 528 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, processor)	- 🔗	✅ 1481 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-0)	- 🔗	✅ 2565 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-0)	- 🔗	✅ 2565 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, exporter)	- 🔗	✅ 2463 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, exporter)	- 🔗	✅ 2463 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, other)	- 🔗	✅ 4438 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, other)	- 🔗	✅ 4438 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.18, receiver-1)	- 🔗	✅ 1884 ❌ 0 ⏭ 0 🔗	See Details
integration-tests	- 🔗	✅ 55 ❌ 0 ⏭ 0 🔗	See Details
unittest-matrix (1.19, receiver-1)	- 🔗	✅ 1884 ❌ 0 ⏭ 0 🔗	See Details
setup-environment	- 🔗	N/A	See Details
build-examples	- 🔗	N/A	See Details
check-codeowners	- 🔗	N/A	See Details
check-collector-module-version	- 🔗	N/A	See Details
checks	- 🔗	N/A	See Details
lint-matrix (receiver-0)	- 🔗	N/A	See Details
lint-matrix (receiver-1)	- 🔗	N/A	See Details
lint-matrix (processor)	- 🔗	N/A	See Details
lint-matrix (exporter)	- 🔗	N/A	See Details
lint-matrix (extension)	- 🔗	N/A	See Details
lint-matrix (internal)	- 🔗	N/A	See Details
lint-matrix (other)	- 🔗	N/A	See Details
lint	- 🔗	N/A	See Details
unittest (1.19)	- 🔗	N/A	See Details
unittest (1.18)	- 🔗	N/A	See Details
cross-compile (darwin, amd64)	- 🔗	N/A	See Details
cross-compile (darwin, arm64)	- 🔗	N/A	See Details
cross-compile (linux, 386)	- 🔗	N/A	See Details
cross-compile (linux, amd64)	- 🔗	N/A	See Details
cross-compile (linux, arm)	- 🔗	N/A	See Details
cross-compile (linux, arm64)	- 🔗	N/A	See Details
cross-compile (linux, ppc64le)	- 🔗	N/A	See Details
cross-compile (windows, 386)	- 🔗	N/A	See Details
cross-compile (windows, amd64)	- 🔗	N/A	See Details
build-package (deb)	- 🔗	N/A	See Details
build-package (rpm)	- 🔗	N/A	See Details
windows-msi	- 🔗	N/A	See Details
publish-check	- 🔗	N/A	See Details
publish-stable	- 🔗	N/A	See Details
publish-dev	- 🔗	N/A	See Details

⭕ changelog workflow has finished in 4 seconds (2 minutes less than `main` branch avg.) and finished at 18th Jan, 2023.

Job	Failed Steps	Tests
changelog	- 🔗	N/A	See Details

✅ build-and-test-windows workflow has finished in 28 minutes 55 seconds (12 minutes 56 seconds less than `main` branch avg.) and finished at 18th Jan, 2023.

Job	Failed Steps	Tests
windows-unittest-matrix (extension)	- 🔗	✅ 515 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (internal)	- 🔗	✅ 629 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (processor)	- 🔗	✅ 1488 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (exporter)	- 🔗	✅ 2438 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (receiver-1)	- 🔗	✅ 1844 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (other)	- 🔗	✅ 4298 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest-matrix (receiver-0)	- 🔗	✅ 2558 ❌ 0 ⏭ 0 🔗	See Details
windows-unittest	- 🔗	N/A	See Details

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

dmitryax · 2023-01-12T05:57:40Z

Please update failing tests as well

atoulme · 2023-01-12T06:10:18Z

I'm on it ! Sorry, will keep iterating on it and get more PRs to help clean this up.

…onfig builder

dmitryax

Just couple of nits

exporter/sumologicexporter/exporter_test.go

receiver/jmxreceiver/receiver.go

dmitryax · 2023-01-13T03:28:44Z

I'll keep it open for some time to see if there is feedback from the code owners

atoulme requested a review from a team January 12, 2023 04:46

atoulme requested review from jmacd, dmitryax, djaglowski, dashpole and jpkrohling as code owners January 12, 2023 04:46

github-actions bot added exporter/elasticsearch exporter/logzio exporter/loki Loki Exporter exporter/mezmo exporter/sumologic receiver/jmx JMX Receiver receiver/sapm receiver/signalfx receiver/solace receiver/statsd statsd related issues labels Jan 12, 2023

github-actions bot assigned dashpole Jan 12, 2023

atoulme force-pushed the remove_validate branch 2 times, most recently from 899b3c2 to b31e4ad Compare January 12, 2023 05:44

atoulme force-pushed the remove_validate branch from b31e4ad to a249b06 Compare January 12, 2023 06:08

atoulme force-pushed the remove_validate branch 2 times, most recently from b6cc827 to a346765 Compare January 12, 2023 06:35

[chore] remove calls to validate the configuration, now done in the c…

7cab67c

…onfig builder

atoulme force-pushed the remove_validate branch from a346765 to 7cab67c Compare January 12, 2023 08:16

atoulme added 3 commits January 12, 2023 00:39

goimports

2506592

make jmx pass component tests

7f3942b

goimports

e007c72

dmitryax reviewed Jan 13, 2023

View reviewed changes

exporter/sumologicexporter/exporter_test.go Show resolved Hide resolved

receiver/jmxreceiver/receiver.go Show resolved Hide resolved

dmitryax approved these changes Jan 13, 2023

View reviewed changes

atoulme removed exporter/elasticsearch receiver/signalfx labels Jan 13, 2023

djaglowski approved these changes Jan 17, 2023

View reviewed changes

dmitryax added the Run Windows Enable running windows test on a PR label Jan 18, 2023

dmitryax merged commit cdf0a42 into open-telemetry:main Jan 18, 2023

plantfansam mentioned this pull request Jul 21, 2023

disregard #24427

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore] remove calls to validate the configuration, now done in the config builder #17534

[chore] remove calls to validate the configuration, now done in the config builder #17534

atoulme commented Jan 12, 2023

runforesight bot commented Jan 12, 2023 •

edited

Loading

`build-and-test-windows` duration(28 minutes 55 seconds) has decreased 12 minutes 56 seconds compared to main branch avg(41 minutes 51 seconds).

✅ check-links workflow has finished in 6 minutes 56 seconds (⚠️ 4 minutes 53 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

✅ tracegen workflow has finished in 7 minutes 9 seconds (⚠️ 4 minutes 36 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

✅ telemetrygen workflow has finished in 7 minutes 10 seconds (⚠️ 4 minutes 32 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 9 minutes 28 seconds and finished at 12th Jan, 2023.

✅ load-tests workflow has finished in 13 minutes 46 seconds and finished at 12th Jan, 2023.

✅ build-and-test workflow has finished in 44 minutes 47 seconds and finished at 12th Jan, 2023.

⭕ changelog workflow has finished in 4 seconds (2 minutes less than `main` branch avg.) and finished at 18th Jan, 2023.

✅ build-and-test-windows workflow has finished in 28 minutes 55 seconds (12 minutes 56 seconds less than `main` branch avg.) and finished at 18th Jan, 2023.

dmitryax commented Jan 12, 2023

atoulme commented Jan 12, 2023

dmitryax left a comment

dmitryax commented Jan 13, 2023

[chore] remove calls to validate the configuration, now done in the config builder #17534

[chore] remove calls to validate the configuration, now done in the config builder #17534

Conversation

atoulme commented Jan 12, 2023

runforesight bot commented Jan 12, 2023 • edited Loading

Foresight Summary

build-and-test-windows duration(28 minutes 55 seconds) has decreased 12 minutes 56 seconds compared to main branch avg(41 minutes 51 seconds).

✅ check-links workflow has finished in 6 minutes 56 seconds (⚠️ 4 minutes 53 seconds more than main branch avg.) and finished at 12th Jan, 2023.

✅ tracegen workflow has finished in 7 minutes 9 seconds (⚠️ 4 minutes 36 seconds more than main branch avg.) and finished at 12th Jan, 2023.

✅ telemetrygen workflow has finished in 7 minutes 10 seconds (⚠️ 4 minutes 32 seconds more than main branch avg.) and finished at 12th Jan, 2023.

✅ prometheus-compliance-tests workflow has finished in 9 minutes 28 seconds and finished at 12th Jan, 2023.

✅ load-tests workflow has finished in 13 minutes 46 seconds and finished at 12th Jan, 2023.

✅ build-and-test workflow has finished in 44 minutes 47 seconds and finished at 12th Jan, 2023.

⭕ changelog workflow has finished in 4 seconds (2 minutes less than main branch avg.) and finished at 18th Jan, 2023.

✅ build-and-test-windows workflow has finished in 28 minutes 55 seconds (12 minutes 56 seconds less than main branch avg.) and finished at 18th Jan, 2023.

dmitryax commented Jan 12, 2023

atoulme commented Jan 12, 2023

dmitryax left a comment

Choose a reason for hiding this comment

dmitryax commented Jan 13, 2023

runforesight bot commented Jan 12, 2023 •

edited

Loading

`build-and-test-windows` duration(28 minutes 55 seconds) has decreased 12 minutes 56 seconds compared to main branch avg(41 minutes 51 seconds).

✅ check-links workflow has finished in 6 minutes 56 seconds (⚠️ 4 minutes 53 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

✅ tracegen workflow has finished in 7 minutes 9 seconds (⚠️ 4 minutes 36 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

✅ telemetrygen workflow has finished in 7 minutes 10 seconds (⚠️ 4 minutes 32 seconds more than `main` branch avg.) and finished at 12th Jan, 2023.

⭕ changelog workflow has finished in 4 seconds (2 minutes less than `main` branch avg.) and finished at 18th Jan, 2023.

✅ build-and-test-windows workflow has finished in 28 minutes 55 seconds (12 minutes 56 seconds less than `main` branch avg.) and finished at 18th Jan, 2023.