Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/count] Allow counting by attributes #19432

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

djaglowski
Copy link
Member

Resolves #18893

@runforesight
Copy link

runforesight bot commented Mar 9, 2023

Foresight Summary

    
Major Impacts

TestReceiveLogs ❌ failed 1 times in 6 runs (16% fail rate).
TestReceiveLogs/1_log_event_per_payload_(configured_max_content_length_is_same_as_event_size) ❌ failed 1 times in 6 runs (16% fail rate).
build-and-test duration(32 minutes 17 seconds) has decreased 32 minutes 53 seconds compared to main branch avg(1 hour 5 minutes 10 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 9 seconds (43 minutes 22 seconds less than main branch avg.) and finished at 11th Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 6 seconds (1 minute less than main branch avg.) and finished at 11th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 39 seconds and finished at 11th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 36 seconds and finished at 11th Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  load-tests workflow has finished in 7 minutes 10 seconds (6 minutes 10 seconds less than main branch avg.) and finished at 11th Mar, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 12 minutes 20 seconds (⚠️ 4 minutes 44 seconds more than main branch avg.) and finished at 11th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 14 minutes 45 seconds and finished at 11th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 32 minutes 17 seconds (32 minutes 53 seconds less than main branch avg.) and finished at 13th Mar, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, exporter) -     🔗  ✅ 2484  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, exporter) -     🔗  ✅ 2484  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4728  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) -     🔗  ✅ 4728  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1940  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) -     🔗  ✅ 1940  ❌ 0  ⏭ 0    🔗 See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@djaglowski djaglowski changed the title Allow count connector to count by attributes [connector/count] Allow counting by attributes Mar 9, 2023
@djaglowski djaglowski marked this pull request as ready for review March 9, 2023 21:58
@djaglowski djaglowski requested a review from a team March 9, 2023 21:58
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass - saw some error messages that need to be differentiated per signal type.

connector/countconnector/config.go Outdated Show resolved Hide resolved
connector/countconnector/config.go Show resolved Hide resolved
connector/countconnector/config.go Outdated Show resolved Hide resolved
Co-authored-by: Antoine Toulme <antoine@toulme.name>
@djaglowski
Copy link
Member Author

This is ready for another review.

@djaglowski djaglowski merged commit f775944 into open-telemetry:main Mar 14, 2023
@djaglowski djaglowski deleted the count-by-attributes branch March 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector/count] - Add dimensions based on OTTL
3 participants