Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sumologic] use generated status header #20725

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

codeboten
Copy link
Contributor

This PR updates the component to generate the status table using mdatagen. Questions to the code owners:

Does this component require any of the standard warnings? See list: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/standard-warnings.md

See related issue: #19172

This PR updates the component to generate the status table using mdatagen. Questions to the code owners:

Does this component require any of the standard warnings? See list: https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/standard-warnings.md

See related issue: open-telemetry#19172

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 5, 2023
@codeboten codeboten requested review from a team and dashpole April 5, 2023 21:32
@github-actions github-actions bot requested a review from sumo-drosiek April 5, 2023 21:32
@runforesight
Copy link

runforesight bot commented Apr 5, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(7 seconds) has decreased 30 minutes 13 seconds compared to main branch avg(30 minutes 20 seconds).
View More Details

⭕  changelog workflow has finished in 5 seconds (2 minutes 9 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 7 seconds (31 minutes 59 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 57 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 31 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 4 seconds (3 minutes 15 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  load-tests workflow has finished in 6 minutes 29 seconds (3 minutes 51 seconds less than main branch avg.) and finished at 5th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 13 minutes 14 seconds and finished at 5th Apr, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 39 minutes 6 seconds (7 minutes 35 seconds less than main branch avg.) and finished at 11th Apr, 2023.


Job Failed Steps Tests
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
rotate-milestone -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax
Copy link
Member

dmitryax commented Apr 5, 2023

Another Q to code owners: is this exporter needed given that there is https://github.com/SumoLogic/sumologic-otel-collector/tree/main/pkg/exporter/sumologicexporter ? :)

@andrzej-stencel
Copy link
Member

andrzej-stencel commented Apr 11, 2023

Another Q to code owners: is this exporter needed given that there is https://github.com/SumoLogic/sumologic-otel-collector/tree/main/pkg/exporter/sumologicexporter ? :)

This is an excellent question 😅 and a long-running debate in our team. The history is, we originally created the Sumo Logic exporter in contrib, and then switched to keeping the sources together with the Sumo Logic Distribution for OpenTelemetry Collector at https://github.com/sumologic/sumologic-otel-collector. We have a couple other components in the distro repo, some of them more and some of them less fitting for the contrib repo.

The point I think we all agree on in the team is that we want to keep the presence of Sumo Logic components in the contrib repo as much as possible, big part of it being the popularity of the contrib release among end users.

After having another discussion in the team today, we're at a point where we want to move the Sumo Logic exporter back to the contrib repo. For that to make sense, we'd need to put the Sumo Logic extension in contrib repo as well, as it is an important part of the Sumo Logic exporter's functionality. Do you think it makes sense @dmitryax?

@codeboten codeboten merged commit bc239b5 into open-telemetry:main Apr 11, 2023
@codeboten codeboten deleted the codeboten/status-header-14 branch April 11, 2023 21:41
@github-actions github-actions bot added this to the next release milestone Apr 11, 2023
@dmitryax
Copy link
Member

After having another discussion in the team today, we're at a point where we want to move the Sumo Logic exporter back to the contrib repo. For that to make sense, we'd need to put the Sumo Logic extension in contrib repo as well, as it is an important part of the Sumo Logic exporter's functionality. Do you think it makes sense @dmitryax?

I don't have any objections. I think it's ok to add vendor components other than receivers/exporters. We already have https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/datadogprocessor

cc @open-telemetry/collector-contrib-approvers

@TylerHelmuth
Copy link
Member

Agreed, all our existing rules state vendor-specific components and not a specific type of component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/sumologic Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants