Update attribute processor's readme #20855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details✅ telemetrygen workflow has finished in 1 minute 5 seconds and finished at 11th Apr, 2023.
✅ check-links workflow has finished in 1 minute 49 seconds (
|
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changed files | - 🔗 | N/A | See Details |
| check-links | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 6 minutes 47 seconds (3 minutes 33 seconds less than main branch avg.) and finished at 11th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| setup-environment | - 🔗 | N/A | See Details |
| loadtest (TestIdleMode) | - 🔗 | N/A | See Details |
| loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | N/A | See Details |
| loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | N/A | See Details |
| loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | N/A | See Details |
| loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | N/A | See Details |
| loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | N/A | See Details |
| loadtest (TestTraceAttributesProcessor) | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 9 minutes 24 seconds (⚠️ 3 minutes 3 seconds more than main branch avg.) and finished at 11th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| prometheus-compliance-tests | - 🔗 | N/A | See Details |
✅ e2e-tests workflow has finished in 25 minutes 20 seconds (⚠️ 11 minutes 14 seconds more than main branch avg.) and finished at 11th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| kubernetes-test (v1.26.0) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.25.3) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.24.7) | - 🔗 | N/A | See Details |
| kubernetes-test (v1.23.13) | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 3 seconds (30 minutes 40 seconds less than main branch avg.) and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| windows-unittest-matrix | - 🔗 | N/A | See Details |
| windows-unittest | - 🔗 | N/A | See Details |
⭕ changelog workflow has finished in 3 seconds (2 minutes 12 seconds less than main branch avg.) and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| changelog | - 🔗 | N/A | See Details |
⭕ build-and-test workflow has finished in 21 minutes 20 seconds (25 minutes 29 seconds less than main branch avg.) and finished at 12th Apr, 2023.
| Job | Failed Steps | Tests | |
|---|---|---|---|
| unittest-matrix (1.20, other) | - 🔗 | N/A | See Details |
| unittest (1.20) | Interpret result 🔗 | N/A | See Details |
| unittest (1.19) | Interpret result 🔗 | N/A | See Details |
| cross-compile | - 🔗 | N/A | See Details |
| windows-msi | - 🔗 | N/A | See Details |
| build-package | - 🔗 | N/A | See Details |
| publish-stable | - 🔗 | N/A | See Details |
| publish-dev | - 🔗 | N/A | See Details |
| publish-check | - 🔗 | N/A | See Details |
| rotate-milestone | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
|
I also added a change to the example configs in |
jpkrohling
approved these changes
Apr 12, 2023
|
I triggered the failing tests to run again. |
|
I made a couple of additional changes to the readme:
|
Add "attributes" and "libraries" as invalid metrics filters.
jpkrohling
force-pushed
the
update-attributes-processor-readme
branch
from
caeabdd to
9087fd0
Compare
|
PR rebased |
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
* Update readme * Update test config * Remove "resource_attributes" from readme. Add "attributes" and "libraries" as invalid metrics filters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a feature for the Grafana Agent, I noticed that the the attribute processor's readme is out of date. This PR changes the following:
expressions. I'm not sure what this is in the first place, and why it is in the .md file.span_kindsandlog_severity_numberresourcesandlibrariesare described in config.It seems filtering based on severity number and span kinds was added later, which is why the documentation does not mention them.
I did not add a changelog entry for this PR because it's quite a minor change.