Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/groupbyattrs] Update to use generated status #21061

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Updates groupbyattrsprocessor to use new generated status header. Doing a quick review I don't think there are any Warnings to list.

Link to tracking Issue:
#19172

@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 19, 2023
@TylerHelmuth TylerHelmuth requested review from a team and jpkrohling April 19, 2023 01:22
@github-actions github-actions bot added the processor/groupbyattrs Group By Attributes processor label Apr 19, 2023
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@github-actions github-actions bot added the processor/groupbytrace Group By Trace processor label Apr 19, 2023
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Apr 19, 2023
@TylerHelmuth TylerHelmuth force-pushed the gbap-generate-header branch from 81194ae to 00f2b14 Compare April 19, 2023 18:19
@TylerHelmuth TylerHelmuth merged commit a39dfaa into open-telemetry:main Apr 19, 2023
@TylerHelmuth TylerHelmuth deleted the gbap-generate-header branch April 19, 2023 18:59
@github-actions github-actions bot added this to the next release milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants