[extension/sigv4authextension] update to use generated status #21285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-git9
force-pushed
the
sigv4authextensionstatus
branch
3 times, most recently
from
77ec6cd to
178864e
Compare
Signed-off-by: xin.li <xin.li@daocloud.io>
my-git9
force-pushed
the
sigv4authextensionstatus
branch
from
178864e to
23c98f2
Compare
codeboten
reviewed
May 5, 2023
|
|
||
| status: | ||
| class: extension | ||
| stability: beta |
There was a problem hiding this comment.
Suggested change
| stability: beta | |
| stability: | |
| beta: [extension] |
| @@ -30,7 +32,7 @@ const ( | |||
|
|
|||
| // NewFactory creates a factory for the Sigv4 Authenticator extension. | |||
| func NewFactory() extension.Factory { | |||
| return extension.NewFactory(typeStr, createDefaultConfig, createExtension, component.StabilityLevelBeta) | |||
| return extension.NewFactory(typeStr, createDefaultConfig, createExtension, metadata.Stability) | |||
There was a problem hiding this comment.
Suggested change
| return extension.NewFactory(typeStr, createDefaultConfig, createExtension, metadata.Stability) | |
| return extension.NewFactory(typeStr, createDefaultConfig, createExtension, metadata.ExtensionStability) |
Comment on lines
+10
to
+11
| Type = "sigv4authextension" | ||
| Stability = component.StabilityLevelBeta |
There was a problem hiding this comment.
Suggested change
| Type = "sigv4authextension" | |
| Stability = component.StabilityLevelBeta | |
| Type = "sigv4authextension" | |
| ExtensionStability = component.StabilityLevelBeta |
|
This PR conflicts with #20326, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This updates the metadata for the extension to include stability information used to generate the status table.
Link to tracking Issue:
#19172
Testing:
Documentation: