Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Deprecate k8s.container.restarts in favor of k8s.container.restart_count #24055

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 10, 2023

Description:

Deprecate k8s.container.restarts in favour of k8s.container.restart_count with proper units. As described in
#10553

Link to tracking Issue:

#10553

Testing:

  • Updated existing tests

Documentation:

  • Updated

@github-actions github-actions bot requested a review from dmitryax July 10, 2023 08:58
@povilasv povilasv changed the title [receiver/k8scluster] Change k8s.container.restarts to k8s.container.restart_count [receiver/k8scluster] Deprecate k8s.container.restarts in favor of k8s.container.restart_count Jul 10, 2023
@povilasv povilasv force-pushed the container-restarts-k8sclusterreceiver branch 7 times, most recently from a7a261c to e9e46ed Compare July 10, 2023 11:56
@povilasv povilasv force-pushed the container-restarts-k8sclusterreceiver branch from e9e46ed to e4c31b5 Compare July 10, 2023 12:25
@povilasv povilasv marked this pull request as ready for review July 10, 2023 13:10
@povilasv povilasv requested a review from a team July 10, 2023 13:10
@dmitryax
Copy link
Member

dmitryax commented Jul 12, 2023

Let's not introduce any new metric because of this. We can fix the units by one feature gate for all the metrics. But before that, I'd suggest move all the metrics to mdatagen keeping the current units

@povilasv
Copy link
Contributor Author

Closing this as we don't want to change the metric name here, the plan is to introduce feature gate for renames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants