Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loadbalancingexporter] add docs/example for k8s service resolver #24362

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

fyuan1316
Copy link
Contributor

Description:

improve document for k8s service resolver of exporter/loadbalancingexporter

Link to tracking Issue:
#24287

Testing:

Documentation:
Add example/k8s-resolver/README.md
The description of the k8s resolver from exporter/loadbalancingexporter/README.md can be jump-linked to example.

@fyuan1316 fyuan1316 requested a review from a team July 18, 2023 01:36
@fyuan1316 fyuan1316 requested a review from jpkrohling as a code owner July 18, 2023 01:36
@jpkrohling jpkrohling marked this pull request as draft July 20, 2023 00:20
@jpkrohling
Copy link
Member

I believe this is built on top of the PR for this resolver, so I'm marking this as draft. Once that is merged, this should be rebased and contain only the doc changes.

@fyuan1316 fyuan1316 marked this pull request as ready for review July 27, 2023 02:06
…lver

Signed-off-by: Yuan Fang <yuanfang@alauda.io>
@jpkrohling jpkrohling merged commit bca4670 into open-telemetry:main Jul 27, 2023
@github-actions github-actions bot added this to the next release milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants