[receiver/k8scluster] Convert clusterresourcequota to use pdata #24416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts the clusterresourcequota metrics to use the pdata format instead of opencensus.
crobert-1
commented
Jul 20, 2023
receiver/k8sclusterreceiver/internal/clusterresourcequota/clusterresourcequotas.go
Show resolved
Hide resolved
dmitryax
reviewed
Jul 20, 2023
receiver/k8sclusterreceiver/internal/clusterresourcequota/clusteresourcequotas.go
Show resolved
Hide resolved
receiver/k8sclusterreceiver/internal/clusterresourcequota/clusterresourcequotas.go
Outdated
Show resolved
Hide resolved
- resource should be an attribute of the metric, not a resource attribute. - k8s namespace needs to also be an attribute of the metric and not a resource attribute - Remove unecessary extra method - Update test to match original format of metrics
dmitryax
reviewed
Jul 21, 2023
receiver/k8sclusterreceiver/internal/clusterresourcequota/clusterresourcequotas.go
Outdated
Show resolved
Hide resolved
atoulme
approved these changes
Jul 24, 2023
|
@crobert-1 is this PR ready? |
Yes, this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This converts the clusterresourcequota metrics of the k8scluster receiver to use the pdata metric format instead of opencensus.
Link to tracking Issue:
#4367
Testing:
Updated existing test to use pdata, ensuring metrics have same output format.
Documentation: