-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove retry_on_failure from the googlecloud exporters #25900
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
dashpole:remove_retry_on_failure
Aug 22, 2023
Merged
Remove retry_on_failure from the googlecloud exporters #25900
dmitryax
merged 1 commit into
open-telemetry:main
from
dashpole:remove_retry_on_failure
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/googlecloud
exporter/googlemanagedprometheus
Google Managed Prometheus exporter
labels
Aug 18, 2023
dashpole
force-pushed
the
remove_retry_on_failure
branch
from
August 18, 2023 20:17
5ee4cc9
to
f93b2da
Compare
aabmass
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmitryax
approved these changes
Aug 18, 2023
@dashpole PTAL at the linter failures |
dashpole
force-pushed
the
remove_retry_on_failure
branch
2 times, most recently
from
August 21, 2023 13:14
95be4fe
to
9c3d0dc
Compare
dashpole
force-pushed
the
remove_retry_on_failure
branch
from
August 21, 2023 13:17
9c3d0dc
to
f659ec8
Compare
codeboten
pushed a commit
that referenced
this pull request
Nov 3, 2023
**Description:** Logging was broken after #25900 (released in v0.84.0). It is fixed by open-telemetry/opentelemetry-collector#8792, which will be released in v0.89.0. This will help with any distributions that include the googlecloud exporter components.
foadnh
added a commit
to Canva/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2023
* [chore] dependabot updates Wed Aug 9 04:37:47 UTC 2023 (#25105) Bump github.com/Azure/azure-event-hubs-go/v3 from 3.6.0 to 3.6.1 in /receiver/azureblobreceiver Bump github.com/Azure/azure-event-hubs-go/v3 from 3.6.0 to 3.6.1 in /receiver/azureeventhubreceiver Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.44.316 to 1.44.319 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go-v2 from 1.20.0 to 1.20.1 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/config from 1.18.32 to 1.18.33 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.31 to 1.13.32 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.21.1 to 1.21.2 in /extension/sigv4authextension Bump github.com/getsentry/sentry-go from 0.22.0 to 0.23.0 in /exporter/sentryexporter Bump github.com/hashicorp/consul/api from 1.23.0 to 1.24.0 in /internal/metadataproviders Bump github.com/hashicorp/consul/api from 1.23.0 to 1.24.0 in /processor/resourcedetectionprocessor Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /exporter/signalfxexporter Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /extension/observer/hostobserver Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /receiver/awscontainerinsightreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /receiver/hostmetricsreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /receiver/jmxreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7 in /testbed Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.715 to 1.0.717 in /exporter/tencentcloudlogserviceexporter Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /extension/observer/dockerobserver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /internal/coreinternal Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/aerospikereceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/apachereceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/dockerstatsreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/elasticsearchreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/flinkmetricsreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/jmxreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/kafkametricsreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/memcachedreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/mongodbreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/mysqlreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/nginxreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/postgresqlreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/redisreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/sqlqueryreceiver Bump github.com/testcontainers/testcontainers-go from 0.21.0 to 0.22.0 in /receiver/zookeeperreceiver Bump github.com/vmware/govmomi from 0.30.6 to 0.30.7 in /receiver/vcenterreceiver Bump go.mongodb.org/mongo-driver from 1.12.0 to 1.12.1 in /receiver/mongodbreceiver Bump golang.org/x/crypto from 0.11.0 to 0.12.0 in /receiver/podmanreceiver Bump golang.org/x/net from 0.12.0 to 0.14.0 in /exporter/azuremonitorexporter Bump golang.org/x/net from 0.12.0 to 0.14.0 in /internal/aws/awsutil Bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 in /exporter/f5cloudexporter Bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 in /extension/oauth2clientauthextension Bump golang.org/x/sys from 0.10.0 to 0.11.0 in /exporter/signalfxexporter Bump golang.org/x/sys from 0.10.0 to 0.11.0 in /pkg/stanza Bump golang.org/x/sys from 0.10.0 to 0.11.0 in /pkg/winperfcounters Bump golang.org/x/sys from 0.10.0 to 0.11.0 in /receiver/hostmetricsreceiver Bump golang.org/x/sys from 0.10.0 to 0.11.0 in /receiver/windowseventlogreceiver Bump golang.org/x/text from 0.11.0 to 0.12.0 in /cmd/configschema Bump golang.org/x/text from 0.11.0 to 0.12.0 in /cmd/mdatagen Bump golang.org/x/text from 0.11.0 to 0.12.0 in /internal/coreinternal Bump golang.org/x/text from 0.11.0 to 0.12.0 in /pkg/stanza Bump golang.org/x/text from 0.11.0 to 0.12.0 in /testbed Bump golang.org/x/tools from 0.11.1 to 0.12.0 in /internal/tools Bump sigs.k8s.io/controller-runtime from 0.15.0 to 0.15.1 in /exporter/loadbalancingexporter --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [chore] preallocate slices (#24957) * [chore] dependabot updates Wed Aug 9 06:51:47 UTC 2023 (#25113) Bump github.com/hashicorp/golang-lru from 0.5.4 to 1.0.2 in /extension/observer/ecsobserver Bump github.com/hashicorp/golang-lru from 0.6.0 to 1.0.2 in /processor/spanmetricsprocessor Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.717 to 1.0.719 in /exporter/tencentcloudlogserviceexporter Bump google.golang.org/api from 0.134.0 to 0.136.0 in /receiver/googlecloudspannerreceiver * [exporter/clickhouse] Change the type of `Config.Password` to be `configopaque.String` (#24778) clickhouse exporter also needs use `Config.Password`. --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [chore] Add a new Test and refactor code function for collectdreceiver (#25120) **Description:** Add a new test 'testInvalidMethod' in receiver_test.go, and refactor code for readability. * [receiver/hostmetrics] Improve description of system.cpu.utilization metric (#25123) Replaces https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/25115 --------- Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com> Co-authored-by: Ryan Fitzpatrick <10867373+rmfitzpatrick@users.noreply.github.com> * [chore] [exporter/signalfx] Add few tests for histogram metrics (#25127) **Description:** [exporter/signalfx] Added few tests for histogram metrics on SFx exporter's converter piece **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25067 * [chore] [processor/transform] enable exhaustive lint (#25140) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [chore][exporter/clickhouse]enable exhaustive for linter (#25133) relate https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [chore][exporter/azuredataexplore]enable exhaustive linter (#25130) relate https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [chore] [dataset/exporter]: Fix flaky windows tests (#25143) **Description:** There is flaky Windows test **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25094 **Testing:** Before applying this change, it has failed in 1 test out of 60. So this should pass 200 tests without failure. * [chore][exporter/sumologic] enable exhaustive linter (#25159) relate: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [chore][exporter/skywalking] enable exhaustive linter (#25158) relate: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [chore][exporter/googlecloudpubsub] enable exhaustive linter (#25156) relate https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [exporter/awsemfexporter] Propagate RetainInitialValueOfDeltaMetric to translateOTelToGroupedMetric (#24051) **Description:** The config option `retain_initial_value_of_delta_metric` does not seem to be used in `translateOTelToGroupedMetric`, which prevents the initial value of a basic counter from being published during a Lambda cold boot. Please see the minimum project required to replicate the issue [here](https://github.com/jameshi16/delta-initial-value-minimum-project). **Link to tracking Issue:** The main issue related to this PR can be found [here](https://github.com/aws-observability/aws-otel-lambda/issues/634). It seems like I had a predecessor fixing this issue (see #17988), but his changes does not work for my use case. **Testing:** An additional test ensures that if `retain_initial_value_of_delta_metric` is set, it will be propagated to the `cWMetricMetadata`. **Documentation:** None * [chore][exporter/dynatrace] enable exhaustive linter (#25155) relate https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 * [chore] [CI] Exclude go version matrix from the unittest job (#25151) To not update required jobs every time a new go version is released. Needed for https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25116 * Bump filelog.allowHeaderMetadataParsing feature gate to beta (#25173) * [processor/k8sattributes] Add optional k8s.cluster.uid resource attribute (#23668) **Description:** Add k8s.cluster.uid to attribute to k8sattributes processor and disable it by default for backward compatibility. Users can set it to `true` to populate cluster uid as part of resource attributes. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/21974 * [chore] Upgrade koanf to v2 in the Supervisor (#25169) This is primarily to align the version with what the Collector uses in `confmap`. It doesn't introduce any functional changes. * Remove go 1.19 support, bump minimum to go 1.20 and add testing for 1.21 (#25162) Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25116 * [chore] [receiver/file] enable exhaustive lint (#25180) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [chore] [exporter/awskinesis] Migrate from deprecated kinesis.WithEndpointResolver (#25164) Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25104 * [chore] dependabot updates Sun Aug 13 19:41:07 UTC 2023 (#25182) Bump github.com/openzipkin/zipkin-go from 0.4.1 to 0.4.2 in /receiver/pulsarreceiver * [receiver/sqlquery] set ObservedTimestamp on collected logs (#23777) Fixes #23776 * [chore] [clickhouseexporter] use errors.Join instead of go.uber.org/multierr (#25183) Part of: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25121 * [chore] migrate all the files under connector to use errors.Join (#25184) Related to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25121 * Datadog Connector Component (#25065) This pull request is for a newly created Datadog connector that replaces the need for the Datadog processor. This replacement is needed because the processor made use of a work-around that directly allowed the processor to export data. This is not something that adheres to the OpenTelemetry standard and thus the previous system should be deprecated and replaced by this new connector. Link to issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/19740 --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [chore] Migrate all `aws` receviers to use errors.Join (#25185) Related to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25121 * [pkg/stanza] Create a new decoder for each TCP/UDP connection to prevent concurrent write to buffer. (#25100) Change the TCP/UDP inputs so that they parse the encoding and get the `encoding.Encoding` during initialization, but wait to create the `helper.Encoding` instance in each goroutine. This prevents concurrent calls to `Decode` using the same instance. Co-authored-by: Dan Jaglowski <jaglows3@gmail.com> * [extension/jaegerremotesampling] Support reload_interval option in remote mode of usage (#24981) Updates the jaegerremotesampling extension's `remote` mode of usage to support the `reload_interval` caching option already supported in `file` mode of usage. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * [translator/loki] Fixes a panic that occurred during the promotion of nested attributes containing dots to labels (#25142) When the value for loki hint attribute contains dots (more than 1 dot) and attributes are nested so some level contains dotted attribute name (for example `{"log": {"file.name": "foo"}}`), the getNestedAttribute function throws a panic Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [chore] [receiver/sqlquery] Fix flaky test TestLogsQueryReceiver_Collect (#25191) Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25189 * Prepare update to core v0.83.0 (#25187) Corresponds to [Step 3](https://github.com/open-telemetry/opentelemetry-collector/blob/81242fa7eff332756df6e03034c0e6686b9b988e/docs/release.md?plain=1#L34) of collector core release process. Updated as part of Step 8. --------- Signed-off-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Alex Boten <aboten@lightstep.com> * [chore] dependabot updates Mon Aug 14 23:07:29 UTC 2023 (#25810) Bump github.com/ClickHouse/clickhouse-go/v2 from 2.12.1 to 2.13.0 in /exporter/clickhouseexporter Bump github.com/antonmedv/expr from 1.12.5 to 1.13.0 in /receiver/receivercreator Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.322 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.322 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.322 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.322 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.322 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.319 to 1.44.323 in /receiver/awsxrayreceiver Bump github.com/daixiang0/gci from 0.10.1 to 0.11.0 in /internal/tools Bump github.com/golangci/golangci-lint from 1.53.3 to 1.54.1 in /internal/tools Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /extension/observer/dockerobserver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /internal/coreinternal Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/aerospikereceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/apachereceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/dockerstatsreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/elasticsearchreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/jmxreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/kafkametricsreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/nginxreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/postgresqlreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/redisreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/sqlqueryreceiver Bump github.com/testcontainers/testcontainers-go from 0.22.0 to 0.23.0 in /receiver/zookeeperreceiver Bump go.mongodb.org/atlas from 0.32.0 to 0.33.0 in /receiver/mongodbatlasreceiver Bump go.opentelemetry.io/collector from 0.82.0 to 0.83.0 in /pkg/stanza Bump go.opentelemetry.io/collector from 0.82.0 to 0.83.0 in /receiver/carbonreceiver Bump go.opentelemetry.io/collector/cmd/builder from 0.82.1-0.20230811173841-81242fa7eff3 to 0.83.0 in /internal/tools Bump go.opentelemetry.io/collector/component from 0.82.0 to 0.83.0 in /exporter/logzioexporter Bump go.opentelemetry.io/collector/config/confighttp from 0.82.0 to 0.83.0 in /receiver/elasticsearchreceiver Bump go.opentelemetry.io/collector/config/confighttp from 0.82.0 to 0.83.0 in /receiver/skywalkingreceiver Bump go.opentelemetry.io/collector/config/confignet from 0.82.0 to 0.83.0 in /extension/jaegerremotesampling Bump go.opentelemetry.io/collector/config/configopaque from 0.82.0 to 0.83.0 in /extension/jaegerremotesampling Bump go.opentelemetry.io/collector/config/configtls from 0.82.0 to 0.83.0 in /processor/resourcedetectionprocessor Bump go.opentelemetry.io/collector/config/configtls from 0.82.0 to 0.83.0 in /receiver/sapmreceiver Bump go.opentelemetry.io/collector/config/configtls from 0.82.0 to 0.83.0 in /receiver/signalfxreceiver Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /exporter/splunkhecexporter Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /processor/logstransformprocessor Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /receiver/awsfirehosereceiver Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /receiver/rabbitmqreceiver Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /receiver/saphanareceiver Bump go.opentelemetry.io/collector/confmap from 0.82.0 to 0.83.0 in /receiver/signalfxreceiver Bump go.opentelemetry.io/collector/consumer from 0.82.0 to 0.83.0 in /exporter/opencensusexporter Bump go.opentelemetry.io/collector/consumer from 0.82.0 to 0.83.0 in /processor/logstransformprocessor Bump go.opentelemetry.io/collector/consumer from 0.82.0 to 0.83.0 in /processor/resourcedetectionprocessor Bump go.opentelemetry.io/collector/consumer from 0.82.0 to 0.83.0 in /receiver/mysqlreceiver Bump go.opentelemetry.io/collector/consumer from 0.82.0 to 0.83.0 in /receiver/nsxtreceiver Bump go.opentelemetry.io/collector/processor from 0.82.0 to 0.83.0 in /exporter/datadogexporter Bump go.opentelemetry.io/collector/receiver from 0.82.0 to 0.83.0 in /receiver/dockerstatsreceiver Bump go.opentelemetry.io/collector/receiver from 0.82.0 to 0.83.0 in /receiver/googlecloudpubsubreceiver Bump go.opentelemetry.io/collector/semconv from 0.82.0 to 0.83.0 in /exporter/awsemfexporter Bump go.opentelemetry.io/collector/semconv from 0.82.0 to 0.83.0 in /receiver/hostmetricsreceiver * [chore] Prepare release 0.83.0 (#25819) The following commands were run to prepare this release: - make chlog-update VERSION=v0.83.0 - sed -i.bak s/0.82.0/0.83.0/g versions.yaml - make multimod-prerelease - make multimod-sync * [chore] Move a few entries between changelogs (#25822) Followup to the v0.83.0 release. The chloggen tool was recently upgraded to support multiple separate changelogs. While the tool worked correctly, several entries were added prior to the new feature being added, resulting in several entries going to the default (user) changelog rather than the api changelog. * [chore] [receiver/k8scluster] enable exhaustive lint (#25818) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [processor/k8sattributes] Move config validation into Validate (#25153) **Description:** Moves existing config validation into the Validate function **Testing:** Added more unit tests --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * Update otel/opentelemetry-collector-contrib Docker tag to v0.83.0 (#25826) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [otel/opentelemetry-collector-contrib](https://togithub.com/open-telemetry/opentelemetry-collector-releases) | minor | `0.82.0` -> `0.83.0` | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector-releases (otel/opentelemetry-collector-contrib)</summary> ### [`v0.83.0`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/releases/tag/v0.83.0) [Compare Source](https://togithub.com/open-telemetry/opentelemetry-collector-releases/compare/v0.82.0...v0.83.0) #### Changelog - [`66a5e00`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/66a5e00) Prep release v0.83.0 ([#​388](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/388)) - [`8eb6a21`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/8eb6a21) Bump github.com/goreleaser/goreleaser from 1.19.2 to 1.20.0 ([#​387](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/387)) - [`9157d9d`](https://togithub.com/open-telemetry/opentelemetry-collector-releases/commit/9157d9d) \[admin] Add criteria for distributions ([#​376](https://togithub.com/open-telemetry/opentelemetry-collector-releases/issues/376)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> * [chore] [cmd/mdatagen] Fix a comment in resource_test.go (#25827) Cutting it from https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24444 * [chore] [receiver/haproxy] Use generated pdata output in the test (#25824) Cutting it from https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24444 to reduce the change set * [chore][fileconsumer] Move splitter factory code into internal package (#25172) * [receiver/influxdb] Fix time precision parser (#24974) (#25791) Add precision=n and precision=u to line protocol endpoint handler. This explicitly matches the behavior of InfluxDB 1.11, and allows a certain [Java client](https://github.com/influxdata/influxdb-java/blob/master/src/main/java/org/influxdb/impl/TimeUtil.java#L63) to write to OpenTelemetry. Also adds precision=µ and precision=µs for more complete compatibility with github.com/influxdata/line-protocol . * [receiver/postgresql] Added postgresql.deadlocks metric. (#25792) **Description:** Added new metric -- `postgresql.deadlocks` -- number of deadlocks detected in a database. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25688 * [chore] [receiver/postgres] Remove custom metrics builder code (#25830) The code was introduced to migrate table and database datapoint attributes to resource attributes in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/12967. Migration was completed a long time ago. The custom code isn't needed anymore. This also fixed the documentation to match the emitted data and removes redundant testdata * [chore] update segment download timeout to 2 minutes across all builds (#25832) Fixes #25794 Fixes #21506 * [receiver/vcenter] Metric attributes for host and vm performance metrics (#25149) Adds 'object' data point attribute to several metrics which has undifferentiated data points * [chore] cache telemetrygen image to avoid test flakiness (#25825) Fixes #24223 * [chore] update rotation (#25841) @TylerHelmuth sponsored vendor component here: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24294 Signed-off-by: Alex Boten <aboten@lightstep.com> * [chore] make tests faster and close http responses (#24925) These changes only touch tests. * [cmd/telemetrygen] Add status code to cli argument (#24673) **Description:** Adding command line argument `--status-code` to `telemetrygen traces`, which accepts `(Unset,Error,Ok)` (case sensitive) or the enum equivalent of `(0,1,2)`. Running ```shell telemetrygen traces --otlp-insecure --traces 1 --status-code 1 ``` against a minimal local collector yields ```txt 2023-07-29T21:27:57.862+0100 info ResourceSpans #0 Resource SchemaURL: https://opentelemetry.io/schemas/1.4.0 Resource attributes: -> service.name: Str(telemetrygen) ScopeSpans #0 ScopeSpans SchemaURL: InstrumentationScope telemetrygen Span #0 Trace ID : f6dc4be32c78b9999c69d504a79e68c1 Parent ID : 4e2cd6e0e90cf2ea ID : 20835413e32d26a5 Name : okey-dokey Kind : Server Start time : 2023-07-29 20:27:57.861602 +0000 UTC End time : 2023-07-29 20:27:57.861726 +0000 UTC Status code : Error Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-client) Span #1 Trace ID : f6dc4be32c78b9999c69d504a79e68c1 Parent ID : ID : 4e2cd6e0e90cf2ea Name : lets-go Kind : Client Start time : 2023-07-29 20:27:57.861584 +0000 UTC End time : 2023-07-29 20:27:57.861726 +0000 UTC Status code : Error Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-server) ``` and similarly (the string version) ```shell telemetrygen traces --otlp-insecure --traces 1 --status-code '"Ok"' ``` produces ```txt Resource SchemaURL: https://opentelemetry.io/schemas/1.4.0 Resource attributes: -> service.name: Str(telemetrygen) ScopeSpans #0 ScopeSpans SchemaURL: InstrumentationScope telemetrygen Span #0 Trace ID : dfd830da170acfe567b12f87685d7917 Parent ID : 8e15b390dc6a1ccc ID : 165c300130532072 Name : okey-dokey Kind : Server Start time : 2023-07-29 20:29:16.026965 +0000 UTC End time : 2023-07-29 20:29:16.027089 +0000 UTC Status code : Ok Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-client) Span #1 Trace ID : dfd830da170acfe567b12f87685d7917 Parent ID : ID : 8e15b390dc6a1ccc Name : lets-go Kind : Client Start time : 2023-07-29 20:29:16.026956 +0000 UTC End time : 2023-07-29 20:29:16.027089 +0000 UTC Status code : Ok Status message : Attributes: -> net.peer.ip: Str(1.2.3.4) -> peer.service: Str(telemetrygen-server) ``` The default is `Unset` which is the current behaviour. **Link to tracking Issue:** 24286 **Testing:** Added unit tests which covers both valid and invalid inputs. **Documentation:** Command line arguments are self documenting via the usage info in the flag. Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [receiver/vcenter] Add resource attribute for resource pool inventory path (#25842) ix the issue where the integration test was emitting resource pools resources with the same identifiers. A resource pool generally isn't going to be named the same unless there is some nested structure and generally is believed to be a malpractice from my experience. The inventory path may be the best all around solution for adding context to where the metrics are coming from. * [chore][fileconsumer] Extract a readerMetadata struct (#25828) This PR continues the incremental refactoring of the fileconsumer package. I'd like to eventually move the reader struct into an internal package. Prior to doing so, I believe it will be helpful to simplify the struct's contents and usage. - Extract a readerMetadata struct from the reader struct. This contains exactly the fields which can be saved and reloaded. Consequently, saving and reloading will operator directly on the metadata, rather than the entire reader. - Simplify the readerFactory and readerBuilder by pulling some nuanced responsibilities out of the builder and into the factory's specialized functions. - Remove several builder options, which are now handled by factory. - Remove special case where fingerprint was initialized by builder. This was only used in tests. - Remove useless test which only validates that json encoder functionality. * [chore][golden] Normal timestamps in golden metric files (#23002) Normalized the timestamps on Golden file outputs. Normalization in this instance basically means setting non-unique timestamps of a metric equal to each other and unique timestamps incremented in increments of 1,000,000 nanoseconds. To see a clear example of this, navigate into the added test files (internal/coreinternal/golden/testdata/timestamp-norm) The goal is to further make the Golden output files as deterministic as possible and clear up the cluttered git diff's every time one of these golden files are remade. * [chore] update codeowners to respect capitalization (#25848) Update github logins to match capitalization. * [pkg/stanza] Deprecate EncodingConfig (#25846) * Revert "[chore] cache telemetrygen image to avoid test flakiness" (#25853) Reverts open-telemetry/opentelemetry-collector-contrib#25825 * [chore] do not ignore error when json marshaling (#24934) * [exporter/opensearch] Send traces to OpenSearch (#24540) Implementation of exporter to OpenSearch using opensearch-go library. Requests sent adhere to OpenSearch Catalog [schema for traces](https://github.com/opensearch-project/opensearch-catalog/tree/main/schema/observability/traces). # Testing ## Integration - Successful round-trip to HTTP endpoint, - Permanent error during round-trip, - Retryable error response for first request, followed by successful response on retry, - Two retriable error responses, followed by successful response on second retry. ## Manual end-to-end - Authenticating using basicauth extension, - Connecting to OpenSearch using TLS. ## Issues Found ### Rejected Attribute JSON In bdd41142467997c3261c5c991ddffd038fff43db, some values in `ptrace.Span.Attributes()` can be converted to JSON that OpenSearch Observability's ss4o index template rejects. The collector correctly logs these as dropped. Working with OpenSearch observability to find root cause. The fix will be localized to `sso_model.go` and `traceBulkIndexer.createJSON`. --------- Signed-off-by: Max Ksyunz <max.ksyunz@improving.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> * [chore] prealloc for internal/coreinternal (#24947) * [chore] Code linter findings for internal/aws (#24946) preallocate slices do not assign a boolean if it is reassigned right after * [chore] Add TylerHelmuth to k8s components codeowners (#25869) **Description:** I'd like to be more actively involved with the collector's k8s components. * [chore] [pkg/stanza] correct code comment (#25873) Corrects an inaccurate comment header on the FromPdataConverter type. **Description:** Small correction to a go comment that threw me for a loop. Thanks! **Link to tracking Issue:** NA **Testing:** NA **Documentation:** None Signed-off-by: Christian Kruse <ctkruse99@gmail.com> * [chore] rename error variable to match expected golang pattern (#24936) * [chore] preallocate slice (#24940) * [chore] preallocate slices throughout the observer extension (#24943) * [chore] [exporter/alibabacloudlogservice] enable exhaustive lint (#25877) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * Deprecating The Datadog Processor (#25437) The Datadog Processor is deprecated in favor of the Datadog Connector Link to issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/19740 --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Alex Boten <aboten@lightstep.com> * [receiver/kubeletstats] Add uptime metric for nodes, pods, and containers (#25867) **Description:** Adds a new monotonic, cumulative sum metric for tracking uptime of nodes, pods, and containers. Uptime is calculated as the number of seconds since the object's `StartTime`. **Testing:** Updated unit tests. Tested locally using the otel demo * [chore][receiver/httpcheck] fix configuration docs (#25881) Replaces `endpoint` with `targets` in README as changed in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/23439. * [chore] Add to TylerHelmuth as codeowner for kubeletstats receiver (#25891) * [chore][exporter/azuremonitor]enable exhaustive for linter (#25131) related to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23266 Co-authored-by: Alex Boten <aboten@lightstep.com> * [cmd/telemetrygen] fix status-code args default value (#25889) Fix #25849 after adding more logs for failed telemetrygen pod, I found traces-job keeps failing with the error log ``` Error: expected `status-code` to be one of (Unset, Error, Ok) or (0, 1, 2), got "Unset" instead ``` here is a failed run https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/5899236967/job/16005926116 I thinks this bug is brought in by the pr #24673 , the default value `Unset` for arg `status-code` is not a legal one, the legal one is `"Unset"` --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [chore] Remove unused BUILD_INFO from Makefile (#25823) This PR removes unused `BUILD_INFO` from Makefile which was originally deleted in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16828. As far as I checked briefly, the file itself was already deleted, and no one uses it now. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/11867 **Testing:** ```shell-session $ make otelcontribcol cd ./cmd/otelcontribcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/otelcontribcol_darwin_arm64 \ -tags "" . $ ./bin/otelcontribcol_darwin_arm64 -v otelcontribcol version 0.83.0-dev ``` Signed-off-by: Kotaro Inoue <k.musaino@gmail.com> * [exporter/azuremonitor] Log exporter handle non-string values (#24911) The log exporter was incorrectly assuming a string value for the body. Minor refactoring of the log exporter unit tests for better isolation. Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23422 **Testing:** Unit tests --------- Co-authored-by: Alex Boten <aboten@lightstep.com> * [receiver/haproxy] add support for http (#24560) Support HTTP endpoints as well for haproxy receiver. * [exporter/signalfx] Option to drop histogram buckets. part-1 (#25893) **Description:** : Added a mechanism to drop histogram buckets from the signalfx translator. Please note this will be used in upcoming second part of the "histogram bucket drop" effort for the same issue. **Link to tracking Issue:** #25845 * [receiver/redis] Add username parameter for connecting to redis (#24408) **Description:** Adding a feature - Adding username for redis receiver for connecting to redis over ACL **Testing:** Running go test is ok. Generating my custom OpenTelemetry Collector binary with redis receiver and otlp exporter (using ocb). This custom Opentelemetry Collector collecting redis data by connecting with a username and password work fine. I test to collect data using password only, it works too. **Documentation:** Mardown file has been updated * [receiver/journald]: add support for dmesg (#25910) Adds support for `--dmesg` to journaldreceiver * [chore] [connector/datadog] add status table to readme (#25903) For consistency with other components. Signed-off-by: Alex Boten <aboten@lightstep.com> * [exporter/opensearch] ensure readme is generated (#25899) This will ensure consistency w/ the other components in the repo. Signed-off-by: Alex Boten <aboten@lightstep.com> * [receiver/journald]: add support for identifiers (#25911) Adds support for `identifiers` to journaldreceiver * [pkg/ottl] use IntGetter argument for Substring function (#25874) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> use IntGetter argument for Substring function **Link to tracking Issue:** <Issue number if applicable> #25852 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [internal/filter] enable exhaustive lint (#25908) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [internal/coreinternal] enable exhaustive lint (#25907) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [exporter/clickhouse] Change writing of metrics data to batch (#24403) **Description:** <Describe what has changed.> The clickhouseexporter using a StringBuilder to build a big sql string while writing metrics. This will be causing the queue to full when metric data is big. Changes: valueArgs := make([]any, e.count*expHistogramValueCounts) var b strings.Builder index := 0 for _, model := range e.expHistogramModels { for i := 0; i < model.expHistogram.DataPoints().Len(); i++ { dp := model.expHistogram.DataPoints().At(i) b.WriteString(*expHistogramPlaceholders) valueArgs[index] = model.metadata.ResAttr valueArgs[index+1] = model.metadata.ResURL ..... valueArgs[index+28] = dp.Max() index += expHistogramValueCounts } } start := time.Now() err := doWithTx(ctx, db, func(tx *sql.Tx) error { _, err := tx.ExecContext(ctx, fmt.Sprintf("%s %s", e.insertSQL, strings.TrimSuffix(b.String(), ",")), valueArgs...) return err }) TO: start := time.Now() err := doWithTx(ctx, db, func(tx *sql.Tx) error { batch, err := tx.PrepareContext(ctx, e.insertSQL) if err != nil { return err } batch: for _, model := range e.expHistogramModels { for i := 0; i < model.expHistogram.DataPoints().Len(); i++ { dp := model.expHistogram.DataPoints().At(i) attrs, times, values, traceIDs, spanIDs := convertExemplars(dp.Exemplars()) _, err = batch.ExecContext(ctx, model.metadata.ResAttr, model.metadata.ResURL, model.metadata.ScopeInstr.Name(), model.metadata.ScopeInstr.Version(), attributesToMap(model.metadata.ScopeInstr.Attributes()), model.metadata.ScopeInstr.DroppedAttributesCount(), model.metadata.ScopeURL, model.metricName, model.metricDescription, model.metricUnit, attributesToMap(dp.Attributes()), dp.StartTimestamp().AsTime(), dp.Timestamp().AsTime(), dp.Count(), dp.Sum(), dp.Scale(), dp.ZeroCount(), dp.Positive().Offset(), convertSliceToArraySet(dp.Positive().BucketCounts().AsRaw()), dp.Negative().Offset(), convertSliceToArraySet(dp.Negative().BucketCounts().AsRaw()), attrs, times, values, traceIDs, spanIDs, uint32(dp.Flags()), dp.Min(), dp.Max(), ) if err != nil { break batch } } } return err }) --------- Co-authored-by: Murphy Chen <minquan.chen@daocloud.io> * [pkg/ottl] Add new `ExtractPatterns` converter that extract regex patterns from string (#25878) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> [pkg/ottl] Add new `ExtractPatterns` converter that extract regex pattern from string **Link to tracking Issue:** <Issue number if applicable> #25834, #25856 **Testing:** <Describe what testing was performed and which tests were added.> Unit tests **Documentation:** <Describe the documentation added.> Added documentation to pkg/ottl/ottlfuncs/README.md. --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [chore][fileconsumer] Remove readerBuilder and simplify reader instantiation (#25847) Followup to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/25828 - Remove the `readerBuilder` entirely and instead works with clearer `readerFactory` methods. - Fixes test setup in `otlpjsonfilereceiver`, which was previous relying on a force flush event. This was exposed as part of this refactoring. * [chore][fileconsumer] Cleanup file handle when closed by reader (#25912) This PR is a small step towards reducing complexity in the way we manage readers and their files. With this change we now have an expectation that reader file handles are always open. * [fileconsumer] Remove deprecated structs (#25916) * Revert "[chore][fileconsumer] Cleanup file handle when closed by reader" (#26021) Reverts open-telemetry/opentelemetry-collector-contrib#25912 This change appears to have caused special behaviors on windows. * Remove retry_on_failure from the googlecloud exporters (#25900) **Description:** In https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/19203, we disabled retry_on_failure by default because retry is now handled by the google cloud client libraries. However, many users still enable it because the error message encourages users to enable retry_on_failure. This is causing problems, especially with metrics because retrying a batch of metrics produces confusing errors (like out-of-order or duplicate timeseries errors) and spams users logs more than necessary. This PR removes the retry_on_failure config from the GMP and googlecloud exporters. * [pkg/translator/loki] Added Attributes support to the InstrumentationScope (#25883) **Description:** <Describe what has changed.> Added Attributes support to InstrumentationScope Now the attributes information in the `pcommon.InstrumentationScope` structure is translated and transmitted to Loki. **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/24027 **Testing:** Added unit tests * [extension/healthcheck] remove dependency on jaeger package (#25895) This extension was pulling in a dependency on jaeger for a fairly small amount of code. I've copied the code into an internal package instead to remove the dep. --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * Fix replace_all_patterns attributes for transform readme (#26032) In the transform processor readme, there's still one instance of the replace_all_patterns without the mode parameter. This PR fixed that. Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [pkg/stanza] Move encoding concerns to dedicated package (#26019) * Remove defunct elastic_output reference from operator README (#26034) **Description:** The operators README file still included a reference to the `elastic_output` which was removed a while back in favor of the `elasticsearchexporter`. This PR replaces the example with a file_output example, which still exists. * Translate unit from words to UCUM in the prometheus receiver (#25887) Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/23208 This is the reverse of the logic in the prometheus exporter, which changes UCUM to words. * [chore][fileconsumer] Fix bug where flush period would be forgotten (#26033) Adds a test for and fixes a bug introduced in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/25847 No changelog is necessary because the bug was introduced yesterday and was never released. * [chore][fileconsumer] Extract splitter, flusher, multiline, encoding into dedicated package (#25914) ~~Follows #26019~~ There are several structs in `pkg/stanza/operator/helper` which define and manage tokenization related behaviors. `fileconsumer` has a dependency on these, as do a few other components such as tcp and udp receivers. These structs have complex interrelationships which I find difficult to reason about and difficult to manage. Their current location in the `helpers` package is unhelpful and unnecessary. I'd like to move them into a dedicated package where I can start to untangle and hopefully simplify them. * [chore] [exporter/coralogix] Document and test attributes ordering (#26027) **Description:** We were seeing reports of cases where unexpected attribute has been picked up as subsytem / application attribute. This PR adds some clarifications on how the attribute is picked. Also adds tests to validate this behavior. **Link to tracking Issue:** N/A **Testing:** N/A **Documentation:** Added documentation regarding attributes ordering. --------- Signed-off-by: Matej Gera <matejgera@gmail.com> * [chore][pkg/stanza] Move tokenization tests into tokenizetest package (#25997) * [chore] Remove non-ucum units from prometheus readme (#26035) Follow-up to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24647 Addresses comment in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/25887#pullrequestreview-1588092792 * [chore] dependabot updates Tue Aug 22 20:28:42 UTC 2023 (#26039) Bump cloud.google.com/go/spanner from 1.47.0 to 1.48.0 in /receiver/googlecloudspannerreceiver Bump github.com/ClickHouse/clickhouse-go/v2 from 2.13.0 to 2.13.2 in /exporter/clickhouseexporter Bump github.com/aliyun/aliyun-log-go-sdk from 0.1.51 to 0.1.53 in /exporter/alibabacloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.327 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.44.323 to 1.44.328 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go-v2 from 1.20.1 to 1.20.3 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2 from 1.20.1 to 1.21.0 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/config from 1.18.33 to 1.18.35 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/config from 1.18.33 to 1.18.36 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.32 to 1.13.34 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.32 to 1.13.35 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.18.2 to 1.18.5 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.21.2 to 1.21.4 in /extension/sigv4authextension Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /cmd/configschema Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /exporter/awscloudwatchlogsexporter Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /exporter/awsemfexporter Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /exporter/googlecloudpubsubexporter Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /exporter/tanzuobservabilityexporter Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /pkg/ottl Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /processor/k8sattributesprocessor Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /processor/tailsamplingprocessor Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /receiver/awsxrayreceiver Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /receiver/k8sclusterreceiver Bump github.com/google/uuid from 1.3.0 to 1.3.1 in /receiver/skywalkingreceiver Bump github.com/mongodb-forks/digest from 1.0.4 to 1.0.5 in /receiver/mongodbatlasreceiver Bump github.com/sijms/go-ora/v2 from 2.7.11 to 2.7.14 in /receiver/sqlqueryreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.719 to 1.0.727 in /exporter/tencentcloudlogserviceexporter Bump go.opentelemetry.io/collector/receiver from 0.82.0 to 0.83.0 in /receiver/googlecloudpubsubreceiver Bump golang.org/x/vuln from 1.0.0 to 1.0.1 in /internal/tools Bump gonum.org/v1/gonum from 0.13.0 to 0.14.0 in /pkg/stanza Bump gonum.org/v1/gonum from 0.13.0 to 0.14.0 in /receiver/statsdreceiver Bump google.golang.org/api from 0.136.0 to 0.138.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.136.0 to 0.138.0 in /exporter/googlecloudpubsubexporter Bump google.golang.org/api from 0.136.0 to 0.138.0 in /receiver/googlecloudpubsubreceiver Bump google.golang.org/api from 0.136.0 to 0.138.0 in /receiver/googlecloudspannerreceiver * [chore] [processor/transform] Add the missing parenthesis in the README example (#26066) One parenthesis is missing in "Comnbine two attributes" example code. * [exporter/loadbalancingexporter] fix k8s service resolver retaining invalid old endpoints (#25061) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> fix k8s service resolver retaining invalid old endpoints In the endpoint update event, the step of deleting the old endpoint is missed, so a connection request will still be made to the old endpoint. **Link to tracking Issue:** <Issue number if applicable> #24914 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Signed-off-by: Yuan Fang <yuanfang@alauda.io> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [chore] dependabot updates Wed Aug 23 04:31:08 UTC 2023 (#26067) Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.44.328 to 1.44.329 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go-v2/config from 1.18.33 to 1.18.36 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/config from 1.18.35 to 1.18.36 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.32 to 1.13.35 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.34 to 1.13.35 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.21.4 to 1.21.5 in /extension/sigv4authextension Bump github.com/sijms/go-ora/v2 from 2.7.14 to 2.7.15 in /receiver/sqlqueryreceiver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.727 to 1.0.728 in /exporter/tencentcloudlogserviceexporter Bump go.opentelemetry.io/collector/receiver from 0.82.0 to 0.83.0 in /receiver/googlecloudpubsubreceiver * fix e2e telemetrygen pod to enable e2e-test action (#25905) **Description:** before #25889 is released, the telemetrygen image is still not the latest one, so we need to fix e2e telemetrygen pod yaml to enable e2e-test action again. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * Add support for Metrics Slices to ottl len converter (#25890) Fixes #25868 **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> * Allow log's body to be set in telemetrygen (#26069) This change adds a flag allowing users to set the log's body. It also sets a log body to a default message. Replaces #26031 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * [exporter/tanzuobservability] Deprecate Tanzu Observability (Wavefront) Exporter (#25904) The Tanzu Observability (Wavefront) Proxy has support for ingesting traces and metrics via OTLP, so the vendor specific exporter is no longer needed. This PR adds a deprecation message. **Link to tracking Issue:** #24225 **Documentation:** Readme updated with deprecation notice and link to migration documentation. * [chore] dependabot updates Wed Aug 23 16:09:23 UTC 2023 (#26077) Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.728 to 1.0.729 in /exporter/tencentcloudlogserviceexporter * receiver_creator: update expr with breaking type fn (#26064) Fixing a bug - These changes adopt the latest version of expr and incorporate a breaking built-in `type` function addition by relocating its implementation to `typeOf`. Fixes #26038 * [chore] Update lb exporter and k8sattributes processor with aws distro (#26079) **Description:** ADOT Collector now includes load balancing exporter and k8s attributes processor. This PR Updates medata.yaml and the components associated readme. * [pkg/resourcetotelemetry] enable exhaustive lint (#26075) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * [chore] enforce validation of codeowners membership (#24638) **Description:** This adds a validation to our codeowners by forcing us to review and manage the codeowners registered with the OpenTelemetry github organization. * [chore] Check component API (#25855) **Description:** Introduce an API checker ensuring components only define a function per component to expose the factory function NewFactory **Testing:** Run locally, run as part of CI * [chore] only check for codeowners on main branch (#26088) Restrict when this step is run to make sure the secret GITHUB_TOKEN is set. * [receiver/memcached] remove duplicate Timeout setting (#26084) Use the Timeout setting from ScraperHelper instead --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * [receiver/k8sobjects] Switch to current config testing pattern (#26078) **Description:** Updates the component to use the latest config testing patterns. * [pkg/translator/loki] Moved labels names normalization to LogToLokiEntry function (#26093) **Description:** <Describe what has changed.> The public method `LogToLokiEntry` should return normalized label names to release developers who use it from the necessity to normalize them in their code **Testing:** adjusted unit tests of lokitranslator * feat: allow custom port for cassandra connection (#25179) * Add JMX metrics gatherer version 1.29.0-alpha (#26089) Add JMX metrics gatherer version `1.29.0-alpha`. cc @open-telemetry/java-contrib-approvers * [chore] fix exhaustive lint for processor groupbyattrs (#24919) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com> * [exporter/awsxray] Feature Gate to Allow fully random Trace IDs in XRay Exporter (#26041) Currently, the AWS XRay Exporter will drop segments/traces with trace IDs where the first 32 bits, when converted to UNIX Epoch time, are not within the past 28 days. This change is to add an Alpha feature gate `exporter.awsxray.skiptimestampvalidation`, which is disabled by default. If enabled, the timestamp restriction is removed so that users do not need to use the AWS XRay ID Generator. - Updated unit test in `config_test.go` - Added unit tests in `factory_test.go` and `segment_test.go` - All other unit tests related to trace ID are passing. * added a new postgresql metric. (#26086) Added new metric `postgresql.time_files` which is number of temp files detected in a database. Fixes #26080 * [receiver/zookeeper] remove duplicate Timeout field (#26082) Rely on the scraper helper's Timeout instead --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * [chore] [exporter/datasetexporter]: Update dataset-go to 0.14.0 (#26094) Upgrade dataset-go from 0.12.1 to 0.14.0 Next release is happening on 2023-08-28 (Monday) - https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md - but next dependant is running on 2023-08-31 (Wednesday) - https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/.github/dependabot.yml - so it will not get updated on time. * [receiver/azuremonitorreceiver] Added new attributes for metrics (#24774) Added new attributes: name, type and resource group to the metrics * [chore] Add bryan-aguilar as EMF Exporter codeowner (#26100) **Description:** Adding myself as a codeowner of AWS EMF Exporter * [chore] add cmd group target and use it for testing and lint (#25876) Fixes #25875 * Parse scope information from otel_scope_name, otel_scope_version, and otel_scope_info (#25898) **Description:** Implements this specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/prometheus_and_openmetrics.md#instrumentation-scope, with https://github.com/open-telemetry/opentelemetry-specification/pull/3660 Instrumentation Scope > Each otel_scope_info metric point present in a batch of metrics SHOULD be dropped from the incoming scrape, and converted to an instrumentation scope. The otel_scope_name and otel_scope_version labels, if present, MUST be converted to the Name and Version of the Instrumentation Scope. Additional labels MUST be added as scope attributes, with keys and values unaltered. Other metrics in the batch which have otel_scope_name and otel_scope_version labels that match an instrumentation scope MUST be placed within the matching instrumentation scope, and MUST remove those labels. > Metrics which are not found to be associated with an instrumentation scope MUST all be placed within an empty instrumentation scope, and MUST not have any labels removed. It does this by: * For all metrics, use `otel_scope_name` and `otel_scope_version` to set the scope name and version. * For `otel_scope_info` metrics, use `otel_scope_name` and `otel_scope_version` as the scope name and version, and all other labels (other than `job`/`instance`/`__name__`) as scope attributes. * Change `map[metricName]metricFamily` to `map[scope][metricName]metricFamily` to sort metrics by instrumentation scope as they come in, and to make writing the scope easier on commit. **Link to tracking Issue:** Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25870 * [receiver/jaeger] Removing remote sampling configuration code (#24186) Most remote sampling code is already removed from the jaeger receiver via #6633, but the configuration is still there. It is unused and should be removed. The only reason I can think of for retaining it is so that old configuration files don't stop the Collector from running. However, given that this is a no-op, I think it would be better to have an error and let the customers reconfigure their collectors. Here, I'm assuming that configuring a struct which doesn't exist will indeed raise an error. There is no changelog entry since the change is mostly an implementation detail. --------- Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * [pkg/pdatatest] enable exhaustive lint (#26105) **Description:** related #23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * feat: add duration to int float converters (#25069) Description: Allows conversion of durations to nanoseconds, microseconds, milliseconds, seconds, minutes or hours Link to tracking Issue: Related to #24686 Testing: Unit tests for each converter Documentation: --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelm…
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…elemetry#28884) **Description:** Logging was broken after open-telemetry#25900 (released in v0.84.0). It is fixed by open-telemetry/opentelemetry-collector#8792, which will be released in v0.89.0. This will help with any distributions that include the googlecloud exporter components.
mackjmr
added a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Nov 13, 2023
* [receiver/collectd] Move to use HTTPServerSettings with collectdreceiver (open-telemetry#28812) **Description:** Overhauls collectdreceiver to use the latest config helper features **Link to tracking Issue:** Fixes open-telemetry#28811 **Documentation:** No impact to docs. User interface remains the same. Separate changelog to notice API breaking changes, as the Config struct is changing. --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [chore][exporter/datadog] Re-enable TestTraceExporter (open-telemetry#28827) Re-enable TestTraceExporter. Fixes open-telemetry#27630 Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [chore][receiver/hostmetrics] Skip process user error (un)muted test on non-Linux (open-telemetry#28829) **Description:** Fix open-telemetry#28828 - this is just disabling the test on non-Linux. The broken test was introduced via open-telemetry#28661. * [receiver/hostmetricsreceiver] Add support for cpu frequency metric (open-telemetry#27445) **Description:** : Added support for host's cpu frequency as part of the hostmetricsreceiver. **Link to tracking Issue:** open-telemetry#26532 **Testing:** 1. Using the following configuration: ```yml receivers: hostmetrics: collection_interval: 5s scrapers: cpu: metrics: system.cpu.frequency: enabled: true processors: resourcedetection/system: detectors: ["system"] system: hostname_sources: ["lookup", "cname", "dns", "os"] resource_attributes: host.name: enabled: true host.id: enabled: true host.cpu.cache.l2.size: enabled: true host.cpu.family: enabled: true host.cpu.model.id: enabled: true host.cpu.model.name: enabled: true host.cpu.stepping: enabled: true host.cpu.vendor.id: enabled: true service: pipelines: metrics: receivers: [hostmetrics] exporters: [file] processors: [resourcedetection/system] exporters: file: path: ./output.json ``` 2. Start the collector with ./bin/otelcontribcol_linux_amd64 --config examples/host_config.yaml 3. The output reports the added metric successfully: ```json { "resourceMetrics":[ { "scopeMetrics":[ { "scope":{ "name":"otelcol/hostmetricsreceiver/cpu", "version":"0.85.0-dev" }, "metrics":[ { "name":"system.cpu.frequency", "description":"Current frequency of the CPU core in MHz.", "unit":"MHz", "gauge":{ "dataPoints":[ { "attributes":[ { "key":"cpu", "value":{ "stringValue":"cpu0" } } ], "startTimeUnixNano":"1696487580000000000", "timeUnixNano":"1696512423758783158", "asDouble":3000 }, { "attributes":[ { "key":"cpu", "value":{ "stringValue":"cpu1" } } ], "startTimeUnixNano":"1696487580000000000", "timeUnixNano":"1696512423758783158", "asDouble":3000 }, ... ``` Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * [encoding/zipkinencodingextension] add default case (open-telemetry#28689) **Description:** Fix bug when err is nil if an invalid version value is supplied. **Link to tracking Issue:** open-telemetry#28686 --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * [chore] Upgrade cloud.google.com/go (open-telemetry#28840) To resolve failing build-and-test/checks CI job **Link to tracking Issue:** open-telemetry#28839 * [connector/exceptions] Add trace id and span id to generated logs (open-telemetry#28670) **Description:** <Describe what has changed.> The current implementation generates logs from recorded exceptions in spans, but is not possible to see which traces and spans generated those logs. This PR adds that information to the logs **Link to tracking Issue:** Fixes open-telemetry#24407 * [chore][exporter/loadbalancing] use headless service with DNS mode in K8S(open-telemetry#27014) (open-telemetry#28687) **Description:** <Describe what has changed.> fix open-telemetry#27014 notice when in K8S, the DNS mode should config a headless service **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27014 * Update README.md (open-telemetry#28844) The Prometheus Remote write exporter is missing the details of default values for the remote write queue config. Added the values after looking into the code for the same. * exporter/datadog: disable APM stats via feature flag (open-telemetry#28616) This change adds the "exporter.datadogexporter.disable_apm_stats" feature flag, which can be enabled to disable APM stats computation. Updates open-telemetry#28615 * [receiver/zipkin] follow receiver contract (open-telemetry#28627) I came across `zipkinreceiver` and observed we don't follow the receiver [contract](https://github.com/open-telemetry/opentelemetry-collector/blob/b2961b799e2c1ec128f0539764af1fa10c839e04/receiver/doc.go#L21). We return `InternalServerError` straight away without checking permanent/non-permanent errors. We should probably return BadRequest in case of permanent errors open-telemetry/opentelemetry-collector#4335 **Testing:** Added test cases Co-authored-by: Andrzej Stencel <astencel@sumologic.com> * [chore][exporter/sumologicexporter] use errors.Join instead of go.uber.org/multierr (open-telemetry#28614) **Description:** use errors.Join instead of go.uber.org/multierr **Link to tracking Issue:** open-telemetry#25121 --------- Co-authored-by: Andrzej Stencel <astencel@sumologic.com> * [receiver/wavefront] wrap metrics receiver under carbon receiver instead of using export function (open-telemetry#27259) **Description:** Wavefrontreceiver is very similar to carbonreceiver: it is TCP based in which each received text line represents a single metric data point. In order to avoid using exported function `carbonreceiver.New(...)`, we can wrap metrics receiver under carbon receiver. **Link to tracking Issue:** open-telemetry#27248 **Testing:** make chlog-validate go test for wavefrontreceiver **Documentation:** --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [processor/k8sattributes] Fix node/ns labels/annotations extraction (open-telemetry#28838) Set attributes from namespace/node labels or annotations even if `k8s.namespace.name` and `k8s.node.name` are not extracted. Fixes open-telemetry#28837 * [processor/remoteobserver] rename to remotetapprocessor (open-telemetry#27874) **Description:** Rename remoteobserverprocessor to remotetapprocessor **Link to tracking Issue:** Fixes open-telemetry#27873 * [Spanmetrics] - Add exemplars to Sum metrics (open-telemetry#28671) **Description:** We don't have exemplars added to Sum metrics right now. This PR provides an enhancement to add exemplars to Sum metrics in Spanmetrics connector **Testing:** Added unit tests and also tested it in our local environment. * [chore] fix codeowners (open-telemetry#28855) Regenerate codeowners with `make gengithub` * feat(alertmanager): Add exporter factory and config (open-telemetry#27836) **Description:** Factory implementation of Alertmanager Exporter Initial PR - base configs and factory implementation **Link to tracking Issue:** [open-telemetry#23659](open-telemetry#23569) **Testing:** Unit tests for config and factory implementation **Documentation:** Readme and Sample Configs to use Alertmanager exporter --------- Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Adds duration sampler distinct from latency in supplying two bounds (open-telemetry#26115) **Description:** Adds a bounded duration sampling processor, distinct from the existing latency one in that it has both lower and upper bounds Apologies for this appearing as a pull request out of nothing, my intent had actually been to create a review area against my own fork and raise an issue asking if you'd accept the PR. I think the need here is pretty obvious from the context, though I think it's easy to imagine preferring this to be a change to the existing processor. I raised as a new one as I thought it might make existing behavior cleaner to retain. **Link to tracking Issue:** As above this is a bit of a premature PR since I intended to raise as an issue, and thus there isn't one, but I think it's easy enough to deal with here so leaving open for now and have learned GitHub's ways for the future (I rarely use github). **Testing:** New module so associated tests are added showing all relevant behavior, and passing. **Documentation:** Updated README and example config --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [googlemanagedprometheusexporter] Clarify support status of this exporter (open-telemetry#28863) * Link to related GCP docs * Clarify mention of "traces" * Drop mention of PromQL support as a difference from `googlecloud` exporter * [filelogreceiver]: Add ability to sort by mtime (open-telemetry#28850) **Description:** <Describe what has changed.> * Adds a new `mtime` sort type, which will sort files by their modified time * Add a feature gate for `mtime` sort type An optional follow-up performance improvement may be made here, to have the finder return fs.DirEntry directly to query the mtime without making an extra call to os.Stat for each file. **Link to tracking Issue:** open-telemetry#27812 **Testing:** * Added unit tests for new functionality **Documentation:** * Added new `mode` parameter to filelogreceiver docs * [pkg/traslator] move skywalking_to_traces into pkg/translator (open-telemetry#28814) **Description:** A part of open-telemetry#28693 <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> move`skywalking_to_traces` in `skywalkingreceiver` into `pkg/translator/skywalking` **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <jian.tan@daocloud.io> * [chore][pkg/stanza] Adjust length of knownFiles based on number of matches (open-telemetry#28646) Follows open-telemetry#28493 This adjusts the length of `knownFiles` to be roughly 4x the number of matches per poll cycle. In other words, we will remember files for up to 4 poll cycles. Resolves open-telemetry#28567 * [chore][exporter/datadog] Add a section about how to switch to Zorkian (open-telemetry#28836) **Description:** Update README about disabling the feature gate of native metric client and falling back to Zorkian client. --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> * [cmd/telemetrygen] Use exporter per worker for better metrics throughput (open-telemetry#27201) Adding a feature - Use exporter per worker for better metrics throughput Initially when adding more workers in the telemetrygen config when running "metrics" it did not increase the metrics throughput since all workers used the same exporter. By creating one exporter per worker we can now increase the number of metrics being send to the backend. Fixes open-telemetry#26709 - Units tests pass - Ran local load tests with different configurations ## Before code change Generate metrics: ``` telemetrygen metrics \ --metric-type Sum \ --duration "60s" \ --rate "0" \ --workers "10" \ --otlp-http=false \ --otlp-endpoint <HOSTNAME> \ --otlp-attributes "service.name"=\"telemetrygen\" ``` Output: ``` metrics generated {"worker": 8, "metrics": 139} metrics generated {"worker": 0, "metrics": 139} metrics generated {"worker": 9, "metrics": 141} metrics generated {"worker": 4, "metrics": 140} metrics generated {"worker": 2, "metrics": 140} metrics generated {"worker": 3, "metrics": 140} metrics generated {"worker": 7, "metrics": 140} metrics generated {"worker": 5, "metrics": 140} metrics generated {"worker": 1, "metrics": 140} metrics generated {"worker": 6, "metrics": 140} ``` ## After code change ``` telemetrygen metrics \ --metric-type Sum \ --duration "60s" \ --rate "0" \ --workers "10" \ --otlp-http=false \ --otlp-endpoint <HOSTNAME> \ --otlp-attributes "service.name"=\"telemetrygen\" ``` Output: ``` metrics generated {"worker": 6, "metrics": 1292} metrics generated {"worker": 3, "metrics": 1277} metrics generated {"worker": 5, "metrics": 1272} metrics generated {"worker": 8, "metrics": 1251} metrics generated {"worker": 9, "metrics": 1241} metrics generated {"worker": 4, "metrics": 1227} metrics generated {"worker": 0, "metrics": 1212} metrics generated {"worker": 2, "metrics": 1201} metrics generated {"worker": 1, "metrics": 1333} metrics generated {"worker": 7, "metrics": 1363} ``` By adding more workers you can now export more metrics and use `telemetrygen` better for load testing use cases. With the code change I can now utilize my CPU better for load tests. When adding 200 workers to the above config the CPU usage can go above 80%. Before that CPU usage would be around 1% with 200 workers. ![image](https://github.com/open-telemetry/opentelemetry-collector-contrib/assets/558256/66727e5f-6b0a-44a3-8436-7e6985d6a01c) --------- Co-authored-by: Alex Boten <aboten@lightstep.com> * [scraper/processscraper] Fix TestScrapeMetrics_MuteErrorFlags failures on windows and darwin (open-telemetry#28864) **Description:** There were some issues related to how `mock.On` works. With default mock and addition `On` which is already present it appends to a list and won't be called as one instance of a method is already there. So some expectations regarding return values were not met Metrics count for darwin is 3 because disk io is disabled [here](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/f509060a8d1ab5ca4b5827e0c60d1149e3059908/receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go#L315) Tested locally on mac, windows 11 and ubuntu 22 **Link to tracking Issue:** open-telemetry#28828 * [chore][testbed] Do not use export function `carbonreceiver.New` (open-telemetry#28858) **Description:** Do not use export function `carbonreceiver.New` and replace with `factory.CreateMetricsReceiver`, then we can chore carbonreceiver to make it pass checkapi tool. **Link to tracking Issue:** open-telemetry#28857 * [chore] Run make gendependabot (open-telemetry#28868) To fix failing `build-and-test / checks` CI job * [chore] update codeowners (open-telemetry#28869) Run `make gengithub` locally. * [receiver/sshcheck] Change keyfile -> key_file in e.g. config and docs (open-telemetry#28834) `keyfile` was the key used in config and documented in sshcheck, but `key_file` is the preferred key for these purposes. **Link to tracking Issue:** open-telemetry#27035 **Testing:** Update tests to ensure this key is used in default. **Documentation:** Updated documentation to reflect the change in key. * [chore] [extension/jaegerremotesampling] Avoid port conflict in tests (open-telemetry#28874) Fixes open-telemetry#28873 * [exporter/azuremonitor] Add Connection String Support to Azure Monitor Exporter (open-telemetry#28854) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This pull request introduces the ability to configure the Azure Monitor Exporter using a connection string, aligning the exporter configuration with Azure Monitor's recommended practices. The current implementation requires users to set the instrumentation key directly, which will soon be deprecated in favor of using the connection string. **Changes Made:** 1. Configuration Update: Modified the `Config` struct and related configuration parsing logic to support a `ConnectionString` field. 2. Parsing Logic: Implemented functionality to parse the connection string and extract necessary details, such as `InstrumentationKey` and `IngestionEndpoint`. 3. Updated Tests: Revised existing tests and added new ones to ensure coverage of the new configuration option. **Benefits:** * Streamlines the configuration process for end-users. * Aligns with Azure Monitor's best practices and recommended configuration approach. * Paves the way for the upcoming deprecation of direct instrumentation key configuration. **Backwards Compatibility:** This update maintains full backwards compatibility. Users currently utilizing the instrumentation key for configuration can continue to do so but are advised to transition to using the connection string. **To-Do** * Documentation Update in a follow up PR * Deprecation Notice: A future update will introduce a deprecation warning for users still configuring the exporter with the instrumentation key, encouraging them to switch to using a connection string. * Add support for `EndpointSuffix` in connection string - https://learn.microsoft.com/en-us/azure/azure-monitor/app/sdk-connection-string?tabs=dotnet5#connection-string-with-an-endpoint-suffix **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28853 **Testing:** <Describe what testing was performed and which tests were added.> Conducted comprehensive testing, including unit tests, to validate that the new configuration option works as expected and does not introduce regressions. All tests are currently passing. ``` [Wed Nov 1 12:53:42 PDT 2023] --------- Transmitting 27 items --------- [Wed Nov 1 12:53:43 PDT 2023] Telemetry transmitted in 331.926261ms [Wed Nov 1 12:53:43 PDT 2023] Response: 200 [Wed Nov 1 12:53:43 PDT 2023] Items accepted/received: 27/27 [Wed Nov 1 12:53:53 PDT 2023] --------- Transmitting 30 items --------- [Wed Nov 1 12:53:53 PDT 2023] Telemetry transmitted in 73.171392ms [Wed Nov 1 12:53:53 PDT 2023] Response: 200 [Wed Nov 1 12:53:53 PDT 2023] Items accepted/received: 30/30 [Wed Nov 1 12:54:04 PDT 2023] --------- Transmitting 27 items --------- [Wed Nov 1 12:54:04 PDT 2023] Telemetry transmitted in 68.037724ms [Wed Nov 1 12:54:04 PDT 2023] Response: 200 [Wed Nov 1 12:54:04 PDT 2023] Items accepted/received: 27/27 ``` **Documentation:** <Describe the documentation added.> TODO, in a follow up PR. * [exporter/awsxray] Add aws sdk http error events to x-ray subsegment and strip prefix `AWS.SDK.` from aws remote service name (open-telemetry#27232) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> - Convert individual HTTP error events into exceptions within subsegments for AWS SDK spans. - Normalize the service name from `awsxray.AWSServiceAttribute` attribute by removing the `AWS.SDK.` prefix (in some aws sdk instrumentation, we have added the prefix to produce metrics with the prefix to clearly indicate the resource). This change ensures that X-Ray backend recognizes standard service names like "DynamoDb", "S3", etc., enabling correct identification of AWS service types. **Link to tracking Issue:** NA **Testing:** Unit tests are added. **Documentation:** NA --------- Co-authored-by: John Knollmeyer <jknollm@amazon.com> Co-authored-by: John Knollmeyer <jaknollmeyer@gmail.com> * [receiver/carbon] do not expose method (open-telemetry#28872) Do not export function `New` and pass checkapi. open-telemetry#26304 Signed-off-by: sakulali <sakulali@126.com> * [chore] update testbed to embed jaeger exporter (open-telemetry#28880) Rather than importing a deprecated module, this embeds the contents of that module in the testbed. Part of open-telemetry#28647 Signed-off-by: Alex Boten <aboten@lightstep.com> * Make replication stats return whole number (open-telemetry#28824) **Description:** I failed to reproduce []uint8 to int64 conversion but I was able to repro float64 to int64 conversion error. Different types may be due to different versions or values reported. The fix is forcing query to retrieve integer values. While this may seem like most obvious fix I'm not really aligned with it. What query is returning for is a lag as a decimal number (whole part is seconds) by forcing this to return just an int we kind of losing precision. `0.4s` are reported as `0` while it is `400ms`. My proposal here would consists of 2 options. First one is change reporting in a way that what we report is in fact time-span in `ms`. This could most likely be considered breaking. Second option (I'm more in favor of) is to change the type of what is reported (from int to float). This way unit is intact and does not break possible visualizations, but we gain precision and won't lose data. My first issue here so I wanted to get some feedback first before publishing something unreasonable. _EDIT_ Went with the option of deprecating metrics with second precision (still fixing conversion failures) and introducing alternative to these metrics with `_ms` suffix in name and millisecond precision. Old metrics are now behind a featuregate which is enabled by default for now. **Link to tracking Issue:** open-telemetry#26714 **Testing:** Setting up replicated postgres instances and testing method against this deployment. **Documentation:** - --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> * Retract googlecloud exporter releases that don't have logging (open-telemetry#28884) **Description:** Logging was broken after open-telemetry#25900 (released in v0.84.0). It is fixed by open-telemetry/opentelemetry-collector#8792, which will be released in v0.89.0. This will help with any distributions that include the googlecloud exporter components. * [chore] move collectdreceiver shared code to an internal package (open-telemetry#28856) This allows the collectdreceiver to pass checkapi. * [chore] Increase Cache Go step timeout to 25min on Windows (open-telemetry#28859) **Description:** Increase the timeout of the "Cache Go" step in the `build-and-test-windows` workflow. I had a few failures with that today and glancing at the errors for the workflow I can see a few others. Few instances below: * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6722644168/job/18271035294#step:5:22 * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6725656509/job/18280490403#step:5:23 * https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6726302253/job/18282301386#step:5:21 * [exporter/datadog] fix(docs): typo with especially (open-telemetry#28996) * Bump github.com/google/cadvisor from 0.47.3 to 0.48.1 in /receiver/awscontainerinsightreceiver (open-telemetry#28998) Second attempt after dependabot's PR open-telemetry#28974. There was a typo fixed in cadvisor `v0.48.1` that was a breaking change for us. This updates all references to correct spelling of `housekeeping`. Fixes open-telemetry#28995 * [receiver/kafkametrics] Using unique container networks and container names and attempt to fix flaky tests (open-telemetry#28903) **Description:** <Describe what has changed.> Using unique container networks and container names and attempt to fix flaky tests **Link to tracking Issue:** open-telemetry#26293 **Testing:** **Preparation:** DIR = receiver/kafkametricsreceiver CMD = go test -v -count=1 -race -timeout 360s -parallel 4 -tags=integration,"" -run=Integration ./... **Tests:** 1. If we manually modify the code(as shown below) and use invalid kafka broker, such as `localhost:invalid-port`, the same error as shown in the issue may occur. ``` // receiver/kafkametricsreceiver/integration_test.go scraperinttest.WithCustomConfig( func(t *testing.T, cfg component.Config, ci *scraperinttest.ContainerInfo) { rCfg := cfg.(*Config) rCfg.CollectionInterval = 5 * time.Second rCfg.Brokers = []string{"localhost:invalid-port"} rCfg.Scrapers = []string{"brokers", "consumers", "topics"} }), ``` 2. If we execute the test commands **sequentially** , it seems that the execution results are all correct. ``` # all result are correct for i in {1..100}; do echo "Run $i"; ./${CMD} ; done ``` 3. If we execute the commands in **parallel** end with **`&`**, sometimes the error shown in the issue may occur. ``` # sometimes result occur error for i in {1..20}; do echo "Run $i"; ./${CMD} &; done ``` **Inference:** I have found that duplicate container networks and container names can cause container creation to fail or result in successfully created containers with unavailable ports, which may lead to issues similar to the one shown. **Additional information:** Since Kafka's startup relies on ZooKeeper (which waits for the default `zookeeper.connection.timeout.ms=18000`), if Kafka starts first and ZooKeeper fails to start properly after the timeout duration, it will cause the Kafka container to fail to start correctly. I found the issue testcontainers/testcontainers-go#1791 wants to support that. **Documentation:** --------- Signed-off-by: sakulali <sakulali@126.com> * [chore][processort/tailsamplingprocessor] Limit concurrency for certain tests (flay test on Windows runners) (open-telemetry#29014) **Description:** Limit number of goroutines started during `processor/tailsamplingprocessor` tests. This causes very frequently failures on the Windows tests, see [here](open-telemetry#28682 (comment)) for example. The issue is that the race detector has a hard limit on number of goroutines, see golang/go#23611. The fix limits the concurrency in two tests so this limit is not hit on GH Windows runners. **Link to tracking Issue:** Fix open-telemetry#9126 **Testing:** Increased the concurrency on the two changed tests caused the error and validated that it passed twice on my fork. **Documentation:** N/A * Codesmon/exporter/azuremonitor/persistent queue (open-telemetry#26258) Description: Added a new config item to support the QueueSettings values. Extended the exportHelper.New[Metrics|Logs|Traces]Exporter call to pass in the QueueSettings config, thus enabling persistent_queue for this exporter. Link to tracking Issue: Fixes issue open-telemetry#25859 Testing: Extending unit tests to check configuration changes are picked up. Documentation: Added sending_queue config items to README.md's configuration section. * [chore] update affiliation (open-telemetry#29019) Updated to match core * [receiver/collectd] move collectdreceiver to beta (open-telemetry#28997) Promote collectdreceiver as beta component Fixes open-telemetry#28658 * [chore] dependabot updates Wed Nov 8 16:58:54 UTC 2023 (open-telemetry#29028) Bump github.com/DataDog/datadog-agent/pkg/proto from 0.49.0-rc.2 to 0.50.0-devel in /exporter/datadogexporter Bump github.com/IBM/sarama from 1.41.3 to 1.42.0 in /exporter/kafkaexporter Bump github.com/IBM/sarama from 1.41.3 to 1.42.0 in /receiver/kafkareceiver Bump github.com/IBM/sarama from 1.41.3 to 1.42.1 in /receiver/kafkametricsreceiver Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.3 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.46.7 to 1.47.4 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.22.1 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2 from 1.21.2 to 1.22.1 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.22.0 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/config from 1.19.1 to 1.22.0 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.43 to 1.15.1 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.43 to 1.15.1 in /extension/sigv4authextension Bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.20.0 to 1.22.0 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.23.2 to 1.25.0 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/service/sts from 1.23.2 to 1.25.0 in /extension/sigv4authextension Bump github.com/golangci/golangci-lint from 1.55.1 to 1.55.2 in /internal/tools Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /receiver/jaegerreceiver Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /receiver/sapmreceiver Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /receiver/signalfxreceiver Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /receiver/skywalkingreceiver Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /receiver/splunkhecreceiver Bump github.com/gorilla/mux from 1.8.0 to 1.8.1 in /testbed/mockdatareceivers/mockawsxrayreceiver Bump github.com/influxdata/influxdb-client-go/v2 from 2.12.3 to 2.12.4 in /receiver/influxdbreceiver Bump github.com/mattn/go-sqlite3 from 1.14.17 to 1.14.18 in /extension/storage Bump github.com/prometheus/procfs from 0.11.1 to 0.12.0 in /receiver/hostmetricsreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /exporter/signalfxexporter Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /extension/observer/hostobserver Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /processor/resourcedetectionprocessor Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /receiver/awscontainerinsightreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /receiver/hostmetricsreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /receiver/jmxreceiver Bump github.com/shirou/gopsutil/v3 from 3.23.9 to 3.23.10 in /testbed Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 in /cmd/telemetrygen Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.777 to 1.0.782 in /exporter/tencentcloudlogserviceexporter Bump go.mongodb.org/atlas from 0.34.0 to 0.35.0 in /receiver/mongodbatlasreceiver Bump golang.org/x/mod from 0.13.0 to 0.14.0 in /cmd/configschema Bump golang.org/x/sys from 0.13.0 to 0.14.0 in /exporter/signalfxexporter Bump golang.org/x/sys from 0.13.0 to 0.14.0 in /pkg/stanza Bump golang.org/x/sys from 0.13.0 to 0.14.0 in /pkg/winperfcounters Bump golang.org/x/sys from 0.13.0 to 0.14.0 in /receiver/hostmetricsreceiver Bump golang.org/x/sys from 0.13.0 to 0.14.0 in /receiver/windowseventlogreceiver Bump golang.org/x/text from 0.13.0 to 0.14.0 in /cmd/configschema Bump golang.org/x/text from 0.13.0 to 0.14.0 in /cmd/mdatagen Bump golang.org/x/text from 0.13.0 to 0.14.0 in /internal/coreinternal Bump golang.org/x/text from 0.13.0 to 0.14.0 in /pkg/stanza Bump golang.org/x/text from 0.13.0 to 0.14.0 in /testbed Bump golang.org/x/time from 0.3.0 to 0.4.0 in /cmd/telemetrygen Bump google.golang.org/api from 0.148.0 to 0.149.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.148.0 to 0.149.0 in /exporter/googlecloudpubsubexporter Bump google.golang.org/api from 0.148.0 to 0.149.0 in /receiver/googlecloudpubsubreceiver Bump google.golang.org/api from 0.148.0 to 0.149.0 in /receiver/googlecloudspannerreceiver * [chore] dependabot updates Wed Nov 8 18:29:02 UTC 2023 (open-telemetry#29052) Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.47.4 to 1.47.5 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go-v2/config from 1.22.0 to 1.22.2 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go-v2/config from 1.22.0 to 1.22.2 in /extension/sigv4authextension Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.782 to 1.0.786 in /exporter/tencentcloudlogserviceexporter Bump google.golang.org/api from 0.149.0 to 0.150.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.149.0 to 0.150.0 in /exporter/googlecloudpubsubexporter Bump google.golang.org/api from 0.149.0 to 0.150.0 in /receiver/googlecloudpubsubreceiver Bump google.golang.org/api from 0.149.0 to 0.150.0 in /receiver/googlecloudspannerreceiver * [chore] dependabot updates Wed Nov 8 21:01:03 UTC 2023 (open-telemetry#29071) Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/cwlogs Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/aws/xray/testdata/sampleapp Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /internal/metadataproviders Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /receiver/awsecscontainermetricsreceiver Bump github.com/aws/aws-sdk-go from 1.47.5 to 1.47.6 in /receiver/awsxrayreceiver * [exporter/influxdb] Remove //nolint indent-error-flow (open-telemetry#29073) I fixed linter issue by following this document. https://google.github.io/styleguide/go/decisions.html#indent-error-flow * hostmetricsreceiver: remove unused function (open-telemetry#29075) **Description:** `gopsutil` recently added the capability to pass environment vars through context. This is now done everywhere. This environment variable setting function is no longer used or necessary. This PR removes it. **Link to tracking Issue:** open-telemetry#23055 Signed-off-by: Braydon Kains <braydonk@google.com> * [chore] bump go versions in workflows to 1.20.11 and 1.21.4 (open-telemetry#29080) This fixes security vulnerabilities found via govulncheck in the standard library when running against the previous patch versions of golang. While these vulnerabilities don't actually present themselves in the binary, the workflows when running govuln check fail and thus taking in the latest patches fix the issue. Testing gets caught in workflow run. Noticed the issue originally when running workflows on this pr: open-telemetry#28885 * [all][chore] Moved from interface{} to any for all go code (open-telemetry#29072) Additionally added a golangci-lint.yaml update to automatically apply this change to new code going forward Fixes open-telemetry#23811 --------- Co-authored-by: Alex Boten <aboten@lightstep.com> * [receiver/dockerstats] rename struct and function to keep expected receiver.Factory and pass checkapi (open-telemetry#27086) Rename struct and function to keep expected receiver.Factory and pass checkapi open-telemetry#26304 go run cmd/checkapi/main.go . go test for dockerstatsreceiver Signed-off-by: sakulali <sakulali@126.com> * [receiver/mongodbatlasreceiver] add provider resource attributes (open-telemetry#28835) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This feature adds provider resource attributes `mongodb_atlas.provider.name` and `mongodb_atlas.region.name` to add additional context and filtering capabilities. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#28833 **Testing:** <Describe what testing was performed and which tests were added.> Test were automatically updated. Live testing was performed and validated on clusters. **Documentation:** <Describe the documentation added.> Docs were automatically updated. * [exporter/syslog] Enable component (open-telemetry#28902) **Description:** Promote syslogexporter to alpha and add it to otelcontribcol **Link to tracking Issue:** related to: open-telemetry#21242, open-telemetry#21244, open-telemetry#21245 **Testing:** <Describe what testing was performed and which tests were added.> Manual tests: Configuration: ```yaml exporters: syslog: network: tcp port: 514 endpoint: 127.0.0.1 protocol: rfc5424 receivers: filelog: start_at: beginning include: - /Users/kkujawa/git/opentelemetry-collector-contrib/test.txt operators: - type: syslog_parser protocol: rfc5424 service: pipelines: logs: receivers: - filelog exporters: - syslog ``` Logs: ``` ./bin/otelcontribcol_darwin_amd64 --config /Users/kkujawa/git/opentelemetry-collector-contrib/bin/config.yaml 2023-11-06T12:59:31.656+0100 info service@v0.88.1-0.20231026220224-6405e152a2d9/telemetry.go:84 Setting up own telemetry... 2023-11-06T12:59:31.656+0100 info service@v0.88.1-0.20231026220224-6405e152a2d9/telemetry.go:201 Serving Prometheus metrics {"address": ":8888", "level": "Basic"} 2023-11-06T12:59:31.656+0100 info exporter@v0.88.1-0.20231026220224-6405e152a2d9/exporter.go:275 Development component. May change in the future. {"kind": "exporter", "data_type": "logs", "name": "syslog"} 2023-11-06T12:59:31.656+0100 info syslogexporter@v0.88.0/exporter.go:42 Syslog Exporter configured {"kind": "exporter", "data_type": "logs", "name": "syslog", "endpoint": "127.0.0.1", "Protocol": "rfc5424", "port": 514} 2023-11-06T12:59:31.657+0100 info service@v0.88.1-0.20231026220224-6405e152a2d9/service.go:143 Starting otelcontribcol... {"Version": "0.88.0-dev", "NumCPU": 16} 2023-11-06T12:59:31.657+0100 info extensions/extensions.go:33 Starting extensions... 2023-11-06T12:59:31.657+0100 info adapter/receiver.go:45 Starting stanza receiver {"kind": "receiver", "name": "filelog", "data_type": "logs"} 2023-11-06T12:59:31.657+0100 info service@v0.88.1-0.20231026220224-6405e152a2d9/service.go:169 Everything is ready. Begin running and processing data. 2023-11-06T12:59:31.858+0100 info fileconsumer/file.go:263 Started watching file {"kind": "receiver", "name": "filelog", "data_type": "logs", "component": "fileconsumer", "path": "/Users/kkujawa/git/opentelemetry-collector-contrib/test.txt"} ``` * [chore][pkg/stanza]: when found duplicate, continue from outer loop (open-telemetry#28889) **Description:** Fix a bug when duplicate readers are added to the active list even after the underlying file is closed. To fix this, continue from the outer loop. This doesn't result in any duplicates, but this will keep producing the following annoying error every time. ```2023-11-05T02:34:03.530+0530 ERROR Failed to seek {"component": "fileconsumer", "path": "/var/folders/fs/njj5c3xx7vdcsr28n19vykw00000gn/T/TestStalePartialFingerprintDiscarded2443925830/001/1616317274.log2", "error": "seek /var/folders/fs/njj5c3xx7vdcsr28n19vykw00000gn/T/TestStalePartialFingerprintDiscarded2443925830/001/1616317274.log2: file already closed"}``` **Testing:** Update the test to check the previouPollFiles * udp-receiver async - fix data corruption (with buffer pools) (open-telemetry#28898) **Description:** Fixing a bug in udp async mode only (but didn't affect the default non-async mode). Udp-receiver reuses the same buffer when each packet is processed. While that's working fine when running it without async config, it cause a significant amount of duplicate packets and corrupted packets being sent downstream. The reader-async thread is reading a packet from the udp port into the buffer, places that buffer in the channel, and reads another packet into the same buffer and pushes it to the channel. Let's say that the processor-async thread was a bit slow, so it only tries to read from the channel after the 2 items were placed in the channel. In that case, the processor thread will read 2 items from the channel, but it will be the same 2nd packet (since the 1st one was overwritten). In some cases, it seems the processor is reading a corrupted buffer (since the reader is currently writing into it). We can't fix it by having the reader allocate a new buffer before each time it reads a packet from the udp port, since that hurts performance significantly (reducing it up to ~50%). Instead, use a pool so the buffers are reused. Before reading a packet, the reader get a buffer from the pool. The processor returns it back to the pool after it has been successfully processed **Link to tracking Issue:** 27613 **Testing:** Ran existing unitests. Ran ran stress tests (sending 250k udp packets per second) duplicate/corruption issue didn't happen; performance wasn't hurt. **Documentation:** None * [chore][receiver/windowseventlog] remove duplicate function NewFactory and pass checkapi (open-telemetry#29020) **Description:** Remove duplicate function NewFactory and pass checkapi. **Link to tracking Issue:** open-telemetry#26304 **Testing:** go run cmd/checkapi/main.go . go test for windowseventlogreceiver **Documentation:** Signed-off-by: sakulali <sakulali@126.com> * [chore][pkg/stanza][exporter/signalfx] One more interface{} -> any and skip flaky tests (open-telemetry#29101) See https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/28898/files#r1389614720. Looks like a merge conflict. * [chore][CONTRIBUTING.md] Add triage process link (open-telemetry#29092) The `needs triage` label is directly related to how we define triaging. Added a link to the triaging definition to make the label's usage more clear. (Even though the triaging process paragraph is just above this table in the document, it's easy to miss). * fix(processor/k8sattributes): README was misleading/had typoes (open-telemetry#29108) **Description:** Fixes misleading documentation about which RBAC role is required and other invalid YAML I found along the way * [processor/k8sattributes] fix(docs): typo for kubernetes label (open-telemetry#29110) **Description:** typo for kubernetes label in k8sattributesprocessor **Link to tracking Issue:** n/a **Testing:** n/a docs **Documentation:** n/a * Update doc.go of filelogreceiver (open-telemetry#29100) * [connector/datadog] Set MutatesData to true (open-telemetry#29114) **Description:** Mark datadogconnector as `MutatesData` to prevent data race **Link to tracking Issue:** Fixes open-telemetry#29111 * cmd/telemetrygen: add HTTP export for logs (open-telemetry#29078) **Description:** Closes open-telemetry#18867 **Testing:** Ran opentelemetry-collector locally with debug exporter, then used telemetrygen with `--otlp-http` with and without `--otlp-insecure`. **Documentation:** None --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: sakulali <sakulali@126.com> Signed-off-by: Alex Boten <aboten@lightstep.com> Signed-off-by: Braydon Kains <braydonk@google.com> Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Paulo Janotti <pjanotti@splunk.com> Co-authored-by: Chris Mark <chrismarkou92@gmail.com> Co-authored-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com> Co-authored-by: Marc Tudurí <marctc@protonmail.com> Co-authored-by: Eason Lau <liubey1214@gmail.com> Co-authored-by: Abhishek <abhishek@abhishekkothari.in> Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com> Co-authored-by: Andrzej Stencel <astencel@sumologic.com> Co-authored-by: Joonsoo Park <joonsoo181005@gmail.com> Co-authored-by: sakulali <sakulali@126.com> Co-authored-by: aishyandapalli <ayandapalli@ebay.com> Co-authored-by: mcube8 <V.Madhumita.Malvika@morganstanley.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Garry Cairns <2401853+garry-cairns@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Punya Biswal <punya@google.com> Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> Co-authored-by: Marcel Birkner <marcel.birkner@dash0.com> Co-authored-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Michal Pristas <michal.pristas@gmail.com> Co-authored-by: Nathan Slaughter <28688390+nslaughter@users.noreply.github.com> Co-authored-by: Rajkumar Rangaraj <rajrang@microsoft.com> Co-authored-by: Ping Xiang <64551395+pxaws@users.noreply.github.com> Co-authored-by: John Knollmeyer <jknollm@amazon.com> Co-authored-by: John Knollmeyer <jaknollmeyer@gmail.com> Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Karming <41309630+karmingc@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Colin Desmond <colin.desmond@microsoft.com> Co-authored-by: OpenTelemetry Bot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yuki Nakamura <yuki.nakamura@mapbox.com> Co-authored-by: Braydon Kains <93549768+braydonk@users.noreply.github.com> Co-authored-by: Adriel Perkins <adriel@adrielperkins.com> Co-authored-by: lucasoskorep <lucas.oskorep@gmail.com> Co-authored-by: Jon <jonathan.wamsley@bluemedora.com> Co-authored-by: Katarzyna Kujawa <73836361+kkujawa-sumo@users.noreply.github.com> Co-authored-by: hovavza <147598197+hovavza@users.noreply.github.com> Co-authored-by: Liz Fong-Jones <elizabeth@ctyalcove.org> Co-authored-by: Yoshi Yamaguchi <yoshifumi@google.com> Co-authored-by: Andrew Wilkins <axw@elastic.co>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…elemetry#28884) **Description:** Logging was broken after open-telemetry#25900 (released in v0.84.0). It is fixed by open-telemetry/opentelemetry-collector#8792, which will be released in v0.89.0. This will help with any distributions that include the googlecloud exporter components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In #19203, we disabled retry_on_failure by default because retry is now handled by the google cloud client libraries.
However, many users still enable it because the error message encourages users to enable retry_on_failure. This is causing problems, especially with metrics because retrying a batch of metrics produces confusing errors (like out-of-order or duplicate timeseries errors) and spams users logs more than necessary.
This PR removes the retry_on_failure config from the GMP and googlecloud exporters.
Documentation:
Updated documentation