[chore][pkg/stanza] Simplify tokenize package #26040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-tokenize-simplify
branch
from
e347f8c
to
5a6e17f
Compare
djaglowski
force-pushed
the
pkg-stanza-tokenize-simplify
branch
from
5a6e17f
to
ac592b5
Compare
|
Rebased after #26313 |
TylerHelmuth
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several simplifications within and relating to the new tokenization package:
tokenize.Multilinenow returns abufio.splitFuncwithout concern for a flush func. A flush func is applied later if necessary.tokenize.Splitter.SplitterConfigcan now generate abufio.SplitFuncdirectly.tokenize.Flusher.FlusherConfigcan now wrap abufio.SplitFuncdirectly. (It does still create a struct to maintain state, but then wraps the split func with a receiver that interacts with this state.)fileconsumer's internalsplitterpackage was also simplified. It may make sense to merge this intotokenizein a future PR, but this PR is large enough.