-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awsemf] Fix possible panic when using stdout output_destination #26250
Merged
codeboten
merged 9 commits into
open-telemetry:main
from
bryan-aguilar:awsemf/stdoutpanic
Sep 7, 2023
Merged
[exporter/awsemf] Fix possible panic when using stdout output_destination #26250
codeboten
merged 9 commits into
open-telemetry:main
from
bryan-aguilar:awsemf/stdoutpanic
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rapphil
approved these changes
Aug 29, 2023
Aneurysm9
reviewed
Aug 29, 2023
Aneurysm9
approved these changes
Aug 29, 2023
fatsheep9146
approved these changes
Aug 30, 2023
fatsheep9146
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Aug 30, 2023
This was referenced Sep 3, 2023
codeboten
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: It is possible for the awsemf exporter to panic when using the
awsemf.output_destination:stdout
configuration option. I was not able to replicate this in the unit tests. I tried several different metric setups but was not able to find a configuration that caused the translations to to result in a nil message body.After reviewing the translation code I found one possible area where an error was not being returned and a nil
cwlogs.Event
object was returned. I have updated that function signature to return an error in the case where a json marshal error occurs also.Link to tracking Issue: none. See stack trace below