Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Fix k8s.deployment metric units #26255

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Aug 29, 2023

Description:

Fix Metrics that count objects should use units with brackets {} and not 1.

Marking it as bug_fix because of #10553 (comment)

Tested with prometheus exporter:
Previously:

# HELP k8s_deployment_available Total number of available pods (ready for at least minReadySeconds) targeted by this deployment
# TYPE k8s_deployment_available gauge
k8s_deployment_available 1
# HELP k8s_deployment_desired Number of desired pods in this deployment
# TYPE k8s_deployment_desired gauge
k8s_deployment_desired 1

Now:

# HELP k8s_deployment_available Total number of available pods (ready for at least minReadySeconds) targeted by this deployment
# TYPE k8s_deployment_available gauge
k8s_deployment_available 1
# HELP k8s_deployment_desired Number of desired pods in this deployment
# TYPE k8s_deployment_desired gauge
k8s_deployment_desired 1

Atleast for this backend it's not breaking change?

Link to tracking Issue: 10553

#10553

Testing:

  • updated tests

Documentation:

  • generated

@povilasv povilasv force-pushed the clusterreceiver-unit-change branch 2 times, most recently from 7ad7fed to 8ba1d0b Compare August 29, 2023 09:13
@povilasv povilasv force-pushed the clusterreceiver-unit-change branch 2 times, most recently from 200b8e7 to dec339e Compare August 29, 2023 10:24
@povilasv povilasv marked this pull request as ready for review August 29, 2023 11:10
@povilasv povilasv requested a review from a team August 29, 2023 11:10
@crobert-1
Copy link
Member

Hi @povilasv, the Previously: and Now: text blocks in your description are identical, can you update to show the difference?

@povilasv
Copy link
Contributor Author

Hi @povilasv, the Previously: and Now: text blocks in your description are identical, can you update to show the difference?

This is the point, my manual test shows no difference

@povilasv povilasv force-pushed the clusterreceiver-unit-change branch from dec339e to 202796b Compare September 8, 2023 12:52
@povilasv povilasv force-pushed the clusterreceiver-unit-change branch from 202796b to 93d1e56 Compare September 8, 2023 12:53
@dmitryax dmitryax merged commit 48beef8 into open-telemetry:main Sep 12, 2023
90 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 12, 2023
@povilasv povilasv deleted the clusterreceiver-unit-change branch September 14, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants