[pkg/stanza] Extract flush package from tokenize package #26517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-flush
branch
from
8e19dee
to
29fc65d
Compare
djaglowski
force-pushed
the
pkg-stanza-flush
branch
3 times, most recently
from
806c7ae
to
ef98941
Compare
|
In order to reduce the diff, I've left |
djaglowski
force-pushed
the
pkg-stanza-flush
branch
from
b242b60
to
24ed545
Compare
|
This should be good too go once CI passes. Apologies for the churn. I've opened #26527 for the followup change to tests. |
atoulme
approved these changes
Sep 8, 2023
djaglowski
added a commit
that referenced
this pull request
Sep 8, 2023
Followup to #26517 The `MultiLineTokenizerTestCase` became unnecessary with changes in the previous PR but the diff caused by removing it was quite large. This PR just removes the struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #26512.
Another small step towards decomposing the
tokenizepackage. Part of #26241