Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add predeclared linter #26518

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 7, 2023

See #25060 for original request.

This adds the predeclared linter with an explicit carveout to ignore use of the copy reserved word as it is used by a package.

@atoulme atoulme force-pushed the add_predeclared_linter branch from 496d1d3 to 8a8a106 Compare September 7, 2023 20:19
@atoulme atoulme requested a review from a team September 7, 2023 20:19
@crobert-1
Copy link
Member

Failing k8s integration test is frequency of #24223.

@atoulme atoulme force-pushed the add_predeclared_linter branch from 8a8a106 to cc28bb4 Compare September 7, 2023 23:13
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as tests are successful 👍

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Sep 14, 2023
@codeboten codeboten merged commit c8e7d87 into open-telemetry:main Sep 14, 2023
@github-actions github-actions bot added this to the next release milestone Sep 14, 2023
@atoulme atoulme deleted the add_predeclared_linter branch September 14, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants