-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add predeclared linter #26518
Merged
codeboten
merged 2 commits into
open-telemetry:main
from
atoulme:add_predeclared_linter
Sep 14, 2023
Merged
[chore] add predeclared linter #26518
codeboten
merged 2 commits into
open-telemetry:main
from
atoulme:add_predeclared_linter
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e9a690
to
496d1d3
Compare
frzifus
approved these changes
Sep 7, 2023
496d1d3
to
8a8a106
Compare
Failing k8s integration test is frequency of #24223. |
8a8a106
to
cc28bb4
Compare
crobert-1
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as long as tests are successful 👍
bogdandrutu
approved these changes
Sep 8, 2023
codeboten
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
extension/jaegerremotesampling
pkg/translator/opencensus
ready to merge
Code review completed; ready to merge by maintainers
testbed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #25060 for original request.
This adds the predeclared linter with an explicit carveout to ignore use of the
copy
reserved word as it is used by a package.