Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix prometheus compliance test workflow #26699

Closed
wants to merge 1 commit into from
Closed

Fix: Fix prometheus compliance test workflow #26699

wants to merge 1 commit into from

Conversation

rapphil
Copy link
Contributor

@rapphil rapphil commented Sep 14, 2023 •
edited
Loading

Description: Fix workflow to fail in case the compliance tests don't pass

Fix: #26570

Testing:

Tested locally:

$ go test -v --tags=compliance -run "TestRemoteWrite/otel/.+" ./
$ echo $?
1

Documentation:

@rapphil rapphil requested review from a team and andrzej-stencel September 14, 2023 23:52
@rapphil
Copy link
Contributor Author

rapphil commented Sep 15, 2023

Looks like this PR is the one that caused the compliance tests to start to fail #26489

fatsheep9146
fatsheep9146 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the failed check

@fatsheep9146 fatsheep9146 added chore Skip Changelog PRs that do not require a CHANGELOG.md entry labels Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 5, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatsheep9146 fatsheep9146 fatsheep9146 left review comments

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

Assignees

@fatsheep9146 fatsheep9146

Labels
chore Skip Changelog PRs that do not require a CHANGELOG.md entry Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Prometheus Compliance Tests] - Incorrect workflow status during failure
2 participants
@rapphil @fatsheep9146