[k8sclusterreceiver] refactor metric units to follow Otel conventions #26708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
commented
Sep 15, 2023
| gauge: | ||
| value_type: int | ||
|
|
||
| k8s.daemonset.current_scheduled_nodes: | ||
| enabled: true | ||
| description: Number of nodes that are running at least 1 daemon pod and are supposed to run the daemon pod | ||
| unit: "1" | ||
| unit: "{node}" |
There was a problem hiding this comment.
Not sure if this should be {node} or {pod} description says Number of nodes. and metric name has current_scheduled_nodes so went with nodes
There was a problem hiding this comment.
I think node is correct. For a given daemonset I believe this counts the number of nodes it is schedules on.
povilasv
force-pushed
the
k8sclusterreceiver-fix-units
branch
from
754dc45 to
8dba9f5
Compare
crobert-1
approved these changes
Sep 18, 2023
dmitryax
approved these changes
Sep 21, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…open-telemetry#26708) **Description:** Refactor some metric units to follow OTEL Semantic conventions **Link to tracking Issue:** open-telemetry#10553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor some metric units to follow OTEL Semantic conventions
Link to tracking Issue: #10553
Testing:
Documentation: