feat: add honeycomb marker exporter structure #27001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey, just a few things that I can point out that would need addressing.
Otherwise, I will leave it to @TylerHelmuth to give the final approval.
TylerHelmuth
reviewed
Oct 2, 2023
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
mx-psi
previously requested changes
Oct 3, 2023
fchikwekwe
force-pushed
the
feat/marker-exporter
branch
from
5b41859 to
7d6d0c5
Compare
mx-psi
reviewed
Oct 11, 2023
mx-psi
reviewed
Oct 11, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
**Description:** This component will export markers to be consumed by the Honeycomb Markers API to highlight user events based initially on preset configurations. **Link to tracking Issue:** open-telemetry#26653 **Testing:** Unit testing for factory and config **Documentation:** README describing component usage --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** This component will export markers to be consumed by the Honeycomb Markers API to highlight user events based initially on preset configurations. **Link to tracking Issue:** open-telemetry#26653 **Testing:** Unit testing for factory and config **Documentation:** README describing component usage --------- Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This component will export markers to be consumed by the Honeycomb Markers API to highlight user events based initially on preset configurations.
Link to tracking Issue: #26653
Testing: Unit testing for factory and config
Documentation: README describing component usage