Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8sclusterreceiver] refactor state metrics to use empty units #27091

Merged

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Sep 25, 2023

Description:

Change k8s.container.ready, k8s.pod.phase, k8s.pod.status_reason, k8s.namespace.phase units to empty

Link to tracking Issue:
#10553

Testing:

  • updated unit tests

Documentation:

  • generated

@crobert-1
Copy link
Member

For reference:

Related: #10553, #27089. This PR is dependent on the outcome of #10553.

@povilasv povilasv force-pushed the k8sclusterreceiver-empty-units branch 2 times, most recently from 3aa9efb to 79f740e Compare September 26, 2023 05:54
@povilasv povilasv force-pushed the k8sclusterreceiver-empty-units branch from 79f740e to a5f6acd Compare October 4, 2023 10:15
@povilasv povilasv force-pushed the k8sclusterreceiver-empty-units branch from a5f6acd to 978f70f Compare October 4, 2023 10:24
@povilasv povilasv marked this pull request as ready for review October 4, 2023 10:57
@povilasv povilasv requested a review from a team October 4, 2023 10:57
@dmitryax dmitryax merged commit bed78f3 into open-telemetry:main Oct 10, 2023
94 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 10, 2023
@povilasv povilasv deleted the k8sclusterreceiver-empty-units branch October 10, 2023 08:17
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
…telemetry#27091)

**Description:** 

Change k8s.container.ready, k8s.pod.phase, k8s.pod.status_reason,
k8s.namespace.phase units to empty

**Link to tracking Issue:** open-telemetry#10553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants