Add span attributes as honeycomb event fields. #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a regression introduced in the recent refactoring of the honeycomb exporter. Attributes were supported on span links and message events, but not on the span itself.
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 78.82% 78.89% +0.06%
==========================================
Files 159 159
Lines 8053 8056 +3
==========================================
+ Hits 6348 6356 +8
+ Misses 1349 1347 -2
+ Partials 356 353 -3
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jun 2, 2020
bogdandrutu
approved these changes
Jun 2, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
Fixing a regression introduced in the recent refactoring of the honeycomb exporter. Attributes were supported on span links and message events, but not on the span itself.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Update DESIGN doc - Added a section describing the pipeline and its components. - Deleted paragraphs which are no longer relevant. TODO: update a couple diagrams which still show "OpenCensus" * PR fixes. * More PR fixes
6 tasks
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a regression introduced in the recent refactoring of the honeycomb exporter. Attributes were supported on span links and message events, but not on the span itself.