Add an optional argument to converters to support hashing #27235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
rnishtala-sumo
changed the title
rnishtala-sumo
changed the title
rnishtala-sumo
changed the title
…rgument in the converter
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
b0819c9
to
2c9aef8
Compare
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
2 times, most recently
from
1b671da
to
dd4c1ae
Compare
evan-bradley
reviewed
Oct 2, 2023
…optional hash function argument
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
dd4c1ae
to
5189734
Compare
TylerHelmuth
reviewed
Oct 3, 2023
TylerHelmuth
reviewed
Oct 6, 2023
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
2 times, most recently
from
1028063
to
f1fa799
Compare
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
f1fa799
to
5afef58
Compare
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
5afef58
to
7a3644b
Compare
evan-bradley
approved these changes
Oct 11, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…etry#27235) **Description:** Functions to modify matched text during replacement can now be passed as optional arguments to the following Editors: - replace_pattern - replace_all_patterns - replace_match - replace_all_matches **Documentation:** https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern **Issue:** Resolves open-telemetry#22787
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…etry#27235) **Description:** Functions to modify matched text during replacement can now be passed as optional arguments to the following Editors: - replace_pattern - replace_all_patterns - replace_match - replace_all_matches **Documentation:** https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern **Issue:** Resolves open-telemetry#22787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Functions to modify matched text during replacement can now be passed as optional arguments to the following Editors:
Documentation:
https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern
Issue:
Resolves #22787