[chore]: Expand e2e testbed #27251
Merged
[chore]: Expand e2e testbed #27251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
poc-testbed
branch
from
eb146a1 to
810156e
Compare
VihasMakwana
force-pushed
the
poc-testbed
branch
from
810156e to
23978db
Compare
djaglowski
reviewed
Sep 28, 2023
VihasMakwana
force-pushed
the
poc-testbed
branch
from
8431b17 to
78f4946
Compare
|
@djaglowski turns out we don't need to add a new mock component right now. I tweaked mockbackend to propagate the errors back to our data sender (with |
VihasMakwana
force-pushed
the
poc-testbed
branch
from
6f7c633 to
4632ccb
Compare
VihasMakwana
force-pushed
the
poc-testbed
branch
from
4632ccb to
50efc64
Compare
|
Please address CI failures |
added 2 commits
October 3, 2023 19:03
|
@djaglowski CI's green! Please review. |
TylerHelmuth
reviewed
Oct 3, 2023
TylerHelmuth
added
the
Skip Changelog
|
@TylerHelmuth does the changes look good to you? |
TylerHelmuth
approved these changes
Oct 10, 2023
djaglowski
reviewed
Oct 11, 2023
testbed/testbed/load_generator.go
Outdated
| for { | ||
| if err := traceSender.ConsumeTraces(context.Background(), traceData); err != nil { | ||
| if consumererror.IsPermanent(err) { | ||
| if lg.prevErr == nil || lg.prevErr.Error() != err.Error() { |
There was a problem hiding this comment.
Can you add a comment explaining the meaning of the conditions on this line?
testbed/testbed/mock_backend.go
Outdated
| DroppedLogs []plog.Logs | ||
|
|
||
| // decision to return permanent/non-permanent errors | ||
| decision int |
There was a problem hiding this comment.
This notion of a "decision" is very generic. I also don't think a mandatory integer is an appropriate way to configure test cases. Finally, I think this kind of logic should not dominate the codebase of a simple and more widely used function.
To that end, I suggest the following:
- Use an options pattern to optionally pass this configuration to
NewMockBackend. - Instead of saving an int and switching on it. Just save the appropriate function here. (Default always returns nil.) Whether or not the error is permanent can be ascertained from the returned error.
There was a problem hiding this comment.
@djaglowski I have updated to use function instead of integer and removed the mandatory integer.
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
VihasMakwana
force-pushed
the
poc-testbed
branch
3 times, most recently
from
fa6385d to
51a8fa7
Compare
VihasMakwana
force-pushed
the
poc-testbed
branch
from
51a8fa7 to
88b7b1d
Compare
|
@TylerHelmuth @djaglowski can we merge this one? I've rebased it to main and CI's green. |
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
Related issue: open-telemetry#20552 Tweak the mock-backend to do following: - Receives data from the receiver. - Returns errors randomly to our receiver, which attempts to resend/drop the data. This is helpful when we're required to test random behaviors of the collector and ensure reliable data delivery. This is my initial PR to expand the testbed. This will help my further efforts to expand the testbed. Myself and @omrozowicz-splunk plan on adding `sending_queue` support to the testbed and expanding the testing capabilities. --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
Related issue: open-telemetry#20552 Tweak the mock-backend to do following: - Receives data from the receiver. - Returns errors randomly to our receiver, which attempts to resend/drop the data. This is helpful when we're required to test random behaviors of the collector and ensure reliable data delivery. This is my initial PR to expand the testbed. This will help my further efforts to expand the testbed. Myself and @omrozowicz-splunk plan on adding `sending_queue` support to the testbed and expanding the testing capabilities. --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #20552
Tweak the mock-backend to do following:
This is helpful when we're required to test random behaviors of the collector and ensure reliable data delivery.
This is my initial PR to expand the testbed. This will help my further efforts to expand the testbed.
Myself and @omrozowicz-splunk plan on adding
sending_queuesupport to the testbed and expanding the testing capabilities.