-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/signalfx] [exporter/splunkhec] Remove max_connections config parameter #27611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
remove_max_connections
branch
from
October 11, 2023 04:23
63ea014
to
8a60e5a
Compare
atoulme
force-pushed
the
remove_max_connections
branch
from
October 11, 2023 04:24
8a60e5a
to
0ad0185
Compare
songy23
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crobert-1
approved these changes
Oct 11, 2023
@dmitryax please review when you get a chance thanks! |
dmitryax
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally should be two PRs :)
dmitryax
changed the title
Remove max_connections config parameter
[exporter/signalfx] [exporter/splunkhec] Remove max_connections config parameter
Oct 16, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…g parameter (open-telemetry#27611) **Description:** The max_connections config setting were deprecated with open-telemetry#16837 and open-telemetry#16838. It has been 10 months since these changes have been made and it is time to remove this configuration setting altogether. **Link to tracking Issue:** open-telemetry#27610
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…g parameter (open-telemetry#27611) **Description:** The max_connections config setting were deprecated with open-telemetry#16837 and open-telemetry#16838. It has been 10 months since these changes have been made and it is time to remove this configuration setting altogether. **Link to tracking Issue:** open-telemetry#27610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The max_connections config setting were deprecated with #16837 and #16838. It has been 10 months since these changes have been made and it is time to remove this configuration setting altogether.
Link to tracking Issue:
#27610