[servicegraphprocessor, servicegraphconnector] Measure latency in seconds instead of milliseconds #27665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Oct 13, 2023
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: bug_fix |
There was a problem hiding this comment.
Even though this is a breaking change, I think the change type is correctly set to bug fix.
crobert-1
reviewed
Oct 13, 2023
| @@ -306,7 +306,7 @@ func verifyDuration(t *testing.T, m pmetric.Metric) { | |||
| assert.Equal(t, 1, dps.Len()) | |||
|
|
|||
| dp := dps.At(0) | |||
| assert.Equal(t, float64(1000), dp.Sum()) // Duration: 1sec | |||
There was a problem hiding this comment.
It might be worthwhile to add some tests with the feature gate enabled to ensure we're getting the ms units when we're supposed to.
Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com>
crobert-1
approved these changes
Oct 17, 2023
|
Failing integration test is #26293, I've added it as a frequency of the issue. It's unrelated to this change. |
|
@mapno, I think this got in conflict with your flush interval PR. Do you mind resolving the conflict? |
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…onds instead of milliseconds (open-telemetry#27665) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Measures latency in seconds instead of milliseconds, as the metric name indicates. Previously, milliseconds was used. This unit is still available via the feature gate `processor.servicegraph.legacyLatencyUnitMs`. This is a breaking change. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27488 **Testing:** <Describe what testing was performed and which tests were added.> Tests are updated **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…onds instead of milliseconds (open-telemetry#27665) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Measures latency in seconds instead of milliseconds, as the metric name indicates. Previously, milliseconds was used. This unit is still available via the feature gate `processor.servicegraph.legacyLatencyUnitMs`. This is a breaking change. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27488 **Testing:** <Describe what testing was performed and which tests were added.> Tests are updated **Documentation:** <Describe the documentation added.> --------- Co-authored-by: Curtis Robert <92119472+crobert-1@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Measures latency in seconds instead of milliseconds, as the metric name indicates. Previously, milliseconds was used. This unit is still available via the feature gate
processor.servicegraph.legacyLatencyUnitMs.This is a breaking change.
Link to tracking Issue: #27488
Testing: Tests are updated
Documentation: