cassandra exporter keyspace check and dynamic timeout #27681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
crobert-1
reviewed
Oct 16, 2023
crobert-1
requested changes
Oct 30, 2023
crobert-1
requested changes
Oct 31, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
crobert-1
approved these changes
Nov 15, 2023
fatsheep9146
requested changes
Nov 15, 2023
There was a problem hiding this comment.
Error: ../../exporter/cassandraexporter/factory.go:29:20: undefined: time
make[2]: *** [Makefile:272: otelcontribcol] Error 1
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
make[1]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
make[1]: *** [Makefile:209: docker-component] Error 2
make: *** [Makefile:[22](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/6873856808/job/18694541155?pr=27681#step:6:23)2: docker-otelcontribcol] Error 2
there existed failed checks I think should be fixed @emreyalvac
fatsheep9146
approved these changes
Nov 23, 2023
atoulme
approved these changes
Nov 27, 2023
atoulme
added
the
ready to merge
98 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check keyspace if exist and dynamic timeout for connection
#27633