Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix codeowners #27886

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[chore] fix codeowners #27886

merged 1 commit into from
Oct 20, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 20, 2023

Some changes were made to the CODEOWNERS file without editing the metadata.yaml files first.

@atoulme atoulme requested a review from djaglowski as a code owner October 20, 2023 15:30
@atoulme atoulme requested a review from a team October 20, 2023 15:30
@crobert-1 crobert-1 mentioned this pull request Oct 20, 2023
Closed
@crobert-1
Copy link
Member

Extra context for the metadata.yaml changes:

As a result of #27667, we're seeing issues in the .github/CODEOWNERS file. This is because the receiver/windowseventlogreceiver/metadata.yaml file wasn't updated to include @pjanotti as code owner, resulting in these two sources being out of sync.

@crobert-1 crobert-1 mentioned this pull request Oct 20, 2023
Merged
@djaglowski djaglowski merged commit 43e259f into open-telemetry:main Oct 20, 2023
76 checks passed
@atoulme
Copy link
Contributor Author

atoulme commented Oct 20, 2023

This is because the githubgen job doesn't currently run as we still don't have a PAT installed to query github for org members.

@github-actions github-actions bot added this to the next release milestone Oct 20, 2023
@atoulme atoulme deleted the align_codeowners branch October 20, 2023 15:56
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@atoulme @sigilioso
[chore] fix codeowners (open-telemetry#27886)
6036351 
Some changes were made to the CODEOWNERS file without editing the
metadata.yaml files first.
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@atoulme @jmsnll
[chore] fix codeowners (open-telemetry#27886)
62b891b 
Some changes were made to the CODEOWNERS file without editing the
metadata.yaml files first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@djaglowski djaglowski djaglowski approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@TylerHelmuth TylerHelmuth

Labels
receiver/windowseventlog
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.
5 participants
@atoulme @crobert-1 @codeboten @djaglowski @TylerHelmuth