Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable NO_WINDOWS_SERVICE to force interactive mode on Windows #2819

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Description:
This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers.

Main repo PR description:

Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service.

This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired.

Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team March 22, 2021 16:29
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #2819 (0f43e3e) into main (73d1afa) will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2819      +/-   ##
==========================================
+ Coverage   90.50%   91.57%   +1.06%     
==========================================
  Files         446      447       +1     
  Lines       22009    22085      +76     
==========================================
+ Hits        19920    20224     +304     
+ Misses       1627     1392     -235     
- Partials      462      469       +7     
Flag Coverage Δ
integration 69.09% <ø> (?)
unit 90.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/common/testing/container/container.go 73.68% <0.00%> (ø)
receiver/jmxreceiver/receiver.go 94.80% <0.00%> (+16.88%) ⬆️
receiver/dockerstatsreceiver/docker.go 92.30% <0.00%> (+39.05%) ⬆️
receiver/dockerstatsreceiver/receiver.go 96.72% <0.00%> (+47.54%) ⬆️
receiver/jmxreceiver/subprocess/subprocess.go 96.55% <0.00%> (+74.48%) ⬆️
receiver/redisreceiver/receiver.go 87.50% <0.00%> (+87.50%) ⬆️
receiver/redisreceiver/client.go 100.00% <0.00%> (+100.00%) ⬆️
receiver/redisreceiver/factory.go 100.00% <0.00%> (+100.00%) ⬆️
...eceiver/jmxreceiver/subprocess/subprocess_linux.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1afa...0f43e3e. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 750cf7f into open-telemetry:main Mar 24, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the fix-windows-docker branch March 26, 2021 07:30
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
…Windows (#2819)

This is a copy of the main repo PR: open-telemetry/opentelemetry-collector#2272 that enables running the collector inside Windows Docker containers. 

Main repo PR description:

> Adding a feature - adds a check for NO_WINDOWS_SERVICE environment variable on Windows to allow forcing interactive mode instead of running as a service.
>
> This is required for using the collector in Windows Docker containers, as at least some of the Windows base images do not support services (fails with "The service process could not connect to the service controller"). Environment variable is used instead of automatic detection of Docker as it is uncertain if images that support services are possible and/or desired.
>
>Running collector in Windows Docker containers is required to perform containerized integration tests of agents on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants