Set spanmetricsprocessor call metric IsMonotonic to true #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <yb532204897@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.02%
==========================================
Files 450 450
Lines 22189 22190 +1
==========================================
- Hits 20325 20322 -3
- Misses 1394 1396 +2
- Partials 470 472 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: yeya24 <yb532204897@gmail.com>
albertteoh
reviewed
Mar 24, 2021
| @@ -246,7 +246,8 @@ func (p *processorImp) collectCallMetrics(ilm *pdata.InstrumentationLibraryMetri | |||
|
|
|||
| mCalls := pdata.NewMetric() | |||
| mCalls.SetDataType(pdata.MetricDataTypeIntSum) | |||
| mCalls.SetName("calls") | |||
| mCalls.SetName("calls_total") | |||
There was a problem hiding this comment.
You may need to update the tests to reflect the new name.
| @@ -246,7 +246,8 @@ func (p *processorImp) collectCallMetrics(ilm *pdata.InstrumentationLibraryMetri | |||
|
|
|||
| mCalls := pdata.NewMetric() | |||
| mCalls.SetDataType(pdata.MetricDataTypeIntSum) | |||
| mCalls.SetName("calls") | |||
| mCalls.SetName("calls_total") | |||
| mCalls.IntSum().SetIsMonotonic(true) | |||
There was a problem hiding this comment.
Please add a test for this. I think it should be in verifyConsumeMetricsInput.
Signed-off-by: yeya24 <yb532204897@gmail.com>
albertteoh
reviewed
Mar 24, 2021
|
|
||
| data := m.At(mi).IntSum() | ||
| assert.Equal(t, pdata.AggregationTemporalityCumulative, data.AggregationTemporality()) | ||
| assert.Equal(t, true, data.IsMonotonic()) |
There was a problem hiding this comment.
I would use assert.True.
albertteoh
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
LGTM, thanks @yeya24! Not sure why the load tests are failing as these changes seem quite minimal. Is anyone able to re-run it? or maybe a commit to address my last comment will trigger another run.
tigrannajaryan
approved these changes
Mar 24, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…try#2837) Signed-off-by: yeya24 <yb532204897@gmail.com> As mentioned in the issue, set `IsMonotonic` to true. **Link to tracking Issue:** open-telemetry#2829 **Testing:** Tested manually with prometheusremotewrite exporter and it works well. 
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Add comment linter For now I am excluding - Internal packages - Testbed packages - Constant blocks (since the type docs is usually enough) * Document consumer folder * Document processor folder * Document component folder * Document config folder * Document service folder * Add nosec directive for testbed * Document testutil folder * Document receiver folder * Document exporter folder * Document cmd/schemagen folder * Document translator folder * Document cmd/mdatagen * Document obsreport folder * Remove outdated package config comment * Update .golangci.yml * Update .golangci.yml Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 yb532204897@gmail.com
Description:
As mentioned in the issue, set
IsMonotonicto true.Link to tracking Issue: #2829
Testing: Tested manually with prometheusremotewrite exporter and it works well.
Documentation: