-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResourceAttributes to Splunk Event #2843
Add ResourceAttributes to Splunk Event #2843
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #2843 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.01%
==========================================
Files 464 464
Lines 22799 22814 +15
==========================================
+ Hits 20868 20881 +13
- Misses 1438 1439 +1
- Partials 493 494 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add coverage for the new functionality in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change generally looks good, but please add tests and move the k8s docs change to a separate PR.
6b7a968
to
43372d3
Compare
43372d3
to
c90f326
Compare
**Description:** Fixes open-telemetry#2799 **Testing:** ``` ResourceLog #6 Resource labels: -> k8s.container.name: STRING(loggen) -> k8s.pod.uid: STRING(f7880852-38f9-4158-b37a-41b3436a3b95) -> k8s.namespace.name: STRING(default) -> k8s.pod.startTime: STRING(2021-03-24 23:18:27 +0000 UTC) -> k8s.node.name: STRING(ip-192-168-68-130.us-west-1.compute.internal) -> k8s.pod.labels.hello: STRING(world) -> k8s.pod.labels.app: STRING(appName) -> k8s.pod.annotations.splunk.com/index: STRING(main) -> host.name: STRING(ip-192-168-68-130.us-west-1.compute.internal) -> com.splunk.sourcetype: STRING(loggen) -> com.splunk.index: STRING(main) InstrumentationLibraryLogs #0 InstrumentationLibrary LogRecord #0 Timestamp: 1616627909498109658 Severity: Undefined ShortName: Body: { -> log: STRING(EPS: 99 ) } Attributes: -> k8s.namespace.name: STRING(default) -> k8s.pod.name: STRING(loggen-65dvk) -> run_id: STRING(0) -> k8s.container.name: STRING(loggen) ``` ![image](https://user-images.githubusercontent.com/12387289/112396117-d7f79780-8cbc-11eb-879f-07bb1eb4413a.png)
Description:
Fixes #2799
Testing:
Documentation:
I fixed documentation for k8sprocessor as well.