[exporter/awsemf] Improve summary metric type NaN checks #28894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-aguilar
changed the title
|
Can a codeowner take a look? @Aneurysm9 @shaochengwang @mxiamxia |
Aneurysm9
approved these changes
Nov 15, 2023
Aneurysm9
added
the
ready to merge
TylerHelmuth
approved these changes
Nov 16, 2023
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…try#28894) **Description:** I have observed some behavior on a personal collector deployment where the EMF Exporter is still returning errors for `NaN` json marshalling. This was in a prometheus -> emf exporter metrics pipeline. I could not find the specific NaN value in the metrics when troubleshooting the error. I curled the `/metrics` endpoint and also tried using the logging exporter to try to get more information. I could not find where the NaN value was coming from so I took another look into the unit tests and found some possible code paths in which NaNs could slip though. **Link to tracking Issue:** Original issue open-telemetry#26267 **Testing:** Added more unit tests. The summary unit tests got a slight refactor for two reasons. So I could get ride of the unnecessary typecasting and so that we could more easily test out different combinations of quantile values. I have also added a few more histogram unit tests to just verify that all combinations of NaN values are being checked on their own.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…try#28894) **Description:** I have observed some behavior on a personal collector deployment where the EMF Exporter is still returning errors for `NaN` json marshalling. This was in a prometheus -> emf exporter metrics pipeline. I could not find the specific NaN value in the metrics when troubleshooting the error. I curled the `/metrics` endpoint and also tried using the logging exporter to try to get more information. I could not find where the NaN value was coming from so I took another look into the unit tests and found some possible code paths in which NaNs could slip though. **Link to tracking Issue:** Original issue open-telemetry#26267 **Testing:** Added more unit tests. The summary unit tests got a slight refactor for two reasons. So I could get ride of the unnecessary typecasting and so that we could more easily test out different combinations of quantile values. I have also added a few more histogram unit tests to just verify that all combinations of NaN values are being checked on their own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: I have observed some behavior on a personal collector deployment where the EMF Exporter is still returning errors for
NaNjson marshalling. This was in a prometheus -> emf exporter metrics pipeline.I could not find the specific NaN value in the metrics when troubleshooting the error. I curled the
/metricsendpoint and also tried using the logging exporter to try to get more information. I could not find where the NaN value was coming from so I took another look into the unit tests and found some possible code paths in which NaNs could slip though.Link to tracking Issue: Original issue #26267
Testing: Added more unit tests. The summary unit tests got a slight refactor for two reasons. So I could get ride of the unnecessary typecasting and so that we could more easily test out different combinations of quantile values.
I have also added a few more histogram unit tests to just verify that all combinations of NaN values are being checked on their own.