Add VMScaleSetName field to Azure resource detection processor #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Splunk/SFx exporter will need this to generate an azure_resource_id. Tested on Azure as a standalone VM and in a Scale Set.
Codecov Report
@@ Coverage Diff @@
## main #2890 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 450 450
Lines 22191 22192 +1
=======================================
+ Hits 20327 20328 +1
Misses 1394 1394
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Mar 26, 2021
|
@pmcollins I would suggest to also open a specification issue to ensure that we will define this in the semantic conventions. Reason should not be that Splunk needs it, if only Splunk needs it we should customize somewhere else, but I believe this is important information for more users. |
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…telemetry#2890) The Splunk/SFx exporter will need this to generate an azure_resource_id. Tested on Azure as a standalone VM and in a Scale Set.
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Bumps [github.com/uber/jaeger-lib](https://github.com/uber/jaeger-lib) from 2.4.0+incompatible to 2.4.1+incompatible. - [Release notes](https://github.com/uber/jaeger-lib/releases) - [Changelog](https://github.com/jaegertracing/jaeger-lib/blob/master/CHANGELOG.md) - [Commits](jaegertracing/jaeger-lib@v2.4.0...v2.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Splunk/SFx exporter needs a
VMScaleSetNameto generate theazure_resource_id.Tested on Azure as a standalone VM and in a Scale Set.
README updated.