Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][processor/servicegraph][connector/servicegraph] Assign an exported function to a variable and pass checkapi #29023

Merged

Conversation

sakulali
Copy link
Contributor

@sakulali sakulali commented Nov 8, 2023

Description:
Assign an exported function to a variable and pass checkapi.

Link to tracking Issue:
#26304

Testing:
go run cmd/checkapi/main.go .
go test for servicegraphconnector
go test for servicegraphprocessor

Documentation:

@sakulali sakulali force-pushed the fix-servicegraphprocessor-api branch 4 times, most recently from 9d1d3fc to 4ec9d3a Compare November 14, 2023 16:00
@sakulali sakulali force-pushed the fix-servicegraphprocessor-api branch from 4ec9d3a to ef1a1df Compare November 18, 2023 06:57
…orted function to a variable and pass checkapi

Signed-off-by: sakulali <sakulali@126.com>
@sakulali sakulali force-pushed the fix-servicegraphprocessor-api branch from ef1a1df to 538456a Compare November 24, 2023 17:27
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Nov 29, 2023
@jpkrohling jpkrohling merged commit d826261 into open-telemetry:main Dec 5, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 5, 2023
@sakulali sakulali deleted the fix-servicegraphprocessor-api branch December 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/servicegraph processor/servicegraph Service graph processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants