Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spanmetrics] - Add exemplars to events_total metric #29090

Merged
merged 3 commits into from
Nov 28, 2023
Merged

[Spanmetrics] - Add exemplars to events_total metric #29090

merged 3 commits into from
Nov 28, 2023

Conversation

aishyandapalli
Copy link
Contributor

Description: Add exemplars to events_total metric for spanmetrics

@aishyandapalli aishyandapalli requested review from a team and songy23 November 9, 2023 21:48
songy23
songy23 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pinging code owner @albertteoh for review.

@aishyandapalli
Copy link
Contributor Author

@songy23 Thanks for a quick review. I forgot to add exemplars to events metric in my last PR #28671. So this is a minor enhancement to my last PR

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Nov 13, 2023
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Closed
@TylerHelmuth TylerHelmuth removed the ready to merge Code review completed; ready to merge by maintainers label Nov 16, 2023
@aishyandapalli aishyandapalli force-pushed the exemplars-for-events branch 3 times, most recently from 91bcc4a to 34d56e1 Compare November 20, 2023 17:32
codeboten
codeboten approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my question @aishyandapalli!

@aishyandapalli
Copy link
Contributor Author

@codeboten Thanks for pointing it out :)

@codeboten codeboten merged commit d979075 into open-telemetry:main Nov 28, 2023
76 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh albertteoh approved these changes

@songy23 songy23 songy23 approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@andrzej-stencel andrzej-stencel

Labels
connector/spanmetrics
Projects
None yet
Milestone
v0.90.1
Development

Successfully merging this pull request may close these issues.
6 participants
@aishyandapalli @codeboten @songy23 @albertteoh @TylerHelmuth @andrzej-stencel