exporter/awsprometheusremotewriteexporter: close HTTP body after RoundTrip #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dTrip Ensures that after an HTTP request roundtrip, that signingRoundTripper closes the HTTP body. The contract for net/http.RoundTripper requires that after invoking RoundTrip, that the body must be closed by the caller. Fixes #2953
Codecov Report
@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 464 464
Lines 22860 22861 +1
=======================================
+ Hits 20929 20930 +1
Misses 1438 1438
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Aneurysm9
approved these changes
Apr 2, 2021
bogdandrutu
approved these changes
Apr 2, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…dTrip (open-telemetry#2955) Ensures that after an HTTP request roundtrip, that signingRoundTripper closes the HTTP body. The contract for net/http.RoundTripper requires that after invoking RoundTrip, that the body must be closed by the caller. Fixes open-telemetry#2953
punya
pushed a commit
to punya/opentelemetry-collector-contrib
that referenced
this pull request
Jul 21, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that after an HTTP request roundtrip, that signingRoundTripper closes
the HTTP body. The contract for net/http.RoundTripper requires that
after invoking RoundTrip, that the body must be closed by the caller.
Fixes #2953