Remove translation to HTTP status from OC status. #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.01%
==========================================
Files 464 464
Lines 22799 22797 -2
==========================================
- Hits 20868 20864 -4
- Misses 1438 1439 +1
- Partials 493 494 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@anuraaga this is not going to help OC users, since data are translated OC -> Otel -> Xray and it is important that OC -> Otel does the right thing, otherwise you will not have the right values anyway. |
bogdandrutu
approved these changes
Apr 2, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Update mdatagen to create factories of init instead of new Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Revert New deletion, too many tests use that Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Remove compatibility adapter for OC for mapping HTTP status.
Link to tracking Issue: Fixes #2940
Testing: Unit tests
This was here to give time for OC users to migrate instrumentation - if @kbrockhoff is ok with it, we can delete it now.