[chore]move googlecloudpubsubreceiver to generated lifecycle tests #29940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Dec 17, 2023
| @@ -111,6 +111,9 @@ func (receiver *pubsubReceiver) Start(ctx context.Context, _ component.Host) err | |||
| } | |||
|
|
|||
| func (receiver *pubsubReceiver) Shutdown(_ context.Context) error { | |||
| if receiver.handler == nil { | |||
| return nil | |||
| } | |||
| receiver.logger.Info("Stopping Google Pubsub receiver") | |||
| receiver.handler.CancelNow() | |||
There was a problem hiding this comment.
the check for nil might be better around this call to still have the logs?
There was a problem hiding this comment.
I don’t think we are stopping anything if we didn’t start, so no logging might be best. Codeowners might know best.
There was a problem hiding this comment.
Indeed, the handler is the thing that needs to be stopped and will consume resources. So nothing needs to be logged.
alexvanboxel
approved these changes
Dec 18, 2023
| @@ -111,6 +111,9 @@ func (receiver *pubsubReceiver) Start(ctx context.Context, _ component.Host) err | |||
| } | |||
|
|
|||
| func (receiver *pubsubReceiver) Shutdown(_ context.Context) error { | |||
| if receiver.handler == nil { | |||
| return nil | |||
| } | |||
| receiver.logger.Info("Stopping Google Pubsub receiver") | |||
| receiver.handler.CancelNow() | |||
There was a problem hiding this comment.
Indeed, the handler is the thing that needs to be stopped and will consume resources. So nothing needs to be logged.
|
lgtm |
codeboten
approved these changes
Dec 18, 2023
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27850