Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/[k8scluster/kubeletstats]: Replace package constansts in favor of constants from conventions in core #2996

Merged

Conversation

asuresh4
Copy link
Member

@asuresh4 asuresh4 commented Apr 5, 2021

Description: Use constants from go.opentelemetry.io/collector/translator/conventions

@asuresh4 asuresh4 requested a review from a team April 5, 2021 13:55
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #2996 (d0789d3) into main (665fae9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2996   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         464      464           
  Lines       22798    22798           
=======================================
+ Hits        20870    20871    +1     
+ Misses       1436     1434    -2     
- Partials      492      493    +1     
Flag Coverage Δ
integration 68.96% <ø> (ø)
unit 90.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eceiver/k8sclusterreceiver/collection/collector.go 41.33% <ø> (ø)
receiver/k8sclusterreceiver/collection/nodes.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/collection/pods.go 94.11% <100.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/resource.go 100.00% <100.00%> (ø)
...rometheusexecreceiver/subprocessmanager/manager.go 70.00% <0.00%> (-6.00%) ⬇️
processor/groupbytraceprocessor/event.go 96.77% <0.00%> (+0.80%) ⬆️
receiver/prometheusexecreceiver/receiver.go 88.33% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665fae9...d0789d3. Read the comment docs.

@bogdandrutu bogdandrutu merged commit b003b68 into open-telemetry:main Apr 6, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
This is an "emergency" fix until a better mechanism to allow addition of more zpages is ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants