SFx exporter: Implement summary type #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus's Summary type was previously not implemented. This change ports the SFx Smart Agent's implementation to the SFx exporter. It has been end-to-end tested using a Prometheus server as a source of metrics sent to an SFx backend.
Codecov Report
@@ Coverage Diff @@
## main #2998 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 464 464
Lines 22799 22835 +36
==========================================
+ Hits 20868 20905 +37
+ Misses 1438 1437 -1
Partials 493 493
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
approved these changes
Apr 5, 2021
rmfitzpatrick
approved these changes
Apr 5, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
* Implement summary type Prometheus's Summary type was previously not implemented. This change ports the SFx Smart Agent's implementation to the SFx exporter. It has been end-to-end tested using a Prometheus server as a source of metrics sent to an SFx backend. * Address PR feedback: use minimum precision
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
* Add Filter func to all slices Changed probabilisticsamplerprocessor and filterprocessor to show how we can simplify code. Other places can also be improved. Benchmarks Before: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/processor/filterprocessor cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz BenchmarkStrictFilter BenchmarkStrictFilter-16 2613 433773 ns/op 270314 B/op 7039 allocs/op PASS Process finished with the exit code 0 ``` Benchmarks After: ``` goos: darwin goarch: amd64 pkg: go.opentelemetry.io/collector/processor/filterprocessor cpu: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz BenchmarkStrictFilter BenchmarkStrictFilter-16 42373 26623 ns/op 0 B/op 0 allocs/op PASS Process finished with the exit code 0 ``` Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Change Filter to RemoveIf Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus's Summary type was previously not implemented in the SFx exporter.
This change ports the SFx Smart Agent's implementation to the SFx exporter. It has
been end-to-end tested using a Prometheus server as a source of metrics
sent to an SFx backend.
Addresses #2944