-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection][exporter/datadog] Supress unwanted warning logs coming from EC2 metdata provider #30092
Conversation
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
f9b0073
to
311fdab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little wary of suppressing all SDK logs. What is the impact from this bug, how noisy are these logs?
Edit: I see I misread the original issues, is logging off by default? Is there documentation you can link to so we can verify that?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pinging code owners @dashpole @Aneurysm9
This is already obsolete as it has been fixed in the upstream (https://github.com/aws/aws-sdk-go/releases/tag/v1.49.16) and will be fixed by merging the PR to update AWS dependencies - #30341. Closing this. |
Description:
Some users are seeing unwanted logs that are coming from the
metadaproviders
package, specifically from EC2 provider. This is caused by the fact that the portion of the code in AWS SDK does not respect the default logger configuration (logging is turned off by default for the SDK). To sidestep the issue, the suggested solution in this PR is to introduce simple custom logging function to supress any output from SDK.Link to tracking Issue: #22807
Testing: Manually tested
Documentation: N/A