Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection][exporter/datadog] Supress unwanted warning logs coming from EC2 metdata provider #30092

Closed

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Dec 19, 2023

Description:
Some users are seeing unwanted logs that are coming from the metadaproviders package, specifically from EC2 provider. This is caused by the fact that the portion of the code in AWS SDK does not respect the default logger configuration (logging is turned off by default for the SDK). To sidestep the issue, the suggested solution in this PR is to introduce simple custom logging function to supress any output from SDK.

Link to tracking Issue: #22807

Testing: Manually tested

Documentation: N/A

Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
Copy link
Contributor

@bryan-aguilar bryan-aguilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little wary of suppressing all SDK logs. What is the impact from this bug, how noisy are these logs?

Edit: I see I misread the original issues, is logging off by default? Is there documentation you can link to so we can verify that?

@songy23 songy23 added exporter/datadog Datadog components processor/resourcedetection Resource detection processor labels Dec 19, 2023
@matej-g
Copy link
Contributor Author

matej-g commented Dec 20, 2023

I'm a little wary of suppressing all SDK logs. What is the impact from this bug, how noisy are these logs?

Edit: I see I misread the original issues, is logging off by default? Is there documentation you can link to so we can verify that?

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pinging code owners @dashpole @Aneurysm9

@matej-g
Copy link
Contributor Author

matej-g commented Jan 9, 2024

This is already obsolete as it has been fixed in the upstream (https://github.com/aws/aws-sdk-go/releases/tag/v1.49.16) and will be fixed by merging the PR to update AWS dependencies - #30341. Closing this.

@matej-g matej-g closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants