[exporter/prometheusremotewrite] Fix: Validate context is canceled during retries #30308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otewriteexporter Validates that the context is canceled in order to avoid unnecessary retries in the prometheus remote write exporter Signed-off-by: Raphael Silva <rapphil@gmail.com>
Signed-off-by: Raphael Silva <rapphil@gmail.com>
rapphil
force-pushed
the
rapphil-fix-prw-context-retries
branch
from
38640c2
to
87d4b49
Compare
Signed-off-by: Raphael Silva <rapphil@gmail.com>
bryan-aguilar
approved these changes
Jan 6, 2024
Signed-off-by: Raphael Silva <rapphil@gmail.com>
rapphil
changed the title
Aneurysm9
approved these changes
Jan 8, 2024
Aneurysm9
added
the
ready to merge
|
This needs a rebase before being able to merge |
bryan-aguilar
removed
the
ready to merge
bryan-aguilar
added
the
ready to merge
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…ring retries (open-telemetry#30308) **Description:** Validates that the context is canceled in order to avoid unnecessary retries in the prometheus remote write exporter **Link to tracking Issue:** No tracking issue. **Testing:** Unit tests were added. --------- Signed-off-by: Raphael Silva <rapphil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Validates that the context is canceled in order to avoid unnecessary retries in the prometheus remote write exporter
Link to tracking Issue: No tracking issue.
Testing: Unit tests were added.