[processor/tailsampling] Add metric for sampled/not sampled spans #30485
Conversation
|
That's my first time reading the collector codebase, I'm not sure how to build and verify the changes work as I expect 😅 I've tried looking for tests that verify metric values but couldn't find any. Or at least I looked at the wrong place. Do you think they should be added now? |
|
Sorry for the ping @dashpole @jpkrohling, it's a small PR 😬 Is there something else I should be doing to get the PR reviewed? |
There was a problem hiding this comment.
Sorry for the delay in reviewing this! Given that there might be performance implications in counting the number of spans in a batch, and that this is enabled by default, I would be more comfortable if this was placed behind a feature flag, at least for a couple of versions. Other than that, it looks good to me.
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
ArthurSens
force-pushed
the
sampled-spans-metric
branch
from
8597f84
to
51b4097
Compare
|
Rebase done! Should be ready to merge :) |
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
…en-telemetry#30485) **Description:** <Describe what has changed.> Add metrics to measure sampled/not sampled spans. **Link to tracking Issue:** Fixes open-telemetry#30482 **Testing:** <Describe what testing was performed and which tests were added.> None **Documentation:** <Describe the documentation added.> None --------- Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Description:
Add metrics to measure sampled/not sampled spans.
Link to tracking Issue:
Fixes #30482
Testing:
None
Documentation:
None