chore: fix handling of metrics with created suffix #30698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmichalek132
requested review from
evan-bradley,
atoulme and
tigrannajaryan
as code owners
dashpole
reviewed
Jan 22, 2024
|
Hmm this broke one of the existing unit tests, I'll look into why tomorrow. |
|
|
jmichalek132
force-pushed
the
jm-fix-handling-of-metrics-with-created-suffix
branch
from
7c57d83
to
d5f034c
Compare
jmichalek132
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
albertteoh,
dineshg13,
mapno,
marctc,
mwear,
pmcollins and
portertech
jmichalek132
deleted the
jm-fix-handling-of-metrics-with-created-suffix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As discussed in the OTEL Prometheus working group, to fix this case we check If the metricfamily (which we get from the metadata) name +
_created== the series name match. Then we treat it as created timestamp.Link to tracking Issue: #30309
Testing: Reproduced based on the detailed provided in the issue, added a test case covering the case.
Documentation: