[processor/servicegraphprocessor] Add Configurable Database Name Attribute #30726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@hadesy, once this is rebased, I'll do a final review and merge this. |
# Conflicts: # processor/servicegraphprocessor/README.md # processor/servicegraphprocessor/config_test.go # processor/servicegraphprocessor/testdata/service-graph-config.yaml
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
…e' into add-configurable-dbname-attribute
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
I've completed the rebase as requested. Everything should be in order now for the final review. Please let me know if there are any additional adjustments or checks needed from my side. Thank you for your guidance and support. Looking forward to the merge! |
Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jpkrohling
approved these changes
Mar 4, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ibute (open-telemetry#30726) **Description:** This PR introduces a new configuration option, 'database_name_attribute', in the ServiceGraphProcessor's Config struct. The purpose of this change is to allow users to specify a custom attribute name for identifying the database name in span attributes. This enhancement increases the flexibility of the servicegraphprocessor and allows for better customization in diverse deployment environments. The default value is set to 'db.name' to ensure backward compatibility. **Documentation:** - Updated the README.md to include the new configuration option, with an explanation and the default setting. - Added comments in the code where relevant to clarify the use and default value of the 'database_name_attribute'. --------- Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…ibute (open-telemetry#30726) **Description:** This PR introduces a new configuration option, 'database_name_attribute', in the ServiceGraphProcessor's Config struct. The purpose of this change is to allow users to specify a custom attribute name for identifying the database name in span attributes. This enhancement increases the flexibility of the servicegraphprocessor and allows for better customization in diverse deployment environments. The default value is set to 'db.name' to ensure backward compatibility. **Documentation:** - Updated the README.md to include the new configuration option, with an explanation and the default setting. - Added comments in the code where relevant to clarify the use and default value of the 'database_name_attribute'. --------- Signed-off-by: hadesy <6346047+hadesy@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new configuration option, 'database_name_attribute', in the ServiceGraphProcessor's Config struct. The purpose of this change is to allow users to specify a custom attribute name for identifying the database name in span attributes. This enhancement increases the flexibility of the servicegraphprocessor and allows for better customization in diverse deployment environments. The default value is set to 'db.name' to ensure backward compatibility.
Documentation: