-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal localhostgate package #30774
Add internal localhostgate package #30774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a changelog or a README for the feature gate?
I was thinking we can do a changelog item once we actually use it in individual components, listing all the components we are using this in. I can also add the changelog item now with an empty list of components if you think that's better |
Yes I think it makes sense to start a list now and expand it when changes are made to each component. |
I'm wondering if there's a good way to enforce keeping this up to date It could be a CI check that simply fails whenever a user changes the contents of these files, warning the user that Otherwise we could add a CI action that simply compared file contents and fails when they don't match. This would be a bit more involved and would fail in unrelated PRs, which would be confusing. I don't want to make it too complicated but speaking from experience, a comment at the top of a file is pretty easy to miss. |
@crobert-1 I don't expect much to change here, but it makes sense to have something like this. I filed #30793 to do this, but I would like to do it separately (I want to unblock PRs that start to use this feature gate in components) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs make tidy
**Description:** Follow up to open-telemetry/opentelemetry-collector/pull/8622 **Link to tracking Issue:** First step of open-telemetry#30702
Description:
Follow up to open-telemetry/opentelemetry-collector/pull/8622
Link to tracking Issue: First step of #30702