-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/awsemf] Drop redundant arg from addToGroupedMetric #30813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjunmahishi
requested review from
Aneurysm9 and
bryan-aguilar
as code owners
January 28, 2024 11:14
|
arjunmahishi
force-pushed
the
awsemf-small-fix
branch
from
February 3, 2024 11:08
ab5a21e
to
cbf1715
Compare
The addToGroupedMetric previously took logger as well as the config as arguments. However, the logger is already available as a field in the config so it is redundant to pass it separately. This commit removes the logger argument.
arjunmahishi
force-pushed
the
awsemf-small-fix
branch
from
February 5, 2024 14:49
cbf1715
to
87c34a8
Compare
bryan-aguilar
added
the
Skip Changelog
PRs that do not require a CHANGELOG.md entry
label
Feb 5, 2024
bryan-aguilar
approved these changes
Feb 5, 2024
bryan-aguilar
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Feb 5, 2024
foadnh
added a commit
to Canva/opentelemetry-collector-contrib
that referenced
this pull request
Mar 6, 2024
* [chore] Remove use of deprecated ReportFatalError (#31146) Fixes #30586 * fix(deps): update module github.com/aws/aws-sdk-go to v1.50.14 (#31057) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.50.7` -> `v1.50.14` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2faws%2faws-sdk-go/v1.50.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2faws%2faws-sdk-go/v1.50.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2faws%2faws-sdk-go/v1.50.7/v1.50.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2faws%2faws-sdk-go/v1.50.7/v1.50.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.50.14`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15014-2024-02-08) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.13...v1.50.14) \=== ##### Service Client Updates - `service/codepipeline`: Updates service API and documentation - Add ability to execute pipelines with new parallel & queued execution modes and add support for triggers with filtering on branches and file paths. - `service/quicksight`: Updates service API and documentation - General Interactions for Visuals; Waterfall Chart Color Configuration; Documentation Update - `service/workspaces`: Updates service API and documentation - This release introduces User-Decoupling feature. This feature allows Workspaces Core customers to provision workspaces without providing users. CreateWorkspaces and DescribeWorkspaces APIs will now take a new optional parameter "WorkspaceName". ### [`v1.50.13`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15013-2024-02-07) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.12...v1.50.13) \=== ##### Service Client Updates - `service/datasync`: Updates service API and documentation - `service/models.lex.v2`: Updates service API, documentation, and paginators - `service/redshift`: Updates service API, documentation, and paginators - LisRecommendations API to fetch Amazon Redshift Advisor recommendations. ### [`v1.50.12`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15012-2024-02-06) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.11...v1.50.12) \=== ##### Service Client Updates - `service/appsync`: Updates service API and documentation - `service/ecs`: Updates service documentation - This release is a documentation only update to address customer issues. - `service/es`: Updates service API and documentation - This release adds clear visibility to the customers on the changes that they make on the domain. - `service/logs`: Updates service API and documentation - This release adds a new field, logGroupArn, to the response of the logs:DescribeLogGroups action. - `service/opensearch`: Updates service API and documentation - `service/wafv2`: Updates service API and documentation ### [`v1.50.11`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15011-2024-02-05) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.10...v1.50.11) \=== ##### Service Client Updates - `service/glue`: Updates service API and documentation - Introduce Catalog Encryption Role within Glue Data Catalog Settings. Introduce SASL/PLAIN as an authentication method for Glue Kafka connections - `service/workspaces`: Updates service documentation - Added definitions of various WorkSpace states ### [`v1.50.10`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v15010-2024-02-02) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.9...v1.50.10) \=== ##### Service Client Updates - `service/dynamodb`: Updates service API, documentation, waiters, paginators, and examples - Any number of users can execute up to 50 concurrent restores (any type of restore) in a given account. - `service/sagemaker`: Updates service API and documentation - Amazon SageMaker Canvas adds GenerativeAiSettings support for CanvasAppSettings. ### [`v1.50.9`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1509-2024-02-01) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.8...v1.50.9) \=== ##### Service Client Updates - `service/cognito-idp`: Updates service API and documentation - `service/ivs`: Updates service API, documentation, and paginators - `service/managedblockchain-query`: Updates service API and documentation - `service/mediaconvert`: Updates service API and documentation - This release includes support for broadcast-mixed audio description tracks. ### [`v1.50.8`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v1508-2024-01-31) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.50.7...v1.50.8) \=== ##### Service Client Updates - `service/cloudformation`: Updates service API, documentation, paginators, and examples - CloudFormation IaC generator allows you to scan existing resources in your account and select resources to generate a template for a new or existing CloudFormation stack. - `service/elasticloadbalancingv2`: Updates service API and documentation - `service/glue`: Updates service API and documentation - Update page size limits for GetJobRuns and GetTriggers APIs. - `service/ssm`: Updates service API and documentation - This release adds an optional Duration parameter to StateManager Associations. This allows customers to specify how long an apply-only-on-cron association execution should run. Once the specified Duration is out all the ongoing cancellable commands or automations are cancelled. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> * Fix comment missing a dash for argument name (#31160) * fix(deps): update module github.com/azure/azure-sdk-for-go/sdk/azcore to v1.9.2 (#31080) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://togithub.com/Azure/azure-sdk-for-go) | `v1.9.1` -> `v1.9.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fAzure%2fazure-sdk-for-go%2fsdk%2fazcore/v1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fAzure%2fazure-sdk-for-go%2fsdk%2fazcore/v1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fAzure%2fazure-sdk-for-go%2fsdk%2fazcore/v1.9.1/v1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fAzure%2fazure-sdk-for-go%2fsdk%2fazcore/v1.9.1/v1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> * fix(deps): update module github.com/knadh/koanf/v2 to v2.1.0 (#31061) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/knadh/koanf/v2](https://togithub.com/knadh/koanf) | `v2.0.2` -> `v2.1.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fknadh%2fkoanf%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fknadh%2fkoanf%2fv2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fknadh%2fkoanf%2fv2/v2.0.2/v2.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>knadh/koanf (github.com/knadh/koanf/v2)</summary> ### [`v2.1.0`](https://togithub.com/knadh/koanf/releases/tag/v2.1.0) [Compare Source](https://togithub.com/knadh/koanf/compare/v2.0.2...v2.1.0) ### Important [https://github.com/mitchellh/mapstructure/issues/349#issuecomment-1860372162](https://togithub.com/mitchellh/mapstructure/issues/349#issuecomment-1860372162) is discontinued and koanf has switched to using the fork `github.com/go-viper/mapstructure/v2`. If you are referencing the mapstructure lib in your code (custom DecoderConfig), you have to switch the paths to the above forked version of koanf. `github.com/mitchellh/mapstructure` => `github.com/go-viper/mapstructure/v2` #### What's Changed - fix: retract v2.0.2 by [@​rhnvrm](https://togithub.com/rhnvrm) in [https://github.com/knadh/koanf/pull/270](https://togithub.com/knadh/koanf/pull/270) **Full Changelog**: https://github.com/knadh/koanf/compare/v2.0.2...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com> * [chore][exporter/coralogixexporter] Enable goleak check (#30803) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This enables the `goleak` check on all tests in this package, to ensure the exporter isn't leaking goroutines. The only updates here are tests, as some were missing necessary `shutdown` calls. I also updated some variable naming to match types, such as `le` for a logs exporter instead of `me`. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All tests are passing, including added `goleak` check. --------- Co-authored-by: Alex Boten <aboten@lightstep.com> * [chore] Add --no-print-directory to recursive Makefile invocations (#31164) **Description:** Add [`--no-print-directory`](https://www.gnu.org/software/make/manual/html_node/_002dw-Option.html) to Makefile invocations. The information is already there since the `make -C` invocation is printed, and it makes the output much longer. Before: ``` Running target 'test' in module 'extension/encoding' as part of group 'extension' make -C extension/encoding test make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/encoding' # Actual test output goes here # ... make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/encoding' Running target 'test' in module 'extension/encoding/jaegerencodingextension' as part of group 'extension' # ... ``` After: ``` Running target 'test' in module 'extension/encoding' as part of group 'extension' make --no-print-directory -C extension/encoding test # Actual test output goes here # ... Running target 'test' in module 'extension/encoding/jaegerencodingextension' as part of group 'extension' # ... ``` * [chore] Add build-and-test, build-and-test-windows, changelog and telemetrygen to merge group (#31162) **Description:** Adds CI jobs that have required jobs to merge group. Needed for the merge queue requested on open-telemetry/community/issues/1936 **Link to tracking Issue:** #30880 * [exporter/awsemf] Drop redundant arg from addToGroupedMetric (#30813) **Description:** <Describe what has changed.> The `addToGroupedMetric` previously took the logger as well as the config as arguments. However, the logger is already available as a field in the config so it is redundant to pass it separately. This commit removes the logger argument. **Testing:** The affected unit tests were updated * [pkg/golden]: Add option to skip normalizing timestamps when writing metrics (#31161) **Description:** <Describe what has changed.> * Adds a new WriteMetricsOption type, which can be specified when calling WriteMetrics * Adds a WriteMetricsOption for skipping the timestamp normalization step. **Link to tracking Issue:** Closes #30919 **Testing:** <Describe what testing was performed and which tests were added.> * Unit test added for new functionality * [processor/logstransform]: Fix shutdown ordering leading to panic (#31153) **Description:** * re-order how we start and stop the different goroutines in the logstransform processor The idea is, we start the goroutines from the consumer end up to the producer end, then shut them down in reverse order. This is similar to how stanza itself starts and stops it's operators, for instance (starts in reverse topological order, stops in topological order). **Link to tracking Issue:** Closes #31139 **Testing:** Added a unit test. This unit test regularly fails on the code on main (panics), but works consistently on this branch (I've run it 100 times to makes sure). ```sh go test -timeout 10m -count=100 -v -run '^TestProcessorShutdownWithSlowOperator$' github.com/open-telemetry/opentelemetry-collector-contrib/processor/logstransformprocessor ``` * [receiver/filelog] Add multiline example (#31124) **Description:** This PR adds a more detailed example on how to use `multiline` setting on `filelog` receiver. From my search I wasn't able to find any examples around so I think it would be nice to have something for users that are willing to quickly get on-boarded on log collection. **Link to tracking Issue:** <Issue number if applicable> - **Testing:** <Describe what testing was performed and which tests were added.> - **Documentation:** <Describe the documentation added.> . Signed-off-by: ChrsMark <chrismarkou92@gmail.com> * Break storage extensions into dedicated modules (#31040) This creates dedicated modules for `filestorage` and `dbstorage` extensions. It leaves the `storage` module in place to contain the `storage/storagetest` package. * [chore] remove tests checking nil consumer as we're handling nil checks in builder (#31172) See https://github.com/open-telemetry/opentelemetry-collector/pull/9526 for context - we are removing the possibility that the next consumer passed in is nil in the pipelines builders. * [exporter/logicmonitorexporter] Fix leaking goroutines on shutdown (#31150) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The [logicmonitor dependency](https://github.com/logicmonitor/lm-data-sdk-go) that handles exporting data relies on the context being cancelled to shutdown its running goroutines ([traces reference](https://github.com/logicmonitor/lm-data-sdk-go/blob/93e0505a0dce33bfd874c67bdf85e3845126cc3d/pkg/ratelimiter/traces.go#L113), [logs reference](https://github.com/logicmonitor/lm-data-sdk-go/blob/93e0505a0dce33bfd874c67bdf85e3845126cc3d/pkg/ratelimiter/logs.go#L70)). The exporter has now been updated to properly cancel the passed context to fix leaking goroutines on shutdown. This change also enables `goleak` to check for leaking goroutines in the logicmonitor exporter package. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as added `goleak` check. * [exporter/datadog][connector/datadog] Add trace config peer_tags (#31158) This config mirrors https://github.com/DataDog/datadog-agent/blob/64e39b562df7ad3f40880ba603f70469f6659f17/pkg/config/config_template.yaml#L1532. * [chore] add make checks target (#31149) This will allow us to run all the "checks" locally. It's not fast, but it at least saves me from waiting for CI to tell me i messed up :D Signed-off-by: Alex Boten <aboten@lightstep.com> * [chore][pkg/stanza] Various code cleanup (#30784) This PR contains a few minor code cleanups and test speed optimizations. * [chore] Define code ownership in slightly more open terms (#31117) See #31115 Our existing definition and process for code ownership are quite good but this PR suggests a few minor tweaks. - Add triaging as a code owner responsibility. Since this is arguably the easiest thing a code owner can do, we should highlight that it is helpful work. - Move "The existing Code Owners are actively looking for more help" to the top of the list of reasons why additional code owners may be needed, since this is most often the case. - Add a note about code ownership not needing to be a full time job. The goal is not to lower the bar in terms of quality, but to encourage lower bandwidth contributors not to self-select out. * [extension/storage/filestorage] Ensure fsync is turned on after compaction (#31185) **Description:** Fsync was added to filestorage, but during compaction the database is re-opened which doesn't carry over the fsync configuration but always sets it to false(!) **Link to tracking Issue:** https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/20266 **Testing:** - **Documentation:** - * [chore][processor/groupbyattrsprocess] Fix typos in README (#31168) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> `Instumentation` -> `Instrumentation`. Also had to remove a dead link. * [chore][extension/jaegarremotesampling] Enable goleak check (#31155) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This enables `goleak` checks on the `jaegarremotesampling` extension, to help ensure no goroutines are leaking. This is a test only change, a couple close/stop calls were missing. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing, as well as added goleak check. * [chore] Try bumping ruby to bif dep/rpm tests (#31189) Attempt to fix https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7876454427/job/21490717383 * [exporter/f5] deprecate exporter (#31186) After discussion with @lquerel, he mentioned the component is no longer maintained at F5. Marking it as deprecated. --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * [all] bump minimum go version to 1.21 (#31109) Fixes #31105 --------- Signed-off-by: Alex Boten <aboten@lightstep.com> * [receiver/opencensusreceiver] Fix memory leak on shutdown (#31152) The opencensus receiver opens a few servers on `Start`, each of which use the context's cancel to signal shutdown. Without cancelling the context, the goroutines were being leaked. This change properly cancels the context and shutdowns the receiver's servers. This also enables `goleak` checks on the opencensus receiver and exporter. I realize the exporter is not technically related here, but its tests were what alerted me to the leak in the receiver. The `TestSendTraces` and `TestSendMetrics` tests in the exporter were starting opencensus receivers and exporters, and failing on leaks. The change here is test-only for the exporter, and a bug fix for the receiver. #30438 All existing tests are passing, as well as added `goleak` checks. * [chore] use generated tests for zipkinencodingextension (#31148) Relates to #27849 Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [chore][pkg/stanza] Add file disambiguation tests (#31171) Closes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/20850 Closes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/20851 Also enhances the `emittest` package, though it remains internal. * [chore][extension/bearertokenauth] Enable goleak check (#31154) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This adds `goleak` checks on the `bearertokenauthextension` extension to help ensure no goroutines are being leaked. This is a test only change. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> All existing tests are passing as well as added `goleak` check. * [feat][exporter/loadbalancingexporter] add benchmarks for metrics and traces consume (#30915) **Description:** According to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30141#pullrequestreview-1843647046 PR adds benchmarks for functions: - `mergeTraces` - `mergeMetrics` - `consumeTraces` - `consumeMetrics` * [exporter/syslog] Add support for octet counting in the syslog exporter (#31014) **Description:** <Describe what has changed.> This introduces a new configuration `enable_octet_counting` which matches the same configuration on the syslog receiver side, and if enabled will append the length of the message to the start of the message. **Link to tracking Issue:** #31013 **Testing:** Added tests alongside the existing syslog exporter tests **Documentation:** Updated the README with the new config option Signed-off-by: sinkingpoint <colin@quirl.co.nz> * [chore] set fixed Go patch version to prevent CI failures (#31214) Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31213 * Update module github.com/jaegertracing/jaeger to v1.54.0 (#31217) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/jaegertracing/jaeger](https://togithub.com/jaegertracing/jaeger) | `v1.53.0` -> `v1.54.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fjaegertracing%2fjaeger/v1.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fjaegertracing%2fjaeger/v1.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fjaegertracing%2fjaeger/v1.53.0/v1.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fjaegertracing%2fjaeger/v1.53.0/v1.54.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jaegertracing/jaeger (github.com/jaegertracing/jaeger)</summary> ### [`v1.54.0`](https://togithub.com/jaegertracing/jaeger/releases/tag/v1.54.0) [Compare Source](https://togithub.com/jaegertracing/jaeger/compare/v1.53.0...v1.54.0) ##### Backend Changes ##### ⛔ Breaking Changes: - Remove remnants of internal otlp types ([@​yurishkuro](https://togithub.com/yurishkuro) in [#​5107](https://togithub.com/jaegertracing/jaeger/pull/5107)) - Use official otlp types in api_v3 and avoid triple-marshaling ([@​yurishkuro](https://togithub.com/yurishkuro) in [#​5098](https://togithub.com/jaegertracing/jaeger/pull/5098)) ##### ✨ New Features: - \[jaeger-v2] add support for badger ([@​akagami-harsh](https://togithub.com/akagami-harsh) in [#​5112](https://togithub.com/jaegertracing/jaeger/pull/5112)) ##### 🐞 Bug fixes, Minor Improvements: - \[jaeger-v2] streamline storage initialization ([@​yurishkuro](https://togithub.com/yurishkuro) in \[[#​5171](https://togithub.com/jaegertracing/jaeger/issues/5171)]\(https://github.com/jaegertracing/jaeger/ pull/5171)) - Replace security self-assesment with one from cncf/tag-security ([@​jkowall](https://togithub.com/jkowall) in \[[#​5142](https://togithub.com/jaegertracing/jaeger/issues/5142)]\(https://github.com/jaegertra cing/jaeger/pull/5142)) - Avoid changing a correct order of span references ([@​sherwoodwang](https://togithub.com/sherwoodwang) in \[[#​5121](https://togithub.com/jaegertracing/jaeger/issues/5121)]\(https://github.com/jaegertracing /jaeger/pull/5121)) ##### 👷 CI Improvements: - Remove test summary reports ([@​albertteoh](https://togithub.com/albertteoh) in [#​5126](https://togithub.com/jaegertracing/jaeger/pull/5126)) ##### UI Changes - UI pinned to version [1.38.0](https://togithub.com/jaegertracing/jaeger-ui/blob/main/CHANGELOG.md#v1380-2024-02-06). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update module github.com/IBM/sarama to v1.42.2 (#31195) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/IBM/sarama](https://togithub.com/IBM/sarama) | `v1.42.1` -> `v1.42.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fIBM%2fsarama/v1.42.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fIBM%2fsarama/v1.42.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fIBM%2fsarama/v1.42.1/v1.42.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fIBM%2fsarama/v1.42.1/v1.42.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>IBM/sarama (github.com/IBM/sarama)</summary> ### [`v1.42.2`](https://togithub.com/IBM/sarama/releases/tag/v1.42.2): Version 1.42.2 (2024-02-09) [Compare Source](https://togithub.com/IBM/sarama/compare/v1.42.1...v1.42.2) <!-- Release notes generated using configuration in .github/release.yaml at main --> #### What's Changed ⚠️ The go.mod directive has been bumped to 1.18 as the minimum version of Go required for the module. This was necessary to continue to receive updates from some of the third party dependencies that Sarama makes use of for compression. ##### :tada: New Features / Improvements - feat: update go directive to 1.18 by [@​dnwe](https://togithub.com/dnwe) in [https://github.com/IBM/sarama/pull/2713](https://togithub.com/IBM/sarama/pull/2713) - feat: return KError instead of errors in AlterConfigs and DescribeConfig by [@​zhuliquan](https://togithub.com/zhuliquan) in [https://github.com/IBM/sarama/pull/2472](https://togithub.com/IBM/sarama/pull/2472) ##### :bug: Fixes - fix: don't waste time for backoff on member id required error by [@​lzakharov](https://togithub.com/lzakharov) in [https://github.com/IBM/sarama/pull/2759](https://togithub.com/IBM/sarama/pull/2759) - fix: prevent ConsumerGroup.Close infinitely locking by [@​maqdev](https://togithub.com/maqdev) in [https://github.com/IBM/sarama/pull/2717](https://togithub.com/IBM/sarama/pull/2717) ##### :package: Dependency updates - chore(deps): bump golang.org/x/net from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2716](https://togithub.com/IBM/sarama/pull/2716) - chore(deps): bump golang.org/x/sync to v0.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2718](https://togithub.com/IBM/sarama/pull/2718) - chore(deps): bump github.com/pierrec/lz4/v4 from 4.1.18 to 4.1.19 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2739](https://togithub.com/IBM/sarama/pull/2739) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2748](https://togithub.com/IBM/sarama/pull/2748) - chore(deps): bump the golang-org-x group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2734](https://togithub.com/IBM/sarama/pull/2734) - chore(deps): bump the golang-org-x group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2764](https://togithub.com/IBM/sarama/pull/2764) - chore(deps): bump github.com/pierrec/lz4/v4 from 4.1.19 to 4.1.21 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2763](https://togithub.com/IBM/sarama/pull/2763) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/exactly_once by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2749](https://togithub.com/IBM/sarama/pull/2749) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/consumergroup by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2750](https://togithub.com/IBM/sarama/pull/2750) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/sasl_scram_client by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2751](https://togithub.com/IBM/sarama/pull/2751) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/interceptors by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2752](https://togithub.com/IBM/sarama/pull/2752) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/http_server by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2753](https://togithub.com/IBM/sarama/pull/2753) - chore(deps): bump github.com/eapache/go-resiliency from 1.4.0 to 1.5.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2745](https://togithub.com/IBM/sarama/pull/2745) - chore(deps): bump golang.org/x/crypto from 0.15.0 to 0.17.0 in /examples/txn_producer by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2754](https://togithub.com/IBM/sarama/pull/2754) - chore(deps): bump go.opentelemetry.io/otel/sdk from 1.19.0 to 1.22.0 in /examples/interceptors by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2767](https://togithub.com/IBM/sarama/pull/2767) - chore(deps): bump the golang-org-x group with 1 update by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2793](https://togithub.com/IBM/sarama/pull/2793) - chore(deps): bump go.opentelemetry.io/otel/exporters/stdout/stdoutmetric from 0.42.0 to 1.23.1 in /examples/interceptors by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/IBM/sarama/pull/2792](https://togithub.com/IBM/sarama/pull/2792) ##### :wrench: Maintenance - fix(examples): housekeeping of code and deps by [@​dnwe](https://togithub.com/dnwe) in [https://github.com/IBM/sarama/pull/2720](https://togithub.com/IBM/sarama/pull/2720) ##### :heavy_plus_sign: Other Changes - fix(test): retry MockBroker Listen for EADDRINUSE by [@​dnwe](https://togithub.com/dnwe) in [https://github.com/IBM/sarama/pull/2721](https://togithub.com/IBM/sarama/pull/2721) #### New Contributors - [@​maqdev](https://togithub.com/maqdev) made their first contribution in [https://github.com/IBM/sarama/pull/2717](https://togithub.com/IBM/sarama/pull/2717) - [@​zhuliquan](https://togithub.com/zhuliquan) made their first contribution in [https://github.com/IBM/sarama/pull/2472](https://togithub.com/IBM/sarama/pull/2472) **Full Changelog**: https://github.com/IBM/sarama/compare/v1.42.1...v1.42.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * [chore] Try adding merge_group to more jobs (#31228) **Description:** The merge queue isn't working. Maybe it wants more jobs to be included? **Link to tracking Issue:** <Issue number if applicable> https://github.com/open-telemetry/community/issues/1936 * Update module github.com/docker/docker to v24.0.9+incompatible (#31059) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/docker/docker](https://togithub.com/docker/docker) | `v24.0.8+incompatible` -> `v24.0.9+incompatible` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fdocker%2fdocker/v24.0.9+incompatible?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fdocker%2fdocker/v24.0.9+incompatible?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fdocker%2fdocker/v24.0.8+incompatible/v24.0.9+incompatible?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fdocker%2fdocker/v24.0.8+incompatible/v24.0.9+incompatible?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>docker/docker (github.com/docker/docker)</summary> ### [`v24.0.9+incompatible`](https://togithub.com/docker/docker/compare/v24.0.8...v24.0.9) [Compare Source](https://togithub.com/docker/docker/compare/v24.0.8...v24.0.9) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update module github.com/vmware/govmomi to v0.35.0 (#31230) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/vmware/govmomi](https://togithub.com/vmware/govmomi) | `v0.34.2` -> `v0.35.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvmware%2fgovmomi/v0.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvmware%2fgovmomi/v0.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvmware%2fgovmomi/v0.34.2/v0.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvmware%2fgovmomi/v0.34.2/v0.35.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vmware/govmomi (github.com/vmware/govmomi)</summary> ### [`v0.35.0`](https://togithub.com/vmware/govmomi/releases/tag/v0.35.0) [Compare Source](https://togithub.com/vmware/govmomi/compare/v0.34.2...v0.35.0) <a name="v0.35.0"></a> #### [Release v0.35.0](https://togithub.com/vmware/govmomi/compare/v0.34.2...v0.35.0) > Release Date: 2024-02-12 ##### 💫 API Changes - \[[`8e17e4c`](https://togithub.com/vmware/govmomi/commit/8e17e4c1)] Sim vm config.changeVersion & config.modified - \[[`95aa257`](https://togithub.com/vmware/govmomi/commit/95aa2571)] WaitForUpdatesEx & DestroyPropertyFilter ##### 💫 `govc` (CLI) - \[[`9ddfc53`](https://togithub.com/vmware/govmomi/commit/9ddfc534)] json tag camelCase fixes ([#​3007](https://togithub.com/vmware/govmomi/issues/3007)) ([#​3247](https://togithub.com/vmware/govmomi/issues/3247)) ([#​3318](https://togithub.com/vmware/govmomi/issues/3318)) ##### 💫 `vcsim` (Simulator) - \[[`557d265`](https://togithub.com/vmware/govmomi/commit/557d2654)] Fix -method-delay option to update task states ([#​3323](https://togithub.com/vmware/govmomi/issues/3323)) ##### 📃 Documentation - \[[`2d1b52f`](https://togithub.com/vmware/govmomi/commit/2d1b52ff)] update release doc ([#​3284](https://togithub.com/vmware/govmomi/issues/3284)) ##### 🧹 Chore - \[[`d7c0094`](https://togithub.com/vmware/govmomi/commit/d7c0094a)] Update version.go for v0.35.0 - \[[`69785ff`](https://togithub.com/vmware/govmomi/commit/69785ff0)] update CONTRIBUTORS ##### ⚠️ BREAKING json tag camelCase fixes \[[`9ddfc53`](https://togithub.com/vmware/govmomi/commit/9ddfc534)]: follow up to json tags missed in PR [#​3007](https://togithub.com/vmware/govmomi/issues/3007) and PR [#​3247](https://togithub.com/vmware/govmomi/issues/3247) WaitForUpdatesEx & DestroyPropertyFilter \[[`95aa257`](https://togithub.com/vmware/govmomi/commit/95aa2571)]: The semantics around the helper functions in the property package have changed. Please review any code that calls this package to ensure it is compatible with the new behaviors. ##### 📖 Commits - \[[`d7c0094`](https://togithub.com/vmware/govmomi/commit/d7c0094a)] chore: Update version.go for v0.35.0 - \[[`2d1b52f`](https://togithub.com/vmware/govmomi/commit/2d1b52ff)] docs: update release doc ([#​3284](https://togithub.com/vmware/govmomi/issues/3284)) - \[[`69785ff`](https://togithub.com/vmware/govmomi/commit/69785ff0)] chore: update CONTRIBUTORS - \[[`9ddfc53`](https://togithub.com/vmware/govmomi/commit/9ddfc534)] govc: json tag camelCase fixes ([#​3007](https://togithub.com/vmware/govmomi/issues/3007)) ([#​3247](https://togithub.com/vmware/govmomi/issues/3247)) ([#​3318](https://togithub.com/vmware/govmomi/issues/3318)) - \[[`b137a5d`](https://togithub.com/vmware/govmomi/commit/b137a5d2)] Add "AggregatedSnapshotCapacityInMb" to cnstype. - \[[`b948e3c`](https://togithub.com/vmware/govmomi/commit/b948e3cb)] add -json to snapshot.tree - \[[`dabec6c`](https://togithub.com/vmware/govmomi/commit/dabec6cd)] build(deps): bump nokogiri from 1.14.3 to 1.16.2 in /gen - \[[`8e17e4c`](https://togithub.com/vmware/govmomi/commit/8e17e4c1)] api: Sim vm config.changeVersion & config.modified - \[[`d55cf6e`](https://togithub.com/vmware/govmomi/commit/d55cf6e4)] build(deps): bump peter-evans/create-pull-request from 5 to 6 - \[[`25cab09`](https://togithub.com/vmware/govmomi/commit/25cab091)] Re-enable PC updates for indexed properties ([#​3349](https://togithub.com/vmware/govmomi/issues/3349)) - \[[`8150eed`](https://togithub.com/vmware/govmomi/commit/8150eedd)] build(deps): bump andstor/file-existence-action from 2 to 3 - \[[`bfc5d64`](https://togithub.com/vmware/govmomi/commit/bfc5d64c)] build(deps): bump peter-evans/create-or-update-comment from 3 to 4 - \[[`42d7d71`](https://togithub.com/vmware/govmomi/commit/42d7d711)] Add new "UsedCapacityInMb" in struct "CnsBlockBackingDetails" - \[[`61f901e`](https://togithub.com/vmware/govmomi/commit/61f901eb)] build(deps): bump github.com/google/uuid from 1.5.0 to 1.6.0 - \[[`3b5917a`](https://togithub.com/vmware/govmomi/commit/3b5917a2)] build(deps): bump actions/cache from 3 to 4 - \[[`78898bd`](https://togithub.com/vmware/govmomi/commit/78898bd2)] Self identify the executable making calls to vCenter - \[[`95aa257`](https://togithub.com/vmware/govmomi/commit/95aa2571)] api: WaitForUpdatesEx & DestroyPropertyFilter - \[[`cd8a788`](https://togithub.com/vmware/govmomi/commit/cd8a7883)] Changes to fix xml tag used for SnapshotId - \[[`557d265`](https://togithub.com/vmware/govmomi/commit/557d2654)] vcsim: Fix -method-delay option to update task states ([#​3323](https://togithub.com/vmware/govmomi/issues/3323)) - \[[`98b0b77`](https://togithub.com/vmware/govmomi/commit/98b0b77f)] Fixes Missing Tags in AttachedTags ([#​3320](https://togithub.com/vmware/govmomi/issues/3320)) - \[[`5410a06`](https://togithub.com/vmware/govmomi/commit/5410a069)] Changes to add CNS fault CnsSnapshotCreatedFault - \[[`8c1d8f1`](https://togithub.com/vmware/govmomi/commit/8c1d8f18)] build(deps): bump actions/upload-artifact from 3 to 4 - \[[`14d3538`](https://togithub.com/vmware/govmomi/commit/14d35380)] build(deps): bump github/codeql-action from 2 to 3 - \[[`f6c537d`](https://togithub.com/vmware/govmomi/commit/f6c537d7)] build(deps): bump github.com/google/uuid from 1.4.0 to 1.5.0 - \[[`e9a9f2c`](https://togithub.com/vmware/govmomi/commit/e9a9f2c0)] build(deps): bump chuhlomin/render-template from 1.8 to 1.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update module go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp to v0.48.0 (#31231) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://togithub.com/open-telemetry/opentelemetry-go-contrib) | `v0.47.0` -> `v0.48.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fcontrib%2finstrumentation%2fnet%2fhttp%2fotelhttp/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fcontrib%2finstrumentation%2fnet%2fhttp%2fotelhttp/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fcontrib%2finstrumentation%2fnet%2fhttp%2fotelhttp/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fcontrib%2finstrumentation%2fnet%2fhttp%2fotelhttp/v0.47.0/v0.48.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> * Update opentelemetry-go monorepo (#31204) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [go.opentelemetry.io/otel](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracegrpc/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracegrpc/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracegrpc/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracegrpc/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracehttp/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracehttp/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracehttp/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fexporters%2fotlp%2fotlptrace%2fotlptracehttp/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/exporters/prometheus](https://togithub.com/open-telemetry/opentelemetry-go) | `v0.45.1` -> `v0.45.2` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fexporters%2fprometheus/v0.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fexporters%2fprometheus/v0.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fexporters%2fprometheus/v0.45.1/v0.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fexporters%2fprometheus/v0.45.1/v0.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/metric](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fmetric/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fmetric/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fmetric/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fmetric/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/sdk](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fsdk/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fsdk/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fsdk/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fsdk/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/sdk/metric](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2fsdk%2fmetric/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2fsdk%2fmetric/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2fsdk%2fmetric/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2fsdk%2fmetric/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [go.opentelemetry.io/otel/trace](https://togithub.com/open-telemetry/opentelemetry-go) | `v1.23.0` -> `v1.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/go.opentelemetry.io%2fotel%2ftrace/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/go.opentelemetry.io%2fotel%2ftrace/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/go.opentelemetry.io%2fotel%2ftrace/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/go.opentelemetry.io%2fotel%2ftrace/v1.23.0/v1.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-go (go.opentelemetry.io/otel)</summary> ### [`v1.23.1`](https://togithub.com/open-telemetry/opentelemetry-go/releases/tag/v1.23.1): /v0.45.2 [Compare Source](https://togithub.com/open-telemetry/opentelemetry-go/compare/v1.23.0...v1.23.1) ##### Fixed - Register all callbacks passed during observable instrument creation instead of just the last one multiple times in `go.opentelemetry.io/otel/sdk/metric`. ([#​4888](https://togithub.com/open-telemetry/opentelemetry-go/issues/4888)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com> * Update All github.com/datadog packages (#31194) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/DataDog/agent-payload/v5](https://togithub.com/DataDog/agent-payload) | `v5.0.103` -> `v5.0.104` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fagent-payload%2fv5/v5.0.104?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fagent-payload%2fv5/v5.0.104?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fagent-payload%2fv5/v5.0.103/v5.0.104?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fagent-payload%2fv5/v5.0.103/v5.0.104?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/opentelemetry-mapping-go/pkg/inframetadata](https://togithub.com/DataDog/opentelemetry-mapping-go) | `v0.13.2` -> `v0.13.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2finframetadata/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2finframetadata/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2finframetadata/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2finframetadata/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes](https://togithub.com/DataDog/opentelemetry-mapping-go) | `v0.13.2` -> `v0.13.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2fattributes/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2fattributes/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2fattributes/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2fattributes/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/logs](https://togithub.com/DataDog/opentelemetry-mapping-go) | `v0.13.2` -> `v0.13.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2flogs/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2flogs/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2flogs/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fDataDog%2fopentelemetry-mapping-go%2fpkg%2fotlp%2flogs/v0.13.2/v0.13.3?slim=true)](https://docs.renovatebot.com/merge-co…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/awsemf
awsemf exporter
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
addToGroupedMetric
previously took the logger as well as the config as arguments. However, the logger is already available as a field in the config so it is redundant to pass it separately.This commit removes the logger argument.
Testing:
The affected unit tests were updated