Adding an optional replacementFormat argument to the replace_pattern editors that specified the format of the replacement string #30837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnishtala-sumo
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
2 times, most recently
from
5fe3ba6 to
2e1cb9d
Compare
There was a problem hiding this comment.
I looked over this quickly and I definitely prefer this solution to #30403. I'll try an do an in-depth review later this week.
Also the latest comment in the issue highlights why I am glad we are taking our time with this issue, as neither PRs would help that user. Currying and/or some other generic looping solution continues to look promising.
TylerHelmuth
reviewed
Feb 1, 2024
TylerHelmuth
approved these changes
Feb 2, 2024
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
2 times, most recently
from
d28cecd to
eafac30
Compare
|
@TylerHelmuth @evan-bradley thanks for looking at this! 👍 Please let me know if there are any other concerns |
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
3 times, most recently
from
e596b45 to
88e8915
Compare
evan-bradley
reviewed
Feb 9, 2024
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
88e8915 to
cf3c9ac
Compare
|
@evan-bradley I've added support for replacement format in the |
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
f4b940f to
91e2a9c
Compare
evan-bradley
reviewed
Feb 9, 2024
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
3 times, most recently
from
a6aa6da to
df5422d
Compare
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
2 times, most recently
from
c98078a to
9761559
Compare
evan-bradley
approved these changes
Feb 13, 2024
…replace_pattern editors
rnishtala-sumo
force-pushed
the
ottl-replace-pattern
branch
from
9761559 to
b72a525
Compare
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…editors that specified the format of the replacement string (open-telemetry#30837) Description: Adding an optional replacementFormat argument to the replace_pattern editors that specified the format of the replacement string Testing: Unit tests were added for this new optional argument Documentation: https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding an optional replacementFormat argument to the replace_pattern editors that specified the format of the replacement string
Testing: Unit tests were added for this new optional argument
Documentation:
https://github.com/rnishtala-sumo/opentelemetry-collector-contrib/blob/ottl-replace-pattern/pkg/ottl/ottlfuncs/README.md#replace_pattern