[chore][exporter/fileexporter] Enable goleak check #30899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
approved these changes
Jan 31, 2024
djaglowski
approved these changes
Jan 31, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This enables `goleak` to check for any leaking goroutines in this package. There is an existing goleak, but it's in a third party dependency which we cannot resolve on our end. There's been a [PR open for this issue](natefinch/lumberjack#57) for 6 years and it hasn't been merged. **Note:** The `natefinch/lumberjack` package is now unmaintained, so this will likely never be fixed. We should consider moving to a new package if possible to avoid the leak. I'll defer to code owners for feedback on possible options. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#30438 **Testing:** <Describe what testing was performed and which tests were added.> Existing tests and added goleak check are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables
goleakto check for any leaking goroutines in this package. There is an existing goleak, but it's in a third party dependency which we cannot resolve on our end. There's been a PR open for this issue for 6 years and it hasn't been merged.Note: The
natefinch/lumberjackpackage is now unmaintained, so this will likely never be fixed. We should consider moving to a new package if possible to avoid the leak. I'll defer to code owners for feedback on possible options.Link to tracking Issue:
#30438
Testing:
Existing tests and added goleak check are passing.